Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-31 01:13:39 +02:00
Code Issues Activity

Some improvements

Browse Source
This commit is contained in:
Lunny Xiao
2025-05-25 12:39:38 -07:00
parent 43ed136609
commit 083e0ba97a
10 changed files with 40 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/pull/commit_status.go
+1 -1
View File
@@ -51,7 +51,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*git_model.CommitStatus,
func IsCommitStatusContextSuccess(commitStatuses []*git_model.CommitStatus, requiredContexts []string) bool {
// If no specific context is required, require that last commit status is a success
if len(requiredContexts) == 0 {
return git_model.CalcCombinedStatusState(commitStatuses) == commitstatus.CombinedStatusStateSuccess
return git_model.CalcCombinedStatusState(commitStatuses) == commitstatus.CombinedStatusSuccess
}
for _, ctx := range requiredContexts {
services/pull/commit_status_test.go
+5 -5
View File
@@ -50,11 +50,11 @@ func TestMergeRequiredContextsCommitStatus(t *testing.T) {
}
testCasesExpected := []commitstatus.CombinedStatusState{
commitstatus.CombinedStatusStateSuccess,
commitstatus.CombinedStatusStatePending,
commitstatus.CombinedStatusStateFailure,
commitstatus.CombinedStatusStatePending,
commitstatus.CombinedStatusStateSuccess,
commitstatus.CombinedStatusSuccess,
commitstatus.CombinedStatusPending,
commitstatus.CombinedStatusFailure,
commitstatus.CombinedStatusPending,
commitstatus.CombinedStatusSuccess,
}
for i, commitStatuses := range testCases {