From 0d7cf7b76883b6bdba324e6f2f40ae69f6aa5977 Mon Sep 17 00:00:00 2001
From: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
Date: Wed, 15 Mar 2023 14:42:21 +0800
Subject: [PATCH] Disable sending email after push a commit to a closed PR
(#23462)
Close #23440
Cause by #23189
In #23189, we should insert a comment record into db when pushing a
commit to the PR, even if the PR is closed.
But should skip sending any notification in this case.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
---
services/pull/pull.go | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/services/pull/pull.go b/services/pull/pull.go
index e40e59a2c5..e1d5a6f86d 100644
--- a/services/pull/pull.go
+++ b/services/pull/pull.go
@@ -274,9 +274,12 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
continue
}
+ // If the PR is closed, someone still push some commits to the PR,
+ // 1. We will insert comments of commits, but hidden until the PR is reopened.
+ // 2. We won't send any notification.
AddToTaskQueue(pr)
comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
- if err == nil && comment != nil {
+ if err == nil && comment != nil && !pr.Issue.IsClosed {
notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
}
}