From 10ac130ec78e45b4bee360d91267a51fef227721 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=98=99=E2=97=A6=20The=20Tablet=20=E2=9D=80=20GamerGirla?= =?UTF-8?q?ndCo=20=E2=97=A6=E2=9D=A7?= Date: Sat, 20 Dec 2025 15:24:02 -0500 Subject: [PATCH] fix: update group assignment to fix incorrect 404s --- services/context/group.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/context/group.go b/services/context/group.go index 770d147bd2..545465083e 100644 --- a/services/context/group.go +++ b/services/context/group.go @@ -242,7 +242,7 @@ func groupAssignment(ctx *Context) (bool, error) { } ctx.RepoGroup.IsGroupAdmin = ctx.RepoGroup.IsGroupAdmin || isAdmin } - return canAccess && (ctx.RepoGroup.IsGroupAdmin || ctx.RepoGroup.IsMember || ctx.RepoGroup.IsOwner), nil + return canAccess, nil } func GroupAssignment(args GroupAssignmentOptions) func(ctx *Context) { @@ -263,7 +263,7 @@ func GroupAssignment(args GroupAssignmentOptions) func(ctx *Context) { if ctx.RepoGroup.Group.Visibility == structs.VisibleTypePrivate { args.RequireMember = true - } else if ctx.IsSigned && !ca { + } else if ctx.IsSigned && (!ca && ctx.RepoGroup.Group.Visibility != structs.VisibleTypePublic) { ctx.NotFound(err) return }