From 13660f202d7a4a0de215a46bbf576ae73fdac039 Mon Sep 17 00:00:00 2001 From: Excellencedev Date: Sat, 3 Jan 2026 13:39:01 +0100 Subject: [PATCH] cleanup --- models/perm/access/repo_permission.go | 2 +- tests/integration/actions_job_token_test.go | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/models/perm/access/repo_permission.go b/models/perm/access/repo_permission.go index 164feccbea..4ab8244517 100644 --- a/models/perm/access/repo_permission.go +++ b/models/perm/access/repo_permission.go @@ -95,7 +95,7 @@ func (p *Permission) UnitAccessMode(unitType unit.Type) perm_model.AccessMode { if m, ok := p.unitsMode[unitType]; ok { return util.Iif(p.AccessMode >= perm_model.AccessModeAdmin, p.AccessMode, m) } - // If the units map does not contain the access mode, return the default access mode if the unit exists + // if the units map does not contain the access mode, return the default access mode if the unit exists unitDefaultAccessMode := p.AccessMode unitDefaultAccessMode = max(unitDefaultAccessMode, p.anonymousAccessMode[unitType]) unitDefaultAccessMode = max(unitDefaultAccessMode, p.everyoneAccessMode[unitType]) diff --git a/tests/integration/actions_job_token_test.go b/tests/integration/actions_job_token_test.go index e446ff8016..4a0dfab4ba 100644 --- a/tests/integration/actions_job_token_test.go +++ b/tests/integration/actions_job_token_test.go @@ -712,7 +712,6 @@ jobs: require.NoError(t, db.Insert(t.Context(), job)) // 3. Change Repo Settings to RESTRICTED - // We need to update the RepoUnit config unitConfig := &repo_model.ActionsConfig{ TokenPermissionMode: repo_model.ActionsTokenPermissionModeRestricted, } @@ -727,11 +726,6 @@ jobs: require.NoError(t, repo_model.UpdateRepoUnit(t.Context(), unit)) // 4. Trigger Rerun via Web Handler - // POST /:username/:reponame/actions/runs/:index/rerun - // We need to know operation run index. Since it's the first run, it should be 1? - // ActionRun.Index is auto-increment but not set in my insert. - // Ideally we use CreateRun which handles index. - // Let's manually set index 1. run.Index = 1 _, err = db.GetEngine(t.Context()).ID(run.ID).Cols("index").Update(run) require.NoError(t, err)