mirror of
https://github.com/go-gitea/gitea.git
synced 2026-02-22 13:15:23 +01:00
Merge caf2f9bbe3acf23af869d47a966272689bc13b8b into bbea5e6c2d75a4a710d7838b7bec7e851e046d3c
This commit is contained in:
commit
14a0189cde
@ -294,6 +294,18 @@ This reduces unnecessary CI runs. \
|
||||
Don't worry about merge commits messing up your commit history as every PR will be squash merged. \
|
||||
This means that all changes are joined into a single new commit whose message is as described below.
|
||||
|
||||
### Reviewing PRs
|
||||
|
||||
Maintainers are encouraged to review pull requests in areas where they have expertise or particular interest. When reviewing, please keep the following principles in mind:
|
||||
|
||||
- Ensure the PR summary accurately reflects the changes, and verify that the tests and documentation are complete and aligned with the implementation.
|
||||
|
||||
- Provide actionable feedback. Clearly explain what needs to be changed and why, and distinguish between required changes and optional suggestions.
|
||||
|
||||
- If you request changes (i.e., block a PR), you must provide a clear rationale and, whenever possible, outline a concrete path to resolution. Reviews that do not include sufficient explanation are not constructive and may be disregarded.
|
||||
|
||||
- Only approve a PR when you are fully satisfied with its current state.
|
||||
|
||||
### Getting PRs merged
|
||||
|
||||
Changes to Gitea must be reviewed before they are accepted — no matter who
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user