From 48e3e38ee040c9cfec6ea2adea2da49a7f21f2c7 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Thu, 4 May 2023 02:32:10 +0800 Subject: [PATCH 01/97] Clean up polluted styles and remove dead CSS code (#24497) Follow #24393 The funny history: * At the beginning, `.ui.message` was polluted by `text-align: center` * Then people do `
` * But `.ui.left` is polluted by `float: left` * Then people do `#xxx .ui.message { width: 100% !important;}` The code just becomes more and more hacky. After removing the pollution, everything becomes clear and straight. And, this PR also does: 1. Remove the `package.css`, its styles could be provided by `top aligned` 2. Remove `#avatar-arrow`, dead code Screenshot: ![image](https://user-images.githubusercontent.com/2114189/235862130-a9eb5d8f-7d01-457c-99f7-21d0abc3075e.png) ![image](https://user-images.githubusercontent.com/2114189/235862222-139709a7-95c2-4f89-a40f-100b2d76d9bb.png) Co-authored-by: Giteabot --- templates/base/alert.tmpl | 8 ++--- templates/package/content/container.tmpl | 6 ++-- templates/package/settings.tmpl | 2 +- templates/repo/issue/view_content/pull.tmpl | 2 +- .../repo/issue/view_content/sidebar.tmpl | 2 +- templates/repo/migrate/migrating.tmpl | 2 +- templates/repo/settings/options.tmpl | 10 +++--- web_src/css/base.css | 2 +- web_src/css/index.css | 1 - web_src/css/package.css | 7 ---- web_src/css/repository.css | 33 ------------------- 11 files changed, 17 insertions(+), 58 deletions(-) delete mode 100644 web_src/css/package.css diff --git a/templates/base/alert.tmpl b/templates/base/alert.tmpl index b8a04b89a95..160584f769b 100644 --- a/templates/base/alert.tmpl +++ b/templates/base/alert.tmpl @@ -1,20 +1,20 @@ {{if .Flash.ErrorMsg}} -
+

{{.Flash.ErrorMsg | Str2html}}

{{end}} {{if .Flash.SuccessMsg}} -
+

{{.Flash.SuccessMsg | Str2html}}

{{end}} {{if .Flash.InfoMsg}} -
+

{{.Flash.InfoMsg | Str2html}}

{{end}} {{if .Flash.WarningMsg}} -
+

{{.Flash.WarningMsg | Str2html}}

{{end}} diff --git a/templates/package/content/container.tmpl b/templates/package/content/container.tmpl index 3370ebca3f1..d928b36e604 100644 --- a/templates/package/content/container.tmpl +++ b/templates/package/content/container.tmpl @@ -69,7 +69,7 @@ {{if .PackageDescriptor.Metadata.Labels}}

{{.locale.Tr "packages.container.labels"}}

- +
@@ -79,8 +79,8 @@ {{range $key, $value := .PackageDescriptor.Metadata.Labels}} - - + + {{end}} diff --git a/templates/package/settings.tmpl b/templates/package/settings.tmpl index 7beb3da0621..205d875c3ee 100644 --- a/templates/package/settings.tmpl +++ b/templates/package/settings.tmpl @@ -51,7 +51,7 @@ {{.locale.Tr "packages.settings.delete"}}
-
+
{{.locale.Tr "packages.settings.delete.notice" .PackageDescriptor.Package.Name .PackageDescriptor.Version.Version}}
diff --git a/templates/repo/issue/view_content/pull.tmpl b/templates/repo/issue/view_content/pull.tmpl index ec957161b1a..29d8d9d47ce 100644 --- a/templates/repo/issue/view_content/pull.tmpl +++ b/templates/repo/issue/view_content/pull.tmpl @@ -47,7 +47,7 @@ {{$.locale.Tr "repo.issues.dismiss_review"}}
-
+
{{$.locale.Tr "repo.issues.dismiss_review_warning"}}
diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl index e07ef0fa374..86796a91cbb 100644 --- a/templates/repo/issue/view_content/sidebar.tmpl +++ b/templates/repo/issue/view_content/sidebar.tmpl @@ -560,7 +560,7 @@ {{end}}
-
+
{{if .Issue.IsLocked}} {{.locale.Tr "repo.issues.unlock.notice_1"}}
{{.locale.Tr "repo.issues.unlock.notice_2"}}
diff --git a/templates/repo/migrate/migrating.tmpl b/templates/repo/migrate/migrating.tmpl index 51caa28aa18..72c3fe56648 100644 --- a/templates/repo/migrate/migrating.tmpl +++ b/templates/repo/migrate/migrating.tmpl @@ -50,7 +50,7 @@ {{.locale.Tr "repo.settings.delete"}}
-
+
{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}
{{.locale.Tr "repo.settings.delete_notices_2" .Repository.FullName | Safe}} {{if .Repository.NumForks}}
diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl index 515854609a1..af753ba670a 100644 --- a/templates/repo/settings/options.tmpl +++ b/templates/repo/settings/options.tmpl @@ -803,7 +803,7 @@ {{.locale.Tr "repo.settings.convert"}}
-
+
{{.locale.Tr "repo.settings.convert_notices_1"}}
@@ -834,7 +834,7 @@ {{.locale.Tr "repo.settings.convert_fork"}}
-
+
{{.locale.Tr "repo.settings.convert_fork_notices_1"}}
@@ -864,7 +864,7 @@ {{.locale.Tr "repo.settings.transfer"}}
-
+
{{.locale.Tr "repo.settings.transfer_notices_1"}}
{{.locale.Tr "repo.settings.transfer_notices_2"}}
{{.locale.Tr "repo.settings.transfer_notices_3"}} @@ -900,7 +900,7 @@ {{.locale.Tr "repo.settings.delete"}}
-
+
{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}
{{.locale.Tr "repo.settings.delete_notices_2" .Repository.FullName | Safe}} {{if .Repository.NumForks}}
@@ -935,7 +935,7 @@ {{.locale.Tr "repo.settings.wiki_delete"}}
-
+
{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}
{{.locale.Tr "repo.settings.wiki_delete_notices_1" .Repository.Name | Safe}}
diff --git a/web_src/css/base.css b/web_src/css/base.css index 0f94d22312d..d854f9badd7 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -1556,7 +1556,7 @@ img.ui.avatar, vertical-align: middle; } -.ui .message { +.ui .message.flash-message { text-align: center; } diff --git a/web_src/css/index.css b/web_src/css/index.css index 12cb94c0418..6fb92f2ecb2 100644 --- a/web_src/css/index.css +++ b/web_src/css/index.css @@ -41,6 +41,5 @@ @import "./admin.css"; @import "./explore.css"; @import "./review.css"; -@import "./package.css"; @import "./runner.css"; @import "./helpers.css"; diff --git a/web_src/css/package.css b/web_src/css/package.css deleted file mode 100644 index c229e176f52..00000000000 --- a/web_src/css/package.css +++ /dev/null @@ -1,7 +0,0 @@ -.container-labels td:nth-child(1) { - vertical-align: top; -} - -.container-labels td:nth-child(2) { - overflow-wrap: anywhere; -} diff --git a/web_src/css/repository.css b/web_src/css/repository.css index 5b32fbb95ed..d724dc400a2 100644 --- a/web_src/css/repository.css +++ b/web_src/css/repository.css @@ -2600,39 +2600,6 @@ height: 15px; } -#avatar-arrow::before, -#avatar-arrow::after { - right: 100%; - top: 20px; - border: solid transparent; - content: " "; - height: 0; - width: 0; - position: absolute; - pointer-events: none; -} - -#avatar-arrow::before { - border-right-color: var(--color-secondary); - border-width: 9px; - margin-top: -9px; -} - -#avatar-arrow::after { - border-right-color: var(--color-box-header); - border-width: 8px; - margin-top: -8px; -} - -#transfer-repo-modal .ui.message, -#delete-repo-modal .ui.message, -#delete-wiki-modal .ui.message, -#convert-fork-repo-modal .ui.message, -#convert-mirror-repo-modal .ui.message, -#fork-repo-modal .ui.message { - width: 100% !important; -} - .tab-size-1 { tab-size: 1 !important; -moz-tab-size: 1 !important; From 723598b803919bfc074fee05f830421a99881c3b Mon Sep 17 00:00:00 2001 From: KN4CK3R Date: Wed, 3 May 2023 22:58:43 +0200 Subject: [PATCH 02/97] Implement Cargo HTTP index (#24452) This implements the HTTP index [RFC](https://rust-lang.github.io/rfcs/2789-sparse-index.html) for Cargo registries. Currently this is a preview feature and you need to use the nightly of `cargo`: `cargo +nightly -Z sparse-registry update` See https://github.com/rust-lang/cargo/issues/9069 for more information. --------- Co-authored-by: Giteabot --- routers/api/packages/api.go | 6 ++ routers/api/packages/cargo/cargo.go | 30 ++++++ services/packages/cargo/index.go | 36 +++++-- tests/integration/api_packages_cargo_test.go | 102 ++++++++++++++----- 4 files changed, 136 insertions(+), 38 deletions(-) diff --git a/routers/api/packages/api.go b/routers/api/packages/api.go index 04b0c0ab08d..ee1feb1414c 100644 --- a/routers/api/packages/api.go +++ b/routers/api/packages/api.go @@ -119,6 +119,12 @@ func CommonRoutes(ctx gocontext.Context) *web.Route { r.Get("/owners", cargo.ListOwners) }) }) + r.Get("/config.json", cargo.RepositoryConfig) + r.Get("/1/{package}", cargo.EnumeratePackageVersions) + r.Get("/2/{package}", cargo.EnumeratePackageVersions) + // Use dummy placeholders because these parts are not of interest + r.Get("/3/{_}/{package}", cargo.EnumeratePackageVersions) + r.Get("/{_}/{__}/{package}", cargo.EnumeratePackageVersions) }, reqPackageAccess(perm.AccessModeRead)) r.Group("/chef", func() { r.Group("/api/v1", func() { diff --git a/routers/api/packages/cargo/cargo.go b/routers/api/packages/cargo/cargo.go index 18c93d328ab..b666bdde6c9 100644 --- a/routers/api/packages/cargo/cargo.go +++ b/routers/api/packages/cargo/cargo.go @@ -4,6 +4,7 @@ package cargo import ( + "errors" "fmt" "net/http" "strconv" @@ -45,6 +46,35 @@ func apiError(ctx *context.Context, status int, obj interface{}) { }) } +// https://rust-lang.github.io/rfcs/2789-sparse-index.html +func RepositoryConfig(ctx *context.Context) { + ctx.JSON(http.StatusOK, cargo_service.BuildConfig(ctx.Package.Owner)) +} + +func EnumeratePackageVersions(ctx *context.Context) { + p, err := packages_model.GetPackageByName(ctx, ctx.Package.Owner.ID, packages_model.TypeCargo, ctx.Params("package")) + if err != nil { + if errors.Is(err, util.ErrNotExist) { + apiError(ctx, http.StatusNotFound, err) + } else { + apiError(ctx, http.StatusInternalServerError, err) + } + return + } + + b, err := cargo_service.BuildPackageIndex(ctx, p) + if err != nil { + apiError(ctx, http.StatusInternalServerError, err) + return + } + if b == nil { + apiError(ctx, http.StatusNotFound, nil) + return + } + + ctx.PlainTextBytes(http.StatusOK, b.Bytes()) +} + type SearchResult struct { Crates []*SearchResultCrate `json:"crates"` Meta SearchResultMeta `json:"meta"` diff --git a/services/packages/cargo/index.go b/services/packages/cargo/index.go index e58a4728162..1c2d17b504f 100644 --- a/services/packages/cargo/index.go +++ b/services/packages/cargo/index.go @@ -137,21 +137,21 @@ type IndexVersionEntry struct { Links string `json:"links,omitempty"` } -func addOrUpdatePackageIndex(ctx context.Context, t *files_service.TemporaryUploadRepository, p *packages_model.Package) error { +func BuildPackageIndex(ctx context.Context, p *packages_model.Package) (*bytes.Buffer, error) { pvs, _, err := packages_model.SearchVersions(ctx, &packages_model.PackageSearchOptions{ PackageID: p.ID, Sort: packages_model.SortVersionAsc, }) if err != nil { - return fmt.Errorf("SearchVersions[%s]: %w", p.Name, err) + return nil, fmt.Errorf("SearchVersions[%s]: %w", p.Name, err) } if len(pvs) == 0 { - return nil + return nil, nil } pds, err := packages_model.GetPackageDescriptors(ctx, pvs) if err != nil { - return fmt.Errorf("GetPackageDescriptors[%s]: %w", p.Name, err) + return nil, fmt.Errorf("GetPackageDescriptors[%s]: %w", p.Name, err) } var b bytes.Buffer @@ -179,14 +179,26 @@ func addOrUpdatePackageIndex(ctx context.Context, t *files_service.TemporaryUplo Links: metadata.Links, }) if err != nil { - return err + return nil, err } b.Write(entry) b.WriteString("\n") } - return writeObjectToIndex(t, BuildPackagePath(pds[0].Package.LowerName), &b) + return &b, nil +} + +func addOrUpdatePackageIndex(ctx context.Context, t *files_service.TemporaryUploadRepository, p *packages_model.Package) error { + b, err := BuildPackageIndex(ctx, p) + if err != nil { + return err + } + if b == nil { + return nil + } + + return writeObjectToIndex(t, BuildPackagePath(p.LowerName), b) } func getOrCreateIndexRepository(ctx context.Context, doer, owner *user_model.User) (*repo_model.Repository, error) { @@ -212,6 +224,13 @@ type Config struct { APIURL string `json:"api"` } +func BuildConfig(owner *user_model.User) *Config { + return &Config{ + DownloadURL: setting.AppURL + "api/packages/" + owner.Name + "/cargo/api/v1/crates", + APIURL: setting.AppURL + "api/packages/" + owner.Name + "/cargo", + } +} + func createOrUpdateConfigFile(ctx context.Context, repo *repo_model.Repository, doer, owner *user_model.User) error { return alterRepositoryContent( ctx, @@ -220,10 +239,7 @@ func createOrUpdateConfigFile(ctx context.Context, repo *repo_model.Repository, "Initialize Cargo Config", func(t *files_service.TemporaryUploadRepository) error { var b bytes.Buffer - err := json.NewEncoder(&b).Encode(Config{ - DownloadURL: setting.AppURL + "api/packages/" + owner.Name + "/cargo/api/v1/crates", - APIURL: setting.AppURL + "api/packages/" + owner.Name + "/cargo", - }) + err := json.NewEncoder(&b).Encode(BuildConfig(owner)) if err != nil { return err } diff --git a/tests/integration/api_packages_cargo_test.go b/tests/integration/api_packages_cargo_test.go index 0c542eaf1e8..608f1929681 100644 --- a/tests/integration/api_packages_cargo_test.go +++ b/tests/integration/api_packages_cargo_test.go @@ -98,7 +98,7 @@ func testPackageCargo(t *testing.T, _ *neturl.URL) { url := fmt.Sprintf("%s/api/v1/crates", root) t.Run("Index", func(t *testing.T) { - t.Run("Config", func(t *testing.T) { + t.Run("Git/Config", func(t *testing.T) { defer tests.PrintCurrentTest(t)() content := readGitContent(t, cargo_service.ConfigFileName) @@ -110,6 +110,20 @@ func testPackageCargo(t *testing.T, _ *neturl.URL) { assert.Equal(t, url, config.DownloadURL) assert.Equal(t, root, config.APIURL) }) + + t.Run("HTTP/Config", func(t *testing.T) { + defer tests.PrintCurrentTest(t)() + + req := NewRequest(t, "GET", root+"/"+cargo_service.ConfigFileName) + resp := MakeRequest(t, req, http.StatusOK) + + var config cargo_service.Config + err := json.Unmarshal(resp.Body.Bytes(), &config) + assert.NoError(t, err) + + assert.Equal(t, url, config.DownloadURL) + assert.Equal(t, root, config.APIURL) + }) }) t.Run("Upload", func(t *testing.T) { @@ -192,40 +206,72 @@ func testPackageCargo(t *testing.T, _ *neturl.URL) { MakeRequest(t, req, http.StatusConflict) t.Run("Index", func(t *testing.T) { - t.Run("Entry", func(t *testing.T) { - defer tests.PrintCurrentTest(t)() + t.Run("Git", func(t *testing.T) { + t.Run("Entry", func(t *testing.T) { + defer tests.PrintCurrentTest(t)() - content := readGitContent(t, cargo_service.BuildPackagePath(packageName)) + content := readGitContent(t, cargo_service.BuildPackagePath(packageName)) - var entry cargo_service.IndexVersionEntry - err := json.Unmarshal([]byte(content), &entry) - assert.NoError(t, err) + var entry cargo_service.IndexVersionEntry + err := json.Unmarshal([]byte(content), &entry) + assert.NoError(t, err) - assert.Equal(t, packageName, entry.Name) - assert.Equal(t, packageVersion, entry.Version) - assert.Equal(t, pb.HashSHA256, entry.FileChecksum) - assert.False(t, entry.Yanked) - assert.Len(t, entry.Dependencies, 1) - dep := entry.Dependencies[0] - assert.Equal(t, "dep", dep.Name) - assert.Equal(t, "1.0", dep.Req) - assert.Equal(t, "normal", dep.Kind) - assert.True(t, dep.DefaultFeatures) - assert.Empty(t, dep.Features) - assert.False(t, dep.Optional) - assert.Nil(t, dep.Target) - assert.NotNil(t, dep.Registry) - assert.Equal(t, "https://gitea.io/user/_cargo-index", *dep.Registry) - assert.Nil(t, dep.Package) + assert.Equal(t, packageName, entry.Name) + assert.Equal(t, packageVersion, entry.Version) + assert.Equal(t, pb.HashSHA256, entry.FileChecksum) + assert.False(t, entry.Yanked) + assert.Len(t, entry.Dependencies, 1) + dep := entry.Dependencies[0] + assert.Equal(t, "dep", dep.Name) + assert.Equal(t, "1.0", dep.Req) + assert.Equal(t, "normal", dep.Kind) + assert.True(t, dep.DefaultFeatures) + assert.Empty(t, dep.Features) + assert.False(t, dep.Optional) + assert.Nil(t, dep.Target) + assert.NotNil(t, dep.Registry) + assert.Equal(t, "https://gitea.io/user/_cargo-index", *dep.Registry) + assert.Nil(t, dep.Package) + }) + + t.Run("Rebuild", func(t *testing.T) { + defer tests.PrintCurrentTest(t)() + + err := cargo_service.RebuildIndex(db.DefaultContext, user, user) + assert.NoError(t, err) + + _ = readGitContent(t, cargo_service.BuildPackagePath(packageName)) + }) }) - t.Run("Rebuild", func(t *testing.T) { - defer tests.PrintCurrentTest(t)() + t.Run("HTTP", func(t *testing.T) { + t.Run("Entry", func(t *testing.T) { + defer tests.PrintCurrentTest(t)() - err := cargo_service.RebuildIndex(db.DefaultContext, user, user) - assert.NoError(t, err) + req := NewRequest(t, "GET", root+"/"+cargo_service.BuildPackagePath(packageName)) + resp := MakeRequest(t, req, http.StatusOK) - _ = readGitContent(t, cargo_service.BuildPackagePath(packageName)) + var entry cargo_service.IndexVersionEntry + err := json.Unmarshal(resp.Body.Bytes(), &entry) + assert.NoError(t, err) + + assert.Equal(t, packageName, entry.Name) + assert.Equal(t, packageVersion, entry.Version) + assert.Equal(t, pb.HashSHA256, entry.FileChecksum) + assert.False(t, entry.Yanked) + assert.Len(t, entry.Dependencies, 1) + dep := entry.Dependencies[0] + assert.Equal(t, "dep", dep.Name) + assert.Equal(t, "1.0", dep.Req) + assert.Equal(t, "normal", dep.Kind) + assert.True(t, dep.DefaultFeatures) + assert.Empty(t, dep.Features) + assert.False(t, dep.Optional) + assert.Nil(t, dep.Target) + assert.NotNil(t, dep.Registry) + assert.Equal(t, "https://gitea.io/user/_cargo-index", *dep.Registry) + assert.Nil(t, dep.Package) + }) }) }) }) From 4a722c9a45659e7732258397bbb3dd1039ea1952 Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 3 May 2023 23:58:59 +0200 Subject: [PATCH 03/97] Make Issue/PR/projects more compact, misc CSS tweaks (#24459) - Remove various horizontal dividers on repo pages that didn't provide visual benefit - Remove label/milestone pills on single issue/pr page - Remove issue-related pill buttons on projects page - Increase contrast of color-secondary on arc-green - Improve notifications icon, make circle bigger - Remove some inline styles - Fix focus in issue/pr title edit and select all text on button click ### Issue and PR before and after Screenshot 2023-05-01 at 11 44 22 Screenshot 2023-05-01 at 11 58 51 ### Projects before and after Screenshot 2023-05-01 at 11 41 02 Screenshot 2023-05-01 at 11 40 03 ### Releases before and after Screenshot 2023-05-01 at 11 41 12 Screenshot 2023-05-01 at 11 40 10 ### Misc Screenshot 2023-05-01 at 10 49 13 Screenshot 2023-05-01 at 18 57 08 Issue title edit and wrap: Screenshot 2023-05-01 at 12 34 40 Screenshot 2023-05-01 at 12 06 24 --------- Co-authored-by: wxiaoguang --- templates/org/member/members.tmpl | 2 +- templates/projects/list.tmpl | 2 +- templates/repo/actions/openclose.tmpl | 2 +- templates/repo/branch_dropdown.tmpl | 9 +- templates/repo/commits.tmpl | 2 +- templates/repo/home.tmpl | 2 +- templates/repo/issue/labels.tmpl | 3 +- templates/repo/issue/list.tmpl | 3 - templates/repo/issue/milestones.tmpl | 5 +- templates/repo/issue/navbar.tmpl | 2 +- templates/repo/issue/new.tmpl | 4 - templates/repo/issue/openclose.tmpl | 2 +- templates/repo/issue/view.tmpl | 25 +-- templates/repo/issue/view_content.tmpl | 9 - templates/repo/issue/view_title.tmpl | 194 ++++++++++-------- templates/repo/projects/list.tmpl | 62 +++--- templates/repo/pulls/commits.tmpl | 11 +- templates/repo/pulls/files.tmpl | 14 +- templates/repo/release/list.tmpl | 10 +- templates/repo/settings/options.tmpl | 6 +- templates/repo/sub_menu_release_tag.tmpl | 2 +- templates/user/dashboard/issues.tmpl | 2 +- templates/user/dashboard/milestones.tmpl | 2 +- .../notification_subscriptions.tmpl | 2 +- tests/integration/issue_test.go | 2 +- web_src/css/base.css | 10 +- web_src/css/repository.css | 110 +++++----- web_src/css/repository/issue-list.css | 1 + web_src/css/repository/list-header.css | 4 +- web_src/css/repository/release-tag.css | 27 +-- web_src/css/themes/theme-arc-green.css | 52 ++--- .../js/components/RepoBranchTagSelector.vue | 2 +- web_src/js/features/repo-issue.js | 4 +- web_src/js/features/repo-legacy.js | 6 +- 34 files changed, 265 insertions(+), 330 deletions(-) diff --git a/templates/org/member/members.tmpl b/templates/org/member/members.tmpl index d6ab265ea84..3d5b3beebd0 100644 --- a/templates/org/member/members.tmpl +++ b/templates/org/member/members.tmpl @@ -7,7 +7,7 @@
{{range .Members}}
-
+
{{avatar $.Context . 48}}
diff --git a/templates/projects/list.tmpl b/templates/projects/list.tmpl index 1ef0b0be974..e9e86e5d5d5 100644 --- a/templates/projects/list.tmpl +++ b/templates/projects/list.tmpl @@ -10,7 +10,7 @@ {{end}} {{template "base/alert" .}} -
{{.locale.Tr "packages.container.labels.key"}}
{{$key}}{{$value}}{{$key}}{{$value}}
{{$.locale.Tr "repo.settings.mirror_settings.direction.pull"}} {{DateTime "full" .Mirror.UpdatedUnix}} - + {{.CsrfTokenHtml}} @@ -169,13 +169,13 @@ {{$.locale.Tr "repo.settings.mirror_settings.direction.push"}} {{if .LastUpdateUnix}}{{DateTime "full" .LastUpdateUnix}}{{else}}{{$.locale.Tr "never"}}{{end}} {{if .LastError}}
{{$.locale.Tr "error"}}
{{end}}
- + {{$.CsrfTokenHtml}} -
+ {{$.CsrfTokenHtml}} diff --git a/templates/repo/sub_menu_release_tag.tmpl b/templates/repo/sub_menu_release_tag.tmpl index 27952415567..c700893ee67 100644 --- a/templates/repo/sub_menu_release_tag.tmpl +++ b/templates/repo/sub_menu_release_tag.tmpl @@ -2,7 +2,7 @@ {{$canReadCode := $.Permission.CanRead $.UnitTypeCode}} {{if $canReadReleases}} -