Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-12-05 12:14:38 +01:00
Code Issues Activity

hide functions which will not be referenced outside of the package

Browse Source
This commit is contained in:
Lunny Xiao 2025-08-22 19:21:23 -07:00
parent e2dd7e8e08
commit 193c6c05c1
No known key found for this signature in database
GPG Key ID: C3B7C91B632F738A
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
services/pull/pull.go
View File

@ -231,7 +231,7 @@ func NewPullRequest(ctx context.Context, opts *NewPullRequestOptions) error {
} }
baseGitRepo.Close() // close immediately to avoid notifications will open the repository again baseGitRepo.Close() // close immediately to avoid notifications will open the repository again
ReviewRequestNotify(ctx, issue, issue.Poster, reviewNotifiers) reviewRequestNotify(ctx, issue, issue.Poster, reviewNotifiers)
mentions, err := issues_model.FindAndUpdateIssueMentions(ctx, issue, issue.Poster, issue.Content) mentions, err := issues_model.FindAndUpdateIssueMentions(ctx, issue, issue.Poster, issue.Content)
if err != nil { if err != nil {
@ -498,7 +498,7 @@ func AddTestPullRequestTask(opts TestPullRequestOptions) {
log.Error("RequestCodeOwnersReview: %v", err) log.Error("RequestCodeOwnersReview: %v", err)
} }
if len(reviewNotifiers) > 0 { if len(reviewNotifiers) > 0 {
ReviewRequestNotify(ctx, pr.Issue, opts.Doer, reviewNotifiers) reviewRequestNotify(ctx, pr.Issue, opts.Doer, reviewNotifiers)
} }
} }

14
services/pull/review_request.go
View File

@ -195,12 +195,12 @@ func TeamReviewRequest(ctx context.Context, issue *issues_model.Issue, doer *use
return comment, teamReviewRequestNotify(ctx, issue, doer, reviewer, isAdd, comment) return comment, teamReviewRequestNotify(ctx, issue, doer, reviewer, isAdd, comment)
} }
func ReviewRequestNotify(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, reviewNotifiers []*ReviewRequestNotifier) { func reviewRequestNotify(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, reviewNotifiers []*ReviewRequestNotifier) {
for _, reviewNotifier := range reviewNotifiers { for _, reviewNotifier := range reviewNotifiers {
if reviewNotifier.Reviewer != nil { if reviewNotifier.Reviewer != nil {
notify_service.PullRequestReviewRequest(ctx, issue.Poster, issue, reviewNotifier.Reviewer, reviewNotifier.IsAdd, reviewNotifier.Comment) notify_service.PullRequestReviewRequest(ctx, doer, issue, reviewNotifier.Reviewer, reviewNotifier.IsAdd, reviewNotifier.Comment)
} else if reviewNotifier.ReviewTeam != nil { } else if reviewNotifier.ReviewTeam != nil {
if err := teamReviewRequestNotify(ctx, issue, issue.Poster, reviewNotifier.ReviewTeam, reviewNotifier.IsAdd, reviewNotifier.Comment); err != nil { if err := teamReviewRequestNotify(ctx, issue, doer, reviewNotifier.ReviewTeam, reviewNotifier.IsAdd, reviewNotifier.Comment); err != nil {
log.Error("teamReviewRequestNotify: %v", err) log.Error("teamReviewRequestNotify: %v", err)
} }
} }
@ -298,19 +298,17 @@ type reviewRequestNotifer struct {
} }
func (n *reviewRequestNotifer) IssueChangeTitle(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, oldTitle string) { func (n *reviewRequestNotifer) IssueChangeTitle(ctx context.Context, doer *user_model.User, issue *issues_model.Issue, oldTitle string) {
var reviewNotifiers []*ReviewRequestNotifier
if issue.IsPull && issues_model.HasWorkInProgressPrefix(oldTitle) && !issues_model.HasWorkInProgressPrefix(issue.Title) { if issue.IsPull && issues_model.HasWorkInProgressPrefix(oldTitle) && !issues_model.HasWorkInProgressPrefix(issue.Title) {
if err := issue.LoadPullRequest(ctx); err != nil { if err := issue.LoadPullRequest(ctx); err != nil {
log.Error("IssueChangeTitle: LoadPullRequest: %v", err) log.Error("IssueChangeTitle: LoadPullRequest: %v", err)
return return
} }
var err error reviewNotifiers, err := RequestCodeOwnersReview(ctx, issue.PullRequest)
reviewNotifiers, err = RequestCodeOwnersReview(ctx, issue.PullRequest)
if err != nil { if err != nil {
log.Error("RequestCodeOwnersReview: %v", err) log.Error("RequestCodeOwnersReview: %v", err)
} else {
reviewRequestNotify(ctx, issue, issue.Poster, reviewNotifiers)
} }
} }
ReviewRequestNotify(ctx, issue, issue.Poster, reviewNotifiers)
} }