Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-09-01 15:38:13 +02:00
Code Issues Activity

Tighten search-box types, expand test prefix, drop stale CSS comment

Browse Source 
- chooseFromApi is now generic over the response shape; each caller
  declares a typed *SearchResponse, removing four `any` annotations
- e2e test prefix: rc- → repo-collab- for legibility in the test DB
- web_src/css/modules/search.css: drop the stale leading comment

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
This commit is contained in:
silverwind
2026-04-26 21:16:32 +02:00
co-authored by Claude
parent 4fd1adee5f
commit 26cdb902c9
5 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web_src/js/features/comp/SearchRepoBox.ts
+3 -1
View File
@@ -2,6 +2,8 @@ import {chooseFromApi} from '../../modules/search.ts';
const {appSubUrl} = window.config;
type RepoSearchResponse = {data: Array<{repository: {full_name: string}}>};
export async function initCompSearchRepoBox(el: HTMLElement) {
const uid = el.getAttribute('data-uid');
const exclusive = el.getAttribute('data-exclusive');
@@ -10,7 +12,7 @@ export async function initCompSearchRepoBox(el: HTMLElement) {
const input = el.querySelector<HTMLInputElement>('input.prompt')!;
while (el.isConnected) {
const pick = await chooseFromApi(el, url, (response: any) => response.data.map((item: any) => ({
const pick = await chooseFromApi<RepoSearchResponse>(el, url, (response) => response.data.map((item) => ({
title: item.repository.full_name.split('/')[1],
description: item.repository.full_name,
})));
web_src/js/features/comp/SearchUserBox.ts
+3 -1
View File
@@ -3,6 +3,8 @@ import {chooseFromApi, type SearchResult} from '../../modules/search.ts';
const {appSubUrl} = window.config;
const looksLikeEmailAddressCheck = /^\S+@\S+$/;
type UserSearchResponse = {data: Array<{login: string; avatar_url: string; full_name: string}>};
export async function initCompSearchUserBox() {
const box = document.querySelector<HTMLElement>('#search-user-box');
if (!box) return;
@@ -14,7 +16,7 @@ export async function initCompSearchUserBox() {
const input = box.querySelector<HTMLInputElement>('input.prompt')!;
while (box.isConnected) {
const pick = await chooseFromApi(box, url, (response: any, query: string) => {
const pick = await chooseFromApi<UserSearchResponse>(box, url, (response, query) => {
const items: SearchResult[] = [];
const queryUpper = query.toUpperCase();
for (const item of response.data) {