From 2bac8d86d72f12a9846fbfdabfbedb1ec9e134ac Mon Sep 17 00:00:00 2001
From: NorthRealm <155140859+NorthRealm@users.noreply.github.com>
Date: Tue, 8 Jul 2025 14:59:30 +0800
Subject: [PATCH] terrible

---
 services/mailer/mail_workflow_run.go | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/services/mailer/mail_workflow_run.go b/services/mailer/mail_workflow_run.go
index 561e9f2e36..f6eade8110 100644
--- a/services/mailer/mail_workflow_run.go
+++ b/services/mailer/mail_workflow_run.go
@@ -53,16 +53,13 @@ func sendActionsWorkflowRunStatusEmail(ctx context.Context, repo *repo_model.Rep
 	if err != nil {
 		log.Error("GetRunJobsByRunID: %v", err)
 		return
-	} else {
-		sort.SliceStable(jobs, func(i, j int) bool {
-			si := jobs[i].Status
-			sj := jobs[j].Status
-			if si == sj || si.IsSuccess() {
-				return false
-			}
-			return si < sj
-		})
 	}
+	sort.SliceStable(jobs, func(i, j int) bool {
+		si := jobs[i].Status
+		sj := jobs[j].Status
+		return !(si == sj || si.IsSuccess()) && si < sj
+	})
+
 	convertedJobs := make([]convertedWorkflowJob, 0, len(jobs))
 	for _, job := range jobs {
 		converted0, err := convert.ToActionWorkflowJob(ctx, repo, nil, job)