From 2fe74d3cdd5184a7e22e32e47772caa78d077489 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Fri, 16 Oct 2026 20:02:11 +0800 Subject: [PATCH] refactor: clean up legacy templates and js (#39808) * Remove unused `"root"` data attributes from templates * Use our "confirmModal" as much as possible (partially for #39643) * Use "data-global-init" to refactor a lot of legacy code * Refactor and clearify initRepoIssueCommentDelete's behavior to help #36862 * Remove dead code `common-organization.ts` --- templates/admin/stacktrace-row.tmpl | 6 +- templates/admin/stacktrace.tmpl | 4 +- templates/package/content/composer.tmpl | 4 +- templates/package/content/npm.tmpl | 8 +-- templates/package/content/rubygems.tmpl | 4 +- .../repo/issue/labels/label_edit_modal.tmpl | 2 +- .../repo/issue/view_content/comments.tmpl | 2 +- .../repo/issue/view_content/context_menu.tmpl | 2 +- tests/e2e/pr-review.test.ts | 7 +- web_src/css/repo.css | 4 -- web_src/js/components/RepoActionView.vue | 6 +- web_src/js/features/common-organization.ts | 16 ----- web_src/js/features/comp/LabelEdit.ts | 32 ++++----- web_src/js/features/repo-issue-content.ts | 1 + web_src/js/features/repo-issue.ts | 72 ++++++++++--------- web_src/js/features/repo-legacy.ts | 16 ++--- web_src/js/index.ts | 4 +- 17 files changed, 89 insertions(+), 101 deletions(-) delete mode 100644 web_src/js/features/common-organization.ts diff --git a/templates/admin/stacktrace-row.tmpl b/templates/admin/stacktrace-row.tmpl index 94c4212d887..689f44c54b0 100644 --- a/templates/admin/stacktrace-row.tmpl +++ b/templates/admin/stacktrace-row.tmpl @@ -17,7 +17,7 @@
{{if or (eq .Process.Type "request") (eq .Process.Type "normal")}} - {{svg "octicon-trash" 16 "tw-text-red"}} @@ -60,8 +60,8 @@ {{if .Process.Children}}
- {{range .Process.Children}} - {{template "admin/stacktrace-row" dict "Process" . "root" $.root}} + {{range $child := .Process.Children}} + {{template "admin/stacktrace-row" dict "Process" $child}} {{end}}
{{end}} diff --git a/templates/admin/stacktrace.tmpl b/templates/admin/stacktrace.tmpl index a74a3d3e417..24a74fdaf4f 100644 --- a/templates/admin/stacktrace.tmpl +++ b/templates/admin/stacktrace.tmpl @@ -11,8 +11,8 @@ {{if .ProcessStacks}}
- {{range .ProcessStacks}} - {{template "admin/stacktrace-row" dict "Process" . "root" $}} + {{range $process := .ProcessStacks}} + {{template "admin/stacktrace-row" dict "Process" $process}} {{end}}
diff --git a/templates/package/content/composer.tmpl b/templates/package/content/composer.tmpl index 5bbc19e9f25..8d5d0d75804 100644 --- a/templates/package/content/composer.tmpl +++ b/templates/package/content/composer.tmpl @@ -33,8 +33,8 @@

{{ctx.Locale.Tr "packages.dependencies"}}

- {{template "package/content/composer_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.Require "title" (ctx.Locale.Tr "packages.composer.dependencies")}} - {{template "package/content/composer_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.RequireDev "title" (ctx.Locale.Tr "packages.composer.dependencies.development")}} + {{template "package/content/composer_dependencies" dict "dependencies" .PackageDescriptor.Metadata.Require "title" (ctx.Locale.Tr "packages.composer.dependencies")}} + {{template "package/content/composer_dependencies" dict "dependencies" .PackageDescriptor.Metadata.RequireDev "title" (ctx.Locale.Tr "packages.composer.dependencies.development")}}
{{end}} diff --git a/templates/package/content/npm.tmpl b/templates/package/content/npm.tmpl index 89f4c940081..61d156d81d5 100644 --- a/templates/package/content/npm.tmpl +++ b/templates/package/content/npm.tmpl @@ -30,10 +30,10 @@

{{ctx.Locale.Tr "packages.dependencies"}}

- {{template "package/content/npm_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.Dependencies "title" (ctx.Locale.Tr "packages.npm.dependencies")}} - {{template "package/content/npm_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.DevelopmentDependencies "title" (ctx.Locale.Tr "packages.npm.dependencies.development")}} - {{template "package/content/npm_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.PeerDependencies "title" (ctx.Locale.Tr "packages.npm.dependencies.peer")}} - {{template "package/content/npm_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.OptionalDependencies "title" (ctx.Locale.Tr "packages.npm.dependencies.optional")}} + {{template "package/content/npm_dependencies" dict "dependencies" .PackageDescriptor.Metadata.Dependencies "title" (ctx.Locale.Tr "packages.npm.dependencies")}} + {{template "package/content/npm_dependencies" dict "dependencies" .PackageDescriptor.Metadata.DevelopmentDependencies "title" (ctx.Locale.Tr "packages.npm.dependencies.development")}} + {{template "package/content/npm_dependencies" dict "dependencies" .PackageDescriptor.Metadata.PeerDependencies "title" (ctx.Locale.Tr "packages.npm.dependencies.peer")}} + {{template "package/content/npm_dependencies" dict "dependencies" .PackageDescriptor.Metadata.OptionalDependencies "title" (ctx.Locale.Tr "packages.npm.dependencies.optional")}}
{{end}} diff --git a/templates/package/content/rubygems.tmpl b/templates/package/content/rubygems.tmpl index 140ecfb7d9b..d525425aeaf 100644 --- a/templates/package/content/rubygems.tmpl +++ b/templates/package/content/rubygems.tmpl @@ -32,8 +32,8 @@ end

{{ctx.Locale.Tr "packages.dependencies"}}

- {{template "package/content/rubygems_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.RuntimeDependencies "title" (ctx.Locale.Tr "packages.rubygems.dependencies.runtime")}} - {{template "package/content/rubygems_dependencies" dict "root" $ "dependencies" .PackageDescriptor.Metadata.DevelopmentDependencies "title" (ctx.Locale.Tr "packages.rubygems.dependencies.development")}} + {{template "package/content/rubygems_dependencies" dict "dependencies" .PackageDescriptor.Metadata.RuntimeDependencies "title" (ctx.Locale.Tr "packages.rubygems.dependencies.runtime")}} + {{template "package/content/rubygems_dependencies" dict "dependencies" .PackageDescriptor.Metadata.DevelopmentDependencies "title" (ctx.Locale.Tr "packages.rubygems.dependencies.development")}}
{{end}} diff --git a/templates/repo/issue/labels/label_edit_modal.tmpl b/templates/repo/issue/labels/label_edit_modal.tmpl index 0eb238fb655..23851b0d45d 100644 --- a/templates/repo/issue/labels/label_edit_modal.tmpl +++ b/templates/repo/issue/labels/label_edit_modal.tmpl @@ -1,4 +1,4 @@ -