Mirrors/gitea
0
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-09 22:18:39 +02:00
Code Issues Activity

[Backport] Fix Deadlock & Delete affected reactions on comment deletion (#14392) (#14425)

Browse Source 
* Enhance Ghost comment mitigation Settings (#14392)

* refactor models.DeleteComment and delete related reactions too

* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser

* Resolve Fixme & fix potential deadlock

* rm refactor

* make diff eaven less
This commit is contained in:
6543 authored and GitHub committed 2021-01-23 10:03:29 +08:00
1 parent fb274ec54b
commit 4d2a6c40f8
5 files changed
+23 -14
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

models/issue_reaction.go
+8 -4
View File
@@ -178,11 +178,15 @@ func CreateCommentReaction(doer *User, issue *Issue, comment *Comment, content s
})
}
func deleteReaction(e *xorm.Session, opts *ReactionOptions) error {
func deleteReaction(e Engine, opts *ReactionOptions) error {
reaction := &Reaction{
Type: opts.Type,
UserID: opts.Doer.ID,
IssueID: opts.Issue.ID,
Type: opts.Type,
}
if opts.Doer != nil {
reaction.UserID = opts.Doer.ID
}
if opts.Issue != nil {
reaction.IssueID = opts.Issue.ID
}
if opts.Comment != nil {
reaction.CommentID = opts.Comment.ID