Mirrors/gitea
0
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-03 08:45:33 +02:00
Code Issues Activity

Fix get / delete runner to use consistent http 404 and 500 status (#34480)

Browse Source 
* previously deleting an already deleted runner returned http 500
* previously any database error for the get endpoint was http 404 and never 500
This commit is contained in:
ChristopherHX authored and GitHub committed 2025-05-16 06:44:29 +00:00
1 parent 7b518bc6c7
commit 59df03b554
2 files changed
+35 -18
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/integration/api_actions_runner_test.go
+8
View File
@@ -329,4 +329,12 @@ func testActionsRunnerRepo(t *testing.T) {
req := NewRequest(t, "DELETE", fmt.Sprintf("/api/v1/repos/user2/repo1/actions/runners/%d", 34349)).AddTokenAuth(token)
MakeRequest(t, req, http.StatusNotFound)
})
t.Run("DeleteAdminRunnerNotFoundUnknownID", func(t *testing.T) {
userUsername := "user2"
token := getUserToken(t, userUsername, auth_model.AccessTokenScopeWriteRepository)
// Verify delete a runner by unknown id is not found
req := NewRequest(t, "DELETE", fmt.Sprintf("/api/v1/repos/user2/repo1/actions/runners/%d", 4384797347934)).AddTokenAuth(token)
MakeRequest(t, req, http.StatusNotFound)
})
}