Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-10 20:31:25 +02:00
Code Issues Activity

update context assignment functions for repositories and repo groups

Browse Source 
assign group and show 404 if necessary when `group_id` parameter is present
This commit is contained in:
☙◦ The Tablet ❀ GamerGirlandCo ◦❧ 2025-11-30 15:38:12 -05:00
parent cb563434ee
commit 635b5f5b33
No known key found for this signature in database
GPG Key ID: 924A5F6AF051E87C
3 changed files with 31 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
services/context/group.go
View File

@ -90,15 +90,31 @@ type GroupAssignmentOptions struct {
RequireGroupAdmin bool
}
func groupAssignment(ctx *Context) {
if ctx.RepoGroup.Group == nil {
GetGroupByParams(ctx)
}
if ctx.Written() {
return
}
canAccess, err := ctx.RepoGroup.Group.CanAccess(ctx, ctx.Doer)
if err != nil {
ctx.ServerError("error checking group access", err)
return
}
if !canAccess {
ctx.NotFound(nil)
return
}
}
func GroupAssignment(args GroupAssignmentOptions) func(ctx *Context) {
return func(ctx *Context) {
var err error
if ctx.RepoGroup.Group == nil {
GetGroupByParams(ctx)
if ctx.Written() {
return
}
groupAssignment(ctx)
if ctx.Written() {
return
}
group := ctx.RepoGroup.Group
@ -106,15 +122,6 @@ func GroupAssignment(args GroupAssignmentOptions) func(ctx *Context) {
ctx.NotFound(err)
return
}
canAccess, err := ctx.RepoGroup.Group.CanAccess(ctx, ctx.Doer)
if err != nil {
ctx.ServerError("error checking group access", err)
return
}
if !canAccess {
ctx.NotFound(nil)
return
}
if ctx.RepoGroup.Group.Visibility == structs.VisibleTypePrivate {
args.RequireMember = true

6
services/context/permission.go
View File

@ -35,7 +35,9 @@ func CanWriteToBranch() func(ctx *Context) {
// RequireUnitWriter returns a middleware for requiring repository write to one of the unit permission
func RequireUnitWriter(unitTypes ...unit.Type) func(ctx *Context) {
return func(ctx *Context) {
if slices.ContainsFunc(unitTypes, ctx.Repo.CanWrite) {
if slices.ContainsFunc(unitTypes, ctx.Repo.CanWrite) || (ctx.RepoGroup != nil && slices.ContainsFunc(unitTypes, func(u unit.Type) bool {
return ctx.RepoGroup.CanWriteUnit(ctx, u)
})) {
return
}
ctx.NotFound(nil)
@ -46,7 +48,7 @@ func RequireUnitWriter(unitTypes ...unit.Type) func(ctx *Context) {
func RequireUnitReader(unitTypes ...unit.Type) func(ctx *Context) {
return func(ctx *Context) {
for _, unitType := range unitTypes {
if ctx.Repo.CanRead(unitType) {
if ctx.Repo.CanRead(unitType) || ctx.RepoGroup.CanReadUnit(ctx, unitType) {
return
}
if unitType == unit.TypeCode && canWriteAsMaintainer(ctx) {

6
services/context/repo.go
View File

@ -571,6 +571,12 @@ func RepoAssignment(ctx *Context) {
if repo.GroupID != gid {
ctx.NotFound(nil)
}
if gid > 0 {
groupAssignment(ctx)
}
if ctx.Written() {
return
}
repo.Owner = ctx.Repo.Owner
repoAssignment(ctx, repo)