Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-02-23 00:03:37 +01:00
Code Issues Activity

Address review comments

Browse Source 
Trim trailing slash from server URL, add retry loop for server
reachability, note in CONTRIBUTING.md that a running server is required.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
silverwind 2026-02-15 11:25:17 +01:00
parent 625e46d033
commit 68acbd3ad4
No known key found for this signature in database
GPG Key ID: 2E62B41C93869443
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@ -178,7 +178,7 @@ Here's how to run the test suite:
| :------------------------------------------ | :------------------------------------------------------- | ------------------------------------------- |
|``make test[\#SpecificTestName]`` | run unit test(s) | |
|``make test-sqlite[\#SpecificTestName]`` | run [integration](tests/integration) test(s) for SQLite | [More details](tests/integration/README.md) |
|``make test-e2e`` | run [end-to-end](tests/e2e) test(s) using Playwright | |
|``make test-e2e`` | run [end-to-end](tests/e2e) test(s) using Playwright | Requires a running Gitea server |
## Translation

21
tools/test-e2e.sh
View File

@ -20,14 +20,23 @@ else
GITEA_TEST_SERVER_URL="$ROOT_URL"
fi
# Normalize URL: trim trailing slash to avoid double slashes when appending paths
GITEA_TEST_SERVER_URL="${GITEA_TEST_SERVER_URL%/}"
echo "Using Gitea server: $GITEA_TEST_SERVER_URL"
# Verify server is reachable
if ! curl -sf --max-time 5 "$GITEA_TEST_SERVER_URL" > /dev/null 2>&1; then
echo "error: Gitea server at $GITEA_TEST_SERVER_URL is not reachable" >&2
echo "Start Gitea first: ${EXECUTABLE:-./gitea}" >&2
exit 1
fi
# Verify server is reachable, retry for up to 2 minutes for slow startup
MAX_WAIT=120
ELAPSED=0
while ! curl -sf --max-time 5 "$GITEA_TEST_SERVER_URL" > /dev/null 2>&1; do
if [ "$ELAPSED" -ge "$MAX_WAIT" ]; then
echo "error: Gitea server at $GITEA_TEST_SERVER_URL is not reachable after ${MAX_WAIT}s" >&2
echo "Start Gitea first: ${EXECUTABLE:-./gitea}" >&2
exit 1
fi
sleep 2
ELAPSED=$((ELAPSED + 2))
done
# Create e2e test user if it does not already exist
E2E_USER="e2e"