From 734be7e3b58782cddfdb7c8eb581e680604fd429 Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 15 Feb 2026 12:08:42 +0100 Subject: [PATCH] Fix e2e CI: use ./gitea path for executable, show user creation errors The EXECUTABLE was passed as 'gitea' without ./ prefix, which fails in CI where the current directory is not in PATH. Also remove 2>/dev/null from user creation to surface errors. Co-Authored-By: Claude Opus 4.6 --- Makefile | 2 +- tools/test-e2e.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a01e00f090..b20287474a 100644 --- a/Makefile +++ b/Makefile @@ -556,7 +556,7 @@ test-mssql-migration: migrations.mssql.test migrations.individual.mssql.test .PHONY: test-e2e test-e2e: deps-frontend @$(NODE_VARS) pnpm exec playwright install --with-deps chromium $(PLAYWRIGHT_FLAGS) - EXECUTABLE=$(EXECUTABLE) ./tools/test-e2e.sh $(E2E_FLAGS) + EXECUTABLE=./$(EXECUTABLE) ./tools/test-e2e.sh $(E2E_FLAGS) .PHONY: bench-sqlite bench-sqlite: integrations.sqlite.test generate-ini-sqlite diff --git a/tools/test-e2e.sh b/tools/test-e2e.sh index edd42efc8e..0738a89b8b 100755 --- a/tools/test-e2e.sh +++ b/tools/test-e2e.sh @@ -42,7 +42,7 @@ E2E_EMAIL="e2e@test.gitea.io" E2E_PASSWORD="password" if ! curl -sf --max-time 5 "$E2E_URL/api/v1/users/$E2E_USER" > /dev/null 2>&1; then echo "Creating e2e test user..." - if ${EXECUTABLE:-./gitea} admin user create --username "$E2E_USER" --email "$E2E_EMAIL" --password "$E2E_PASSWORD" --must-change-password=false 2>/dev/null; then + if ${EXECUTABLE:-./gitea} admin user create --username "$E2E_USER" --email "$E2E_EMAIL" --password "$E2E_PASSWORD" --must-change-password=false; then echo "User '$E2E_USER' created" else echo "error: failed to create user '$E2E_USER'" >&2