mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-04 04:14:01 +01:00 
			
		
		
		
	Change "rejected" to "changes requested" in 3rd party PR review notification (#34481)
This PR changes 3rd party notifications wording on a PR review that requests changes and can be considered a follow up for #5858 to also fix #5857 in 3rd party notifications. The difference in the actual notification would be the following: ```diff - Pull request review rejected + Pull request review changes requested ``` While this is a simple string change at first look, it has a deeper UX meaning. # Motivation We could observe that some developers are hesitant to press the "Request changes" button since their peers first see that their changes were rejected, thus a more appropriate wording that also falls in line with the meaning and UI would be beneficial. ## Meaning Pressing the `Request changes` button in a PR review means that as a reviewer you are willing to merge the general change in a PR if changes requested review comments are implemented. Rejecting a PR on the other hand would be equivalent with closing it since that change isn't welcome at all (e.g. out of scope feature). ## Sync with UI The UI button says `request changes` and the other options  ## Considered Problems This might break some automation for users who rely on string matching.
This commit is contained in:
		
							parent
							
								
									c24f4b3d29
								
							
						
					
					
						commit
						7b518bc6c7
					
				@ -305,7 +305,7 @@ func parseHookPullRequestEventType(event webhook_module.HookEventType) (string,
 | 
			
		||||
	case webhook_module.HookEventPullRequestReviewApproved:
 | 
			
		||||
		return "approved", nil
 | 
			
		||||
	case webhook_module.HookEventPullRequestReviewRejected:
 | 
			
		||||
		return "rejected", nil
 | 
			
		||||
		return "requested changes", nil
 | 
			
		||||
	case webhook_module.HookEventPullRequestReviewComment:
 | 
			
		||||
		return "comment", nil
 | 
			
		||||
	default:
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user