From 82b3f5ffd54935698f7904e4dcfcb8d545362221 Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 18 Feb 2026 05:26:40 +0100 Subject: [PATCH] Avoid nil issue when GetIssueByID fails Use a temporary variable so issue is only overwritten on success, preventing a nil dereference in notify_service.CreateIssueComment. Co-Authored-By: Claude Opus 4.6 --- services/issue/comments.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/issue/comments.go b/services/issue/comments.go index 2b3bc38b65..9c956fcc09 100644 --- a/services/issue/comments.go +++ b/services/issue/comments.go @@ -82,8 +82,10 @@ func CreateIssueComment(ctx context.Context, doer *user_model.User, repo *repo_m } // reload issue to ensure it has the latest data, especially the number of comments - if issue, err = issues_model.GetIssueByID(ctx, issue.ID); err != nil { + if reloadedIssue, err := issues_model.GetIssueByID(ctx, issue.ID); err != nil { log.Error("GetIssueByID: %v", err) + } else { + issue = reloadedIssue } notify_service.CreateIssueComment(ctx, doer, repo, issue, comment, mentions)