mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-17 04:28:05 +02:00
refactor: decouple git.Repository(ctx) from git.Commit & git.Tree (#38464)
1. Storing "ctx" in a long-living object is wrong 2. Make the commit & tree cacheable (for the future performance optimization) 3. Also fix some bad designs like `// FIXME: bad design, this field can be nil if the commit is from "last commit cache"` ref: * #33893
This commit is contained in:
@@ -20,7 +20,7 @@ func TestSubTree_Issue29101(t *testing.T) {
|
||||
|
||||
// old code could produce a different error if called multiple times
|
||||
for range 10 {
|
||||
_, err = commit.SubTree("file1.txt")
|
||||
_, err = commit.SubTree(t.Context(), repo, "file1.txt")
|
||||
assert.Error(t, err)
|
||||
assert.True(t, IsErrNotExist(err))
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user