Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-07-21 03:48:30 +02:00
Code Issues Activity

Fix lint

Browse Source
This commit is contained in:
Philip Peterson 2025-05-27 03:26:19 -07:00
parent 2c7ceedb08
commit 84d18d3e1d
5 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
services/repository/create.go
View File

@ -259,7 +259,7 @@ func CreateRepositoryDirectly(ctx context.Context, doer, owner *user_model.User,
defer func() { defer func() {
if err != nil { if err != nil {
// we can not use the ctx because it maybe canceled or timeout // we can not use the ctx because it maybe canceled or timeout
cleanupRepository(doer, repo.ID) cleanupRepository(repo.ID)
} }
}() }()
@ -454,7 +454,7 @@ func createRepositoryInDB(ctx context.Context, doer, u *user_model.User, repo *r
return nil return nil
} }
func cleanupRepository(doer *user_model.User, repoID int64) { func cleanupRepository(repoID int64) {
if errDelete := DeleteRepositoryDirectly(db.DefaultContext, repoID); errDelete != nil { if errDelete := DeleteRepositoryDirectly(db.DefaultContext, repoID); errDelete != nil {
log.Error("cleanupRepository failed: %v", errDelete) log.Error("cleanupRepository failed: %v", errDelete)
// add system notice // add system notice

2
services/repository/fork.go
View File

@ -124,7 +124,7 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork
defer func() { defer func() {
if err != nil { if err != nil {
// we can not use the ctx because it maybe canceled or timeout // we can not use the ctx because it maybe canceled or timeout
cleanupRepository(doer, repo.ID) cleanupRepository(repo.ID)
} }
}() }()

2
services/repository/template.go
View File

@ -102,7 +102,7 @@ func GenerateRepository(ctx context.Context, doer, owner *user_model.User, templ
defer func() { defer func() {
if err != nil { if err != nil {
// we can not use the ctx because it maybe canceled or timeout // we can not use the ctx because it maybe canceled or timeout
cleanupRepository(doer, generateRepo.ID) cleanupRepository(generateRepo.ID)
} }
}() }()

2
tests/integration/ephemeral_actions_runner_deletion_test.go
View File

@ -50,8 +50,6 @@ func testEphemeralActionsRunnerDeletionByRepository(t *testing.T) {
task := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionTask{ID: 52}) task := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionTask{ID: 52})
assert.Equal(t, actions_model.StatusRunning, task.Status) assert.Equal(t, actions_model.StatusRunning, task.Status)
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
err = repo_service.DeleteRepositoryDirectly(t.Context(), task.RepoID, true) err = repo_service.DeleteRepositoryDirectly(t.Context(), task.RepoID, true)
assert.NoError(t, err) assert.NoError(t, err)

2
tests/integration/pull_compare_test.go
View File

@ -13,7 +13,6 @@ import (
issues_model "code.gitea.io/gitea/models/issues" issues_model "code.gitea.io/gitea/models/issues"
repo_model "code.gitea.io/gitea/models/repo" repo_model "code.gitea.io/gitea/models/repo"
"code.gitea.io/gitea/models/unittest" "code.gitea.io/gitea/models/unittest"
user_model "code.gitea.io/gitea/models/user"
"code.gitea.io/gitea/modules/test" "code.gitea.io/gitea/modules/test"
repo_service "code.gitea.io/gitea/services/repository" repo_service "code.gitea.io/gitea/services/repository"
"code.gitea.io/gitea/tests" "code.gitea.io/gitea/tests"
@ -76,7 +75,6 @@ func TestPullCompare(t *testing.T) {
assert.Positive(t, editButtonCount, "Expected to find a button to edit a file in the PR diff view but there were none") assert.Positive(t, editButtonCount, "Expected to find a button to edit a file in the PR diff view but there were none")
repoForked := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerName: "user1", Name: "repo1"}) repoForked := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerName: "user1", Name: "repo1"})
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
// delete the head repository and revisit the PR diff view // delete the head repository and revisit the PR diff view
err := repo_service.DeleteRepositoryDirectly(db.DefaultContext, repoForked.ID) err := repo_service.DeleteRepositoryDirectly(db.DefaultContext, repoForked.ID)