Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-31 09:45:33 +02:00
Code Issues Activity

fix(actions): prevent bulk actions from affecting all runners (#38453)

Browse Source 
Fix the bug in the site-admin runner bulk actions introduced by #37869:
the runner IDs are empty then all runners will be deleted.

Fixes #38449

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
xkm
2026-07-15 02:36:03 +00:00
committed by GitHub
co-authored by wxiaoguang
parent 7c629e1ba7
commit 880ddb5724
4 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/actions_runner_modify_test.go
+7
View File
@@ -196,6 +196,13 @@ func TestActionsRunnerModify(t *testing.T) {
doBulk(t, sessionAdmin, "evict", allIDs, http.StatusBadRequest)
})
t.Run("EmptyIDs", func(t *testing.T) {
doBulk(t, sessionAdmin, "delete", nil, http.StatusBadRequest)
for _, id := range allIDs {
unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRunner{ID: id})
}
})
t.Run("DisableEnable", func(t *testing.T) {
doBulk(t, sessionAdmin, "disable", allIDs, http.StatusOK)
for _, id := range allIDs {