test: consolidate Go tests (#39962)

Consolidate all Go tests. Coverage is identical to before. Go tests are
around 5% faster while being 7% smaller. No non-test code is touched.

modules/git/commit2_test.go

@@ -11,60 +11,29 @@ import (
 
 func TestCommitsCount(t *testing.T) {
 	bareRepo1 := mockRepository("repo1_bare")
-
-	commitsCount, err := CommitsCount(t.Context(), bareRepo1,
-		CommitsCountOptions{
-			Revision: []string{"8006ff9adbf0cb94da7dad9e537e53817f9fa5c0"},
-		})
-
-	assert.NoError(t, err)
-	assert.Equal(t, int64(3), commitsCount)
-}
-
-func TestCommitsCountWithSinceUntil(t *testing.T) {
-	bareRepo1 := mockRepository("repo1_bare")
 	revision := []string{"8006ff9adbf0cb94da7dad9e537e53817f9fa5c0"}
 
 	// The three commits on this revision are dated 2018-04-18, 2017-12-19 and 2017-12-19.
-	cases := []struct {
+	for _, tc := range []struct {
 		name     string
-		since    string
-		until    string
+		options  CommitsCountOptions
 		expected int64
 	}{
-		{name: "no filter", expected: 3},
-		{name: "since keeps newer commits", since: "2018-01-01", expected: 1},
-		{name: "until keeps older commits", until: "2018-01-01", expected: 2},
-		{name: "since and until bound the range", since: "2017-12-19T22:16:00-08:00", until: "2018-01-01", expected: 1},
-	}
-	for _, tc := range cases {
+		{"revision", CommitsCountOptions{Revision: revision}, 3},
+		{"no filter", CommitsCountOptions{Revision: revision}, 3},
+		{"since keeps newer commits", CommitsCountOptions{Revision: revision, Since: "2018-01-01"}, 1},
+		{"until keeps older commits", CommitsCountOptions{Revision: revision, Until: "2018-01-01"}, 2},
+		{"since and until bound the range", CommitsCountOptions{Revision: revision, Since: "2017-12-19T22:16:00-08:00", Until: "2018-01-01"}, 1},
+		{"without base", CommitsCountOptions{Not: "master", Revision: []string{"branch1"}}, 2},
+	} {
 		t.Run(tc.name, func(t *testing.T) {
-			commitsCount, err := CommitsCount(t.Context(), bareRepo1,
-				CommitsCountOptions{
-					Revision: revision,
-					Since:    tc.since,
-					Until:    tc.until,
-				})
-
+			commitsCount, err := CommitsCount(t.Context(), bareRepo1, tc.options)
 			assert.NoError(t, err)
 			assert.Equal(t, tc.expected, commitsCount)
 		})
 	}
 }
 
-func TestCommitsCountWithoutBase(t *testing.T) {
-	bareRepo1 := mockRepository("repo1_bare")
-
-	commitsCount, err := CommitsCount(t.Context(), bareRepo1,
-		CommitsCountOptions{
-			Not:      "master",
-			Revision: []string{"branch1"},
-		})
-
-	assert.NoError(t, err)
-	assert.Equal(t, int64(2), commitsCount)
-}
-
 func TestGetLatestCommitTime(t *testing.T) {
 	bareRepo1 := mockRepository("repo1_bare")
 	lct, err := GetLatestCommitTime(t.Context(), bareRepo1)