Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-11-04 23:35:34 +01:00
Code Issues Activity

Safely handle map deletions in refreshAccesses to avoid iteration issues

Browse Source
This commit is contained in:
Ross Golder 2025-10-24 06:01:57 +07:00
parent 5901bd75ca
commit 91bd7c536f
No known key found for this signature in database
GPG Key ID: 253A7E508D2D59CD
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
models/perm/access/access.go
View File

@ -105,8 +105,10 @@ func refreshAccesses(ctx context.Context, repo *repo_model.Repository, accessMap
} }
newAccesses := make([]Access, 0, len(accessMap)) newAccesses := make([]Access, 0, len(accessMap))
keysToDelete := []int64{}
for userID, ua := range accessMap { for userID, ua := range accessMap {
if ua.Mode < minMode && !ua.User.IsRestricted { if ua.Mode < minMode && !ua.User.IsRestricted {
keysToDelete = append(keysToDelete, userID)
continue continue
} }
@ -116,6 +118,9 @@ func refreshAccesses(ctx context.Context, repo *repo_model.Repository, accessMap
Mode: ua.Mode, Mode: ua.Mode,
}) })
} }
for _, uid := range keysToDelete {
delete(accessMap, uid)
}
// Delete old accesses and insert new ones for repository. // Delete old accesses and insert new ones for repository.
if _, err = db.DeleteByBean(ctx, &Access{RepoID: repo.ID}); err != nil { if _, err = db.DeleteByBean(ctx, &Access{RepoID: repo.ID}); err != nil {