Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-14 08:48:02 +02:00
Code Issues Activity

Tweak attachSearchBox: rename all→resultEls, clarify stale-response comment

Browse Source 
Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
This commit is contained in:
silverwind 2026-05-04 22:27:01 +02:00
parent cd59e7ec17
commit 92158b1ee5
No known key found for this signature in database
GPG Key ID: 2E62B41C93869443
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
web_src/js/modules/search.ts
View File

@ -70,7 +70,7 @@ export function attachSearchBox<T = unknown>(container: HTMLElement, url: string
const response = await GET(url.replaceAll('{query}', urlQueryEscape(query)), {signal: ctrl.signal}); const response = await GET(url.replaceAll('{query}', urlQueryEscape(query)), {signal: ctrl.signal});
if (!response.ok) return hide(); if (!response.ok) return hide();
const results = parse(await response.json(), query); const results = parse(await response.json(), query);
// hide() ran (signal aborted) or a newer keystroke landed before the response did // only render if the fetch wasn't aborted (e.g. by hide()) and the input still matches
if (!ctrl.signal.aborted && input.value === query) render(results); if (!ctrl.signal.aborted && input.value === query) render(results);
} catch (err) { } catch (err) {
if ((err as Error).name !== 'AbortError') hide(); if ((err as Error).name !== 'AbortError') hide();
@ -81,17 +81,17 @@ export function attachSearchBox<T = unknown>(container: HTMLElement, url: string
input.addEventListener('focus', () => { if (itemResults.size) resultsEl.style.display = 'block'; }); input.addEventListener('focus', () => { if (itemResults.size) resultsEl.style.display = 'block'; });
input.addEventListener('blur', () => setTimeout(hide, 150)); // deferred so a result mousedown can land first input.addEventListener('blur', () => setTimeout(hide, 150)); // deferred so a result mousedown can land first
input.addEventListener('keydown', (event) => { input.addEventListener('keydown', (event) => {
const all = Array.from(resultsEl.querySelectorAll<HTMLElement>('.result')); const resultEls = Array.from(resultsEl.querySelectorAll<HTMLElement>('.result'));
if (!all.length) return; if (!resultEls.length) return;
const index = all.findIndex((item) => item.classList.contains('active')); const index = resultEls.findIndex((item) => item.classList.contains('active'));
if (event.key === 'ArrowDown' || event.key === 'ArrowUp') { if (event.key === 'ArrowDown' || event.key === 'ArrowUp') {
event.preventDefault(); event.preventDefault();
all[index]?.classList.remove('active'); resultEls[index]?.classList.remove('active');
const next = event.key === 'ArrowDown' ? (index + 1) % all.length : index <= 0 ? all.length - 1 : index - 1; const next = event.key === 'ArrowDown' ? (index + 1) % resultEls.length : index <= 0 ? resultEls.length - 1 : index - 1;
all[next].classList.add('active'); resultEls[next].classList.add('active');
} else if (event.key === 'Enter' && index >= 0) { } else if (event.key === 'Enter' && index >= 0) {
event.preventDefault(); event.preventDefault();
select(all[index]); select(resultEls[index]);
} else if (event.key === 'Escape') { } else if (event.key === 'Escape') {
hide(); hide();
} }