Mirrors/gitea
0
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-07 16:27:00 +02:00
Code Issues Activity

Fix nil dereference on error (#30740)

Browse Source 
In both cases, the `err` is nil because of `if` checks before

Reference: #30729
This commit is contained in:
Chongyi Zheng authored and GitHub committed 2024-04-28 12:13:57 +08:00
1 parent 8b8b48ef5f
commit 970965f6d8
2 files changed
+5 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

routers/api/actions/artifacts.go
+4 -3
View File
@@ -466,14 +466,15 @@ func (ar artifactRoutes) downloadArtifact(ctx *ArtifactContext) {
log.Error("Error getting artifact: %v", err)
ctx.Error(http.StatusInternalServerError, err.Error())
return
} else if !exist {
}
if !exist {
log.Error("artifact with ID %d does not exist", artifactID)
ctx.Error(http.StatusNotFound, fmt.Sprintf("artifact with ID %d does not exist", artifactID))
return
}
if artifact.RunID != runID {
log.Error("Error dismatch runID and artifactID, task: %v, artifact: %v", runID, artifactID)
ctx.Error(http.StatusBadRequest, err.Error())
log.Error("Error mismatch runID and artifactID, task: %v, artifact: %v", runID, artifactID)
ctx.Error(http.StatusBadRequest)
return
}