Fix the bug when the last code comment deleted, a review comment type comment is still in the activity list of the pull request

This commit is contained in:
Lunny Xiao committed 2025-07-20 12:32:07 -07:00
1 parent 86aafea3fb
commit 98f0ab2a1f
8 files changed
+116 -15

No files matched your search

+1 -1
View File
@@ -726,7 +726,7 @@ func deleteIssueComment(ctx *context.APIContext) {
return
}
if err = issue_service.DeleteComment(ctx, ctx.Doer, comment); err != nil {
if _, err = issue_service.DeleteComment(ctx, ctx.Doer, comment); err != nil {
ctx.APIErrorInternal(err)
return
}
+8 -2
View File
@@ -325,12 +325,18 @@ func DeleteComment(ctx *context.Context) {
return
}
if err = issue_service.DeleteComment(ctx, ctx.Doer, comment); err != nil {
deletedReviewComment, err := issue_service.DeleteComment(ctx, ctx.Doer, comment)
if err != nil {
ctx.ServerError("DeleteComment", err)
return
}
ctx.Status(http.StatusOK)
res := map[string]any{}
if deletedReviewComment != nil {
res["deletedReviewCommentHashTag"] = deletedReviewComment.HashTag()
}
ctx.JSON(http.StatusOK, res)
}
// ChangeCommentReaction create a reaction for comment