From 9d89dfe1425ac202e8b1d74ac28c5ed31b766fbd Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Mon, 17 Mar 2025 22:11:24 +0800 Subject: [PATCH] Remove unused or abused styles (#33918) * `top aligned` => `tw-align-top` * label list: it was broken, this PR fixes it * reference link: simplified * settings/repos: not affected --- templates/package/content/container.tmpl | 2 +- templates/repo/issue/labels/label_list.tmpl | 12 +++++----- .../repo/issue/sidebar/reference_link.tmpl | 10 ++++----- templates/user/settings/repos.tmpl | 2 +- web_src/css/modules/grid.css | 22 ------------------- web_src/css/modules/table.css | 10 --------- web_src/fomantic/build/components/form.css | 10 --------- web_src/fomantic/build/components/modal.css | 9 ++------ 8 files changed, 13 insertions(+), 64 deletions(-) diff --git a/templates/package/content/container.tmpl b/templates/package/content/container.tmpl index a88ebec3bc..7d89f8c6e2 100644 --- a/templates/package/content/container.tmpl +++ b/templates/package/content/container.tmpl @@ -82,7 +82,7 @@ {{range $key, $value := .PackageDescriptor.Metadata.Labels}} - {{$key}} + {{$key}} {{$value}} {{end}} diff --git a/templates/repo/issue/labels/label_list.tmpl b/templates/repo/issue/labels/label_list.tmpl index 822567301e..cdbcc456f0 100644 --- a/templates/repo/issue/labels/label_list.tmpl +++ b/templates/repo/issue/labels/label_list.tmpl @@ -63,13 +63,11 @@ {{if and (not .PageIsOrgSettingsLabels) (.OrgLabels)}}
  • -
    -
    - {{ctx.Locale.Tr "repo.org_labels_desc"}} - {{if .IsOrganizationOwner}} - ({{ctx.Locale.Tr "repo.org_labels_desc_manage"}}): - {{end}} -
    +
    {{/* parent is flex, so use block here to keep sentence spaces */}} + {{ctx.Locale.Tr "repo.org_labels_desc"}} + {{if .IsOrganizationOwner}} + ({{ctx.Locale.Tr "repo.org_labels_desc_manage"}}): + {{end}}
    • diff --git a/templates/repo/issue/sidebar/reference_link.tmpl b/templates/repo/issue/sidebar/reference_link.tmpl index 6b8f120c7b..ad7c0f6bc0 100644 --- a/templates/repo/issue/sidebar/reference_link.tmpl +++ b/templates/repo/issue/sidebar/reference_link.tmpl @@ -1,8 +1,6 @@
    -
    - {{$issueReferenceLink := printf "%s#%d" .Issue.Repo.FullName .Issue.Index}} -
    - {{ctx.Locale.Tr "repo.issues.reference_link" $issueReferenceLink}} - -
    +{{$issueReferenceLink := printf "%s#%d" .Issue.Repo.FullName .Issue.Index}} +
    + {{ctx.Locale.Tr "repo.issues.reference_link" $issueReferenceLink}} +
    diff --git a/templates/user/settings/repos.tmpl b/templates/user/settings/repos.tmpl index a50fb586c7..4aed8070de 100644 --- a/templates/user/settings/repos.tmpl +++ b/templates/user/settings/repos.tmpl @@ -81,7 +81,7 @@ {{end}} {{else}} {{if .Repos}} -
    +
    {{range .Repos}}
    diff --git a/web_src/css/modules/grid.css b/web_src/css/modules/grid.css index 05e28c513f..b4f4e16105 100644 --- a/web_src/css/modules/grid.css +++ b/web_src/css/modules/grid.css @@ -393,28 +393,6 @@ margin-right: 2.5rem; } -.ui[class*="middle aligned"].grid > .column:not(.row), -.ui[class*="middle aligned"].grid > .row > .column, -.ui.grid > [class*="middle aligned"].row > .column, -.ui.grid > [class*="middle aligned"].column:not(.row), -.ui.grid > .row > [class*="middle aligned"].column { - flex-direction: column; - vertical-align: middle; - align-self: center !important; -} - -.ui[class*="equal width"].grid > .column:not(.row), -.ui[class*="equal width"].grid > .row > .column, -.ui.grid > [class*="equal width"].row > .column { - display: inline-block; - flex-grow: 1; -} -.ui[class*="equal width"].grid > .wide.column, -.ui[class*="equal width"].grid > .row > .wide.column, -.ui.grid > [class*="equal width"].row > .wide.column { - flex-grow: 0; -} - @media only screen and (max-width: 767.98px) { .ui[class*="mobile reversed"].grid, .ui[class*="mobile reversed"].grid > .row, diff --git a/web_src/css/modules/table.css b/web_src/css/modules/table.css index 844675b5ae..eabca31a17 100644 --- a/web_src/css/modules/table.css +++ b/web_src/css/modules/table.css @@ -152,16 +152,6 @@ } } -.ui.table[class*="top aligned"], -.ui.table [class*="top aligned"] { - vertical-align: top; -} - -.ui.table[class*="middle aligned"], -.ui.table [class*="middle aligned"] { - vertical-align: middle; -} - .ui.table th.collapsing, .ui.table td.collapsing { width: 1px; diff --git a/web_src/fomantic/build/components/form.css b/web_src/fomantic/build/components/form.css index 66ccedf29a..0124e2d6b5 100644 --- a/web_src/fomantic/build/components/form.css +++ b/web_src/fomantic/build/components/form.css @@ -1499,16 +1499,6 @@ width: 100%; } -/*-------------------- - Equal Width ----------------------*/ - -.ui[class*="equal width"].form .fields > .field, -.ui.form [class*="equal width"].fields > .field { - width: 100%; - flex: 1 1 auto; -} - /*-------------------- Inline Fields ---------------------*/ diff --git a/web_src/fomantic/build/components/modal.css b/web_src/fomantic/build/components/modal.css index 87a7989510..7da015cfd0 100644 --- a/web_src/fomantic/build/components/modal.css +++ b/web_src/fomantic/build/components/modal.css @@ -116,12 +116,7 @@ align-self: start; max-width: 100%; } -.ui.modal > [class*="top aligned"] { - align-self: start; -} -.ui.modal > [class*="middle aligned"] { - align-self: center; -} + .ui.modal > [class*="stretched"] { align-self: stretch; } @@ -258,7 +253,7 @@ padding: 1rem 0 !important; box-shadow: none; } - + /* Let Buttons Stack */ .ui.modal > .actions { padding: 1rem 1rem 0rem !important;