From a6eb361a238e2cd9171d8cef36bf767680223665 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Mon, 29 Dec 2025 18:34:16 -0800 Subject: [PATCH] Fix test --- tests/integration/project_workflow_test.go | 6 ++---- web_src/js/components/projects/WorkflowStore.ts | 8 +++----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/tests/integration/project_workflow_test.go b/tests/integration/project_workflow_test.go index a3b26a2d15..1d55f396aa 100644 --- a/tests/integration/project_workflow_test.go +++ b/tests/integration/project_workflow_test.go @@ -488,8 +488,7 @@ func TestProjectWorkflowValidation(t *testing.T) { var result map[string]any err = json.Unmarshal(resp.Body.Bytes(), &result) assert.NoError(t, err) - assert.Equal(t, "NoActions", result["error"], "Error should be NoActions") - assert.NotEmpty(t, result["message"], "Error message should be provided") + assert.Equal(t, "At least one action must be configured", result["errorMessage"]) }) // Test 2: Try to update a workflow to have no actions (should fail) @@ -546,8 +545,7 @@ func TestProjectWorkflowValidation(t *testing.T) { var result map[string]any err = json.Unmarshal(resp.Body.Bytes(), &result) assert.NoError(t, err) - assert.Equal(t, "NoActions", result["error"], "Error should be NoActions") - assert.NotEmpty(t, result["message"], "Error message should be provided") + assert.Equal(t, "At least one action must be configured", result["errorMessage"]) // Verify the workflow was not changed unchangedWorkflow, err := project_model.GetWorkflowByID(t.Context(), workflow.ID) diff --git a/web_src/js/components/projects/WorkflowStore.ts b/web_src/js/components/projects/WorkflowStore.ts index 29349b19cc..a9b7b214d7 100644 --- a/web_src/js/components/projects/WorkflowStore.ts +++ b/web_src/js/components/projects/WorkflowStore.ts @@ -241,7 +241,7 @@ export function createWorkflowStore(props: any): WorkflowStoreState { ); if (!hasAtLeastOneAction) { - showErrorToast(props.locale.atLeastOneActionRequired || 'At least one action must be configured'); + showErrorToast(props.locale.atLeastOneActionRequired); return; } @@ -268,10 +268,8 @@ export function createWorkflowStore(props: any): WorkflowStoreState { let errorMessage = `${props.locale.failedToSaveWorkflow}: ${response.status} ${response.statusText}`; try { const errorData = await response.json(); - if (errorData.message) { - errorMessage = errorData.message; - } else if (errorData.error === 'NoActions') { - errorMessage = props.locale.atLeastOneActionRequired || 'At least one action must be configured'; + if (errorData.errorMessage) { + errorMessage = errorData.errorMessage; } } catch { const errorText = await response.text();