From a8a1873b27636539198394e71a9b99ed96fca6eb Mon Sep 17 00:00:00 2001
From: hamki <me@hamki.org>
Date: Mon, 26 Jan 2026 17:27:10 +0800
Subject: [PATCH] fix: correct HTML nesting structure in TOC rendering

Fix invalid HTML structure where <ul> was directly nested inside <ul>.
According to HTML specification, nested <ul> elements must be wrapped
in <li> elements.

Before: <ul><ul>...</ul></ul>
After:  <ul><li><ul>...</ul></li></ul>
---
 modules/markup/html.go          | 19 ++++++++++++++-----
 modules/markup/html_toc_test.go | 16 ++++++++--------
 2 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/modules/markup/html.go b/modules/markup/html.go
index 1c2ae6918d..c2339838e5 100644
--- a/modules/markup/html.go
+++ b/modules/markup/html.go
@@ -254,26 +254,35 @@ func RenderTocHeadingItems(ctx *RenderContext, nodeDetailsAttrs map[string]strin
 	currentLevel := baseLevel
 	indent := []byte{' ', ' '}
 	_, _ = htmlutil.HTMLPrint(out, "<ul>\n")
-	for _, header := range ctx.TocHeadingItems {
+	for i, header := range ctx.TocHeadingItems {
+		// Go deeper: open nested <ul> elements (wrapped in <li> for valid HTML)
 		for currentLevel < header.HeadingLevel {
 			_, _ = out.Write(indent)
-			_, _ = htmlutil.HTMLPrint(out, "<ul>\n")
+			_, _ = htmlutil.HTMLPrint(out, "<li><ul>\n")
 			indent = append(indent, ' ', ' ')
 			currentLevel++
 		}
+		// Go shallower: close nested </ul></li> elements
 		for currentLevel > header.HeadingLevel {
 			indent = indent[:len(indent)-2]
 			_, _ = out.Write(indent)
-			_, _ = htmlutil.HTMLPrint(out, "</ul>\n")
+			_, _ = htmlutil.HTMLPrint(out, "</ul></li>\n")
 			currentLevel--
 		}
 		_, _ = out.Write(indent)
-		_, _ = htmlutil.HTMLPrintf(out, "<li><a href=\"#%s\">%s</a></li>\n", header.AnchorID, header.InnerText)
+		_, _ = htmlutil.HTMLPrintf(out, "<li><a href=\"#%s\">%s</a>", header.AnchorID, header.InnerText)
+		// Check if next item is at a deeper level - if so, don't close the <li> yet
+		nextIsDeeper := i+1 < len(ctx.TocHeadingItems) && ctx.TocHeadingItems[i+1].HeadingLevel > header.HeadingLevel
+		if !nextIsDeeper {
+			_, _ = htmlutil.HTMLPrint(out, "</li>")
+		}
+		_, _ = htmlutil.HTMLPrint(out, "\n")
 	}
+	// Close any remaining nested levels
 	for currentLevel > baseLevel {
 		indent = indent[:len(indent)-2]
 		_, _ = out.Write(indent)
-		_, _ = htmlutil.HTMLPrint(out, "</ul>\n")
+		_, _ = htmlutil.HTMLPrint(out, "</ul></li>\n")
 		currentLevel--
 	}
 	_, _ = htmlutil.HTMLPrint(out, "</ul>\n</details>\n")
diff --git a/modules/markup/html_toc_test.go b/modules/markup/html_toc_test.go
index e93cfc9346..ab363878a4 100644
--- a/modules/markup/html_toc_test.go
+++ b/modules/markup/html_toc_test.go
@@ -38,16 +38,16 @@ include_toc: true
 	result = re.ReplaceAllString(result, "\n")
 	expected := `<details><summary>toc</summary>
 <ul>
-  <li><a href="#user-content-tag-link-and-bold" rel="nofollow">tag link and Bold</a></li>
-  <ul>
-    <li><a href="#user-content-code-block-a" rel="nofollow">code block &lt;a&gt;</a></li>
-    <ul>
-      <ul>
+  <li><a href="#user-content-tag-link-and-bold" rel="nofollow">tag link and Bold</a>
+  <li><ul>
+    <li><a href="#user-content-code-block-a" rel="nofollow">code block &lt;a&gt;</a>
+    <li><ul>
+      <li><ul>
         <li><a href="#user-content-markdown-bold" rel="nofollow">markdown bold</a></li>
-      </ul>
-    </ul>
+      </ul></li>
+    </ul></li>
     <li><a href="#user-content-last" rel="nofollow">last</a></li>
-  </ul>
+  </ul></li>
 </ul>
 </details>