From b0ae5890cf10fc854125c2c10d58ff7e8568d3c3 Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 18 Oct 2026 10:00:56 +0200 Subject: [PATCH] chore: remove misspell (#39829) Remove the misspell spell checker along with its `lint-spell` and `lint-spell-fix` make targets, its CI step and its custom dictionary. `make lint` and `make lint-fix` no longer run a spell check. Co-authored-by: Giteabot --- .github/workflows/pull-compliance.yml | 3 +-- Makefile | 16 ++-------------- assets/misspellings.csv | 21 --------------------- 3 files changed, 3 insertions(+), 37 deletions(-) delete mode 100644 assets/misspellings.csv diff --git a/.github/workflows/pull-compliance.yml b/.github/workflows/pull-compliance.yml index 6e6aa080667..07d46b26ef6 100644 --- a/.github/workflows/pull-compliance.yml +++ b/.github/workflows/pull-compliance.yml @@ -27,6 +27,7 @@ jobs: - run: TAGS="bindata" make generate-go lint-backend # lint-go can lint with "bindata" tags lint-on-demand: + if: needs.files-changed.outputs.templates == 'true' || needs.files-changed.outputs.yaml == 'true' || needs.files-changed.outputs.actions == 'true' || needs.files-changed.outputs.docs == 'true' || needs.files-changed.outputs.swagger == 'true' || needs.files-changed.outputs.json == 'true' || needs.files-changed.outputs.shell == 'true' needs: files-changed runs-on: ubuntu-latest steps: @@ -38,8 +39,6 @@ jobs: with: cache: "false" - - run: make lint-spell - - if: needs.files-changed.outputs.templates == 'true' || needs.files-changed.outputs.yaml == 'true' || needs.files-changed.outputs.actions == 'true' uses: ./.github/actions/python-setup - if: needs.files-changed.outputs.templates == 'true' || needs.files-changed.outputs.yaml == 'true' diff --git a/Makefile b/Makefile index b06c8f455ee..ad1097339e9 100644 --- a/Makefile +++ b/Makefile @@ -8,7 +8,6 @@ AIR_PACKAGE ?= github.com/air-verse/air@v1.67.4 # renovate: datasource=go EDITORCONFIG_CHECKER_PACKAGE ?= github.com/editorconfig-checker/editorconfig-checker/v4/cmd/editorconfig-checker@v4.0.2 # renovate: datasource=go GOLANGCI_LINT_PACKAGE ?= github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.14.0 # renovate: datasource=go GXZ_PACKAGE ?= github.com/ulikunitz/xz/cmd/gxz@v0.5.17 # renovate: datasource=go -MISSPELL_PACKAGE ?= github.com/golangci/misspell/cmd/misspell@v0.8.0 # renovate: datasource=go SWAGGER_PACKAGE ?= github.com/go-swagger/go-swagger/cmd/swagger@v0.36.6 # renovate: datasource=go GOVULNCHECK_PACKAGE ?= golang.org/x/vuln/cmd/govulncheck@v1.8.0 # renovate: datasource=go ACTIONLINT_PACKAGE ?= github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 # renovate: datasource=go @@ -126,11 +125,9 @@ GO_LICENSE_FILE := assets/go-licenses.json TAR_EXCLUDES := .git data indexers queues log node_modules $(EXECUTABLE) $(DIST) $(MAKE_EVIDENCE_DIR) $(AIR_TMP_DIR) GO_DIRS := build cmd modelmigration models modules routers services tests tools -WEB_DIRS := web_src/js web_src/css ESLINT_FILES := web_src/js tools *.ts tests/e2e STYLELINT_FILES := web_src/css web_src/js/components/*.vue -SPELLCHECK_FILES := $(GO_DIRS) $(WEB_DIRS) templates options/locale/locale_en-US.json .github $(wildcard *.go *.md *.yml *.yaml *.toml) EDITORCONFIG_FILES := templates .github/workflows options/locale/locale_en-US.json GO_SOURCES := $(wildcard *.go) @@ -267,10 +264,10 @@ checks-frontend: lockfile-check svg-check ## check frontend files checks-backend: tidy-check swagger-check openapi3-check fmt-check swagger-validate security-check ## check backend files .PHONY: lint -lint: lint-frontend lint-backend lint-templates lint-swagger lint-spell lint-md lint-actions lint-json lint-yaml lint-shell ## lint everything +lint: lint-frontend lint-backend lint-templates lint-swagger lint-md lint-actions lint-json lint-yaml lint-shell ## lint everything .PHONY: lint-fix -lint-fix: lint-frontend-fix lint-backend-fix lint-spell-fix ## lint everything and fix issues +lint-fix: lint-frontend-fix lint-backend-fix ## lint everything and fix issues .PHONY: lint-frontend lint-frontend: lint-js lint-css ## lint frontend files @@ -314,14 +311,6 @@ lint-md: node_modules ## lint markdown files lint-md-fix: node_modules ## lint markdown files and fix issues pnpm exec markdownlint --fix *.md -.PHONY: lint-spell -lint-spell: ## lint spelling - @git ls-files $(SPELLCHECK_FILES) | xargs go run $(MISSPELL_PACKAGE) -dict assets/misspellings.csv -error - -.PHONY: lint-spell-fix -lint-spell-fix: ## lint spelling and fix issues - @git ls-files $(SPELLCHECK_FILES) | xargs go run $(MISSPELL_PACKAGE) -dict assets/misspellings.csv -w - .PHONY: lint-go lint-go: ## lint go files GO=$(GO) GOLANGCI_LINT_PACKAGE=$(GOLANGCI_LINT_PACKAGE) $(GO) run ./tools/lint-go-all.go @@ -577,7 +566,6 @@ deps-tools: ## install tool dependencies $(GO) install $(EDITORCONFIG_CHECKER_PACKAGE) & \ $(GO) install $(GOLANGCI_LINT_PACKAGE) & \ $(GO) install $(GXZ_PACKAGE) & \ - $(GO) install $(MISSPELL_PACKAGE) & \ $(GO) install $(SWAGGER_PACKAGE) & \ $(GO) install $(GOVULNCHECK_PACKAGE) & \ $(GO) install $(ACTIONLINT_PACKAGE) & \ diff --git a/assets/misspellings.csv b/assets/misspellings.csv deleted file mode 100644 index 645fb7853b1..00000000000 --- a/assets/misspellings.csv +++ /dev/null @@ -1,21 +0,0 @@ -acounts,accounts -canidate,candidate -comfirm,confirm -converage,coverage -currrently,currently -delimeter,delimiter -differrent,different -exclusing,excluding -finshed,finished -formated,formatted -inderect,indirect -insuficient,insufficient -likly,likely -mergable,mergeable -overrided,overridden -priortized,prioritized -registeration,registration -reuqest,request -reviwer,reviewer -superceded,superseded -underlaying,underlying