From ba326099b30c4fe429ea8ff0fd48ac272cfcd583 Mon Sep 17 00:00:00 2001 From: Lunny Xiao Date: Sun, 22 Feb 2026 10:01:16 -0800 Subject: [PATCH] improve code --- tests/integration/issue_test.go | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/integration/issue_test.go b/tests/integration/issue_test.go index 647642cccb..7fb71dfe69 100644 --- a/tests/integration/issue_test.go +++ b/tests/integration/issue_test.go @@ -20,6 +20,7 @@ import ( "code.gitea.io/gitea/models/unit" "code.gitea.io/gitea/models/unittest" user_model "code.gitea.io/gitea/models/user" + "code.gitea.io/gitea/modules/container" "code.gitea.io/gitea/modules/indexer/issues" "code.gitea.io/gitea/modules/references" "code.gitea.io/gitea/modules/setting" @@ -136,19 +137,16 @@ func testNewIssue(t *testing.T, session *TestSession, user, repo string, opts ne htmlDoc := NewHTMLParser(t, resp.Body) link, exists := htmlDoc.doc.Find("form.ui.form").Attr("action") assert.True(t, exists, "The template has changed") - var labelIDsBuf strings.Builder - for i, id := range opts.LabelIDs { - labelIDsBuf.WriteString(strconv.FormatInt(id, 10)) - if i < len(opts.LabelIDs)-1 { - labelIDsBuf.WriteRune(',') - } - } + + labelIDs := container.FilterSlice(opts.LabelIDs, func(id int64) (string, bool) { + return strconv.FormatInt(id, 10), id != 0 + }) req = NewRequestWithValues(t, "POST", link, map[string]string{ "title": opts.Title, "content": opts.Content, "project_id": strconv.FormatInt(opts.ProjectID, 10), - "label_ids": labelIDsBuf.String(), + "label_ids": strings.Join(labelIDs, ","), }) resp = session.MakeRequest(t, req, http.StatusOK)