Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-09-13 20:46:53 +02:00
Code Issues Activity

chore: update golangci-lint to v2.13.0

Browse Source 
Migrate the deprecated gofumpt `extra-rules` to `extra.group-params`, as
the alias now also enables the new `clothe-returns` and `balance-calls`
rules. Disable SA4023, which hangs on go 1.27, see
https://github.com/golangci/golangci-lint/issues/6732.

Apply the resulting modernize fixes, mostly flattening embedded struct
literals and switching errors.As to errors.AsType.

Assisted-by: Claude:Opus 5
This commit is contained in:
silverwind
2026-08-20 06:21:34 +02:00
parent b227ad8a5f
commit bef127f188
173 changed files with 1161 additions and 1659 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/git/commit_message_test.go
+8 -8
View File
@@ -11,7 +11,7 @@ import (
func TestCommitMessageSanitizesInvalidUTF8(t *testing.T) {
commit := &Commit{
CommitMessage: CommitMessage{MessageRaw: "title \xff\n\n\n\nbody \xff\n\n\n"},
MessageRaw: "title \xff\n\n\n\nbody \xff\n\n\n",
}
assert.Equal(t, "title ÿ", commit.MessageTitle())
assert.Equal(t, "body ÿ", commit.MessageBody())
@@ -65,7 +65,7 @@ func TestCommitMessageParticipants(t *testing.T) {
"CommitterExcluded",
&Commit{
Author: sig("a", "a@m.com"), Committer: sig("c", "c@m.com"),
CommitMessage: CommitMessage{MessageRaw: "CO-Authored-BY: Full Name <x@m.com>"},
MessageRaw: "CO-Authored-BY: Full Name <x@m.com>",
},
[]*CommitIdentity{idt("a", "a@m.com", roleAuthor), idt("Full Name", "x@m.com", roleCoAuthor)},
},
@@ -73,7 +73,7 @@ func TestCommitMessageParticipants(t *testing.T) {
"AuthorIsCoAuthor",
&Commit{
Author: sig("a", "a@m.com"), Committer: sig("c", "c@m.com"),
CommitMessage: CommitMessage{MessageRaw: "CO-Authored-BY: other-name <a@m.com>"},
MessageRaw: "CO-Authored-BY: other-name <a@m.com>",
},
[]*CommitIdentity{idt("a", "a@m.com", roleAuthor)},
},
@@ -81,7 +81,7 @@ func TestCommitMessageParticipants(t *testing.T) {
"EmptyAuthor", // synthesized commits (push feed) may have no author signature at all
&Commit{
Author: sig("", ""), Committer: sig("", ""),
CommitMessage: CommitMessage{MessageRaw: "Co-authored-by: c <c@m.com>"},
MessageRaw: "Co-authored-by: c <c@m.com>",
},
// but if the commit message contains co-authors, the co-authors are still parsed for "all authors"
// if it is a problem, the caller should fix the problem (provide correct "author")
@@ -98,7 +98,7 @@ func TestCommitMessageParticipants(t *testing.T) {
"GenuineCoAuthor",
&Commit{
Author: sig("a", "a@m.com"), Committer: sig("c", "c@m.com"),
CommitMessage: CommitMessage{MessageRaw: "Co-authored-by: x <x@m.com>"},
MessageRaw: "Co-authored-by: x <x@m.com>",
},
[]*CommitIdentity{idt("x", "x@m.com", roleCoAuthor)},
},
@@ -106,7 +106,7 @@ func TestCommitMessageParticipants(t *testing.T) {
"CoAuthorIsCommitter",
&Commit{
Author: sig("a", "a@m.com"), Committer: sig("c", "c@m.com"),
CommitMessage: CommitMessage{MessageRaw: "Co-authored-by: c <c@m.com>"},
MessageRaw: "Co-authored-by: c <c@m.com>",
},
[]*CommitIdentity{idt("c", "c@m.com", roleCoAuthor)},
},
@@ -114,7 +114,7 @@ func TestCommitMessageParticipants(t *testing.T) {
"CoAuthorIsAuthor",
&Commit{
Author: sig("a", "a@m.com"), Committer: sig("c", "c@m.com"),
CommitMessage: CommitMessage{MessageRaw: "Co-authored-by: a <a@m.com>"},
MessageRaw: "Co-authored-by: a <a@m.com>",
},
[]*CommitIdentity{},
},
@@ -122,7 +122,7 @@ func TestCommitMessageParticipants(t *testing.T) {
"CoAuthorNameOnlyAndDuplicate",
&Commit{
Author: sig("a", "a@m.com"), Committer: sig("c", "c@m.com"),
CommitMessage: CommitMessage{MessageRaw: "Co-authored-by: b\nCo-authored-by: b\nCo-authored-by: c"},
MessageRaw: "Co-authored-by: b\nCo-authored-by: b\nCo-authored-by: c",
},
[]*CommitIdentity{idt("b", "", roleCoAuthor), idt("c", "", roleCoAuthor)},
},