chore: update golangci-lint to v2.13.0

Migrate the deprecated gofumpt `extra-rules` to `extra.group-params`, as
the alias now also enables the new `clothe-returns` and `balance-calls`
rules. Disable SA4023, which hangs on go 1.27, see
https://github.com/golangci/golangci-lint/issues/6732.

Apply the resulting modernize fixes, mostly flattening embedded struct
literals and switching errors.As to errors.AsType.

Assisted-by: Claude:Opus 5

modules/setting/actions.go

@@ -93,7 +93,7 @@ func loadActionsFrom(rootCfg ConfigProvider) error {
 	}
 
 	if urls := string(Actions.DefaultActionsURL); urls != defaultActionsURLGitHub && urls != defaultActionsURLSelf {
-		url := strings.Split(urls, ",")[0]
+		url, _, _ := strings.Cut(urls, ",")
 		if strings.HasPrefix(url, "https://") || strings.HasPrefix(url, "http://") {
 			log.Error("[actions] DEFAULT_ACTIONS_URL does not support %q as custom URL any longer, fallback to %q",
 				urls,

modules/setting/cache.go

@@ -25,11 +25,9 @@ var CacheService = struct {
 		TTL time.Duration `ini:"ITEM_TTL"`
 	} `ini:"cache.last_commit"`
 }{
-	Cache: Cache{
-		Adapter:  "memory",
-		Interval: 60,
-		TTL:      16 * time.Hour,
-	},
+	Adapter:  "memory",
+	Interval: 60,
+	TTL:      16 * time.Hour,
 	LastCommit: struct {
 		TTL time.Duration `ini:"ITEM_TTL"`
 	}{

modules/setting/config_env.go

@@ -125,7 +125,7 @@ func EnvironmentToConfig(cfg ConfigProvider, envs []string) (changed bool) {
 		}
 
 		// use environment value as config value, or read the file content as value if the key indicates a file
-		keyValue := envValue //nolint:staticcheck // false positive
+		keyValue := envValue
 		if useFileValue {
 			fileContent, err := os.ReadFile(envValue)
 			if err != nil {

modules/setting/cron_test.go

@@ -30,9 +30,7 @@ EXTEND = true
 	assert.NoError(t, err)
 
 	extended := &Extended{
-		BaseStruct: BaseStruct{
-			Second: "queen of hearts",
-		},
+		Second: "queen of hearts",
 	}
 
 	_, err = getCronSettings(cfg, "test", extended)
@@ -71,15 +69,11 @@ THIRD = white rabbit
 	assert.NoError(t, err)
 
 	extended := &Extended2{
-		Extended: Extended{
-			BaseStruct: BaseStruct{
-				Enabled:    false,
-				RunAtStart: false,
-				Schedule:   "@every 72h",
-			},
-			Extend: false,
-		},
-		Third: "black rabbit",
+		Enabled:    false,
+		RunAtStart: false,
+		Schedule:   "@every 72h",
+		Extend:     false,
+		Third:      "black rabbit",
 	}
 
 	_, err = getCronSettings(cfg, "test", extended)