chore: update golangci-lint to v2.13.0

Migrate the deprecated gofumpt `extra-rules` to `extra.group-params`, as
the alias now also enables the new `clothe-returns` and `balance-calls`
rules. Disable SA4023, which hangs on go 1.27, see
https://github.com/golangci/golangci-lint/issues/6732.

Apply the resulting modernize fixes, mostly flattening embedded struct
literals and switching errors.As to errors.AsType.

Assisted-by: Claude:Opus 5

services/actions/auth.go

@@ -52,15 +52,13 @@ func CreateAuthorizationToken(taskID, runID, jobID int64) (string, error) {
 	}
 
 	claims := actionsClaims{
-		RegisteredClaims: jwt.RegisteredClaims{
-			ExpiresAt: jwt.NewNumericDate(now.Add(1*time.Hour + setting.Actions.EndlessTaskTimeout)),
-			NotBefore: jwt.NewNumericDate(now),
-		},
-		Scp:    fmt.Sprintf("Actions.Results:%d:%d", runID, jobID),
-		Ac:     string(ac),
-		TaskID: taskID,
-		RunID:  runID,
-		JobID:  jobID,
+		ExpiresAt: jwt.NewNumericDate(now.Add(1*time.Hour + setting.Actions.EndlessTaskTimeout)),
+		NotBefore: jwt.NewNumericDate(now),
+		Scp:       fmt.Sprintf("Actions.Results:%d:%d", runID, jobID),
+		Ac:        string(ac),
+		TaskID:    taskID,
+		RunID:     runID,
+		JobID:     jobID,
 	}
 	token := jwt.NewWithClaims(jwt.SigningMethodHS256, claims)
 

services/actions/schedule_tasks.go

@@ -10,7 +10,6 @@ import (
 	"time"
 
 	actions_model "gitea.dev/models/actions"
-	"gitea.dev/models/db"
 	"gitea.dev/models/organization"
 	perm_model "gitea.dev/models/perm"
 	access_model "gitea.dev/models/perm/access"
@@ -41,11 +40,9 @@ func startTasks(ctx context.Context) error {
 	for page := 1; ; page++ {
 		// Retrieve the specs for the current page
 		specs, _, err := actions_model.FindSpecs(ctx, actions_model.FindSpecOptions{
-			ListOptions: db.ListOptions{
-				Page:     page,
-				PageSize: pageSize,
-			},
-			Next: now.Unix(),
+			Page:     page,
+			PageSize: pageSize,
+			Next:     now.Unix(),
 		})
 		if err != nil {
 			return fmt.Errorf("find specs: %w", err)