chore: update golangci-lint to v2.13.0

Migrate the deprecated gofumpt `extra-rules` to `extra.group-params`, as
the alias now also enables the new `clothe-returns` and `balance-calls`
rules. Disable SA4023, which hangs on go 1.27, see
https://github.com/golangci/golangci-lint/issues/6732.

Apply the resulting modernize fixes, mostly flattening embedded struct
literals and switching errors.As to errors.AsType.

Assisted-by: Claude:Opus 5

services/auth/source/db/assert_interface_test.go

@@ -17,4 +17,4 @@ type sourceInterface interface {
 	auth_model.Config
 }
 
-var _ (sourceInterface) = &db.Source{}
+var _ sourceInterface = &db.Source{}

services/auth/source/ldap/assert_interface_test.go

@@ -22,4 +22,4 @@ type sourceInterface interface {
 	auth_model.UseTLSer
 }
 
-var _ (sourceInterface) = &ldap.Source{}
+var _ sourceInterface = &ldap.Source{}

services/auth/source/oauth2/assert_interface_test.go

@@ -18,4 +18,4 @@ type sourceInterface interface {
 	auth.PasswordAuthenticator
 }
 
-var _ (sourceInterface) = &oauth2.Source{}
+var _ sourceInterface = &oauth2.Source{}

services/auth/source/oauth2/init.go

@@ -8,6 +8,7 @@ import (
 	"encoding/gob"
 	"net/http"
 	"sync"
+	"uuid"
 
 	"gitea.dev/models/auth"
 	"gitea.dev/models/db"
@@ -17,7 +18,6 @@ import (
 
 	"github.com/gorilla/sessions"
 	"github.com/markbates/goth/gothic"
-	"uuid"
 )
 
 var gothRWMutex = sync.RWMutex{}

services/auth/source/oauth2/providers_custom.go

@@ -40,10 +40,8 @@ func (c *CustomProvider) CreateGothProvider(providerName, callbackURL string, so
 // NewCustomProvider is a constructor function for custom providers
 func NewCustomProvider(name, displayName string, customURLSetting *CustomURLSettings, newFn CustomProviderNewFn) *CustomProvider {
 	return &CustomProvider{
-		BaseProvider: BaseProvider{
-			name:        name,
-			displayName: displayName,
-		},
+		name:              name,
+		displayName:       displayName,
 		customURLSettings: customURLSetting,
 		newFn:             newFn,
 	}

services/auth/source/oauth2/providers_simple.go

@@ -39,12 +39,10 @@ func (c *SimpleProvider) CreateGothProvider(providerName, callbackURL string, so
 // NewSimpleProvider is a constructor function for simple providers
 func NewSimpleProvider(name, displayName string, scopes []string, newFn SimpleProviderNewFn) *SimpleProvider {
 	return &SimpleProvider{
-		BaseProvider: BaseProvider{
-			name:        name,
-			displayName: displayName,
-		},
-		scopes: scopes,
-		newFn:  newFn,
+		name:        name,
+		displayName: displayName,
+		scopes:      scopes,
+		newFn:       newFn,
 	}
 }
 

services/auth/source/oauth2/source_sync_test.go

@@ -18,14 +18,12 @@ func TestSource(t *testing.T) {
 
 	source := &Source{
 		Provider: "fake",
-		ConfigBase: auth.ConfigBase{
-			AuthSource: &auth.Source{
-				ID:            12,
-				Type:          auth.OAuth2,
-				Name:          "fake",
-				IsActive:      true,
-				IsSyncEnabled: true,
-			},
+		AuthSource: &auth.Source{
+			ID:            12,
+			Type:          auth.OAuth2,
+			Name:          "fake",
+			IsActive:      true,
+			IsSyncEnabled: true,
 		},
 	}
 

services/auth/source/oauth2/store.go

@@ -94,4 +94,4 @@ func (s *sizeWriter) Write(data []byte) (int, error) {
 	return len(data), nil
 }
 
-var _ (sessions.Store) = &SessionsStore{}
+var _ sessions.Store = &SessionsStore{}

services/auth/source/pam/assert_interface_test.go

@@ -17,4 +17,4 @@ type sourceInterface interface {
 	auth_model.Config
 }
 
-var _ (sourceInterface) = &pam.Source{}
+var _ sourceInterface = &pam.Source{}

services/auth/source/pam/source_authenticate.go

@@ -7,14 +7,13 @@ import (
 	"context"
 	"fmt"
 	"strings"
+	"uuid"
 
 	"gitea.dev/models/auth"
 	user_model "gitea.dev/models/user"
 	"gitea.dev/modules/auth/pam"
 	"gitea.dev/modules/optional"
 	"gitea.dev/modules/setting"
-
-	"uuid"
 )
 
 // Authenticate queries if login/password is valid against the PAM,

services/auth/source/smtp/assert_interface_test.go

@@ -20,4 +20,4 @@ type sourceInterface interface {
 	auth_model.UseTLSer
 }
 
-var _ (sourceInterface) = &smtp.Source{}
+var _ sourceInterface = &smtp.Source{}

services/auth/source/sspi/assert_interface_test.go

@@ -15,4 +15,4 @@ type sourceInterface interface {
 	auth.Config
 }
 
-var _ (sourceInterface) = &sspi.Source{}
+var _ sourceInterface = &sspi.Source{}