Fix milestone API state parameter unhandled (#10049)

* Fix milestone API state parameter unhandled

* Fix test
This commit is contained in:
Lunny Xiao authored and GitHub committed 2020-01-29 08:36:32 +02:00
1 parent f29c301040
commit c09e020558
5 files changed
+79 -6

No files matched your search

+6 -1
View File
@@ -204,7 +204,12 @@ func EditMilestone(ctx *context.APIContext, form api.EditMilestoneOption) {
milestone.DeadlineUnix = timeutil.TimeStamp(form.Deadline.Unix())
}
if err := models.UpdateMilestone(milestone); err != nil {
var oldIsClosed = milestone.IsClosed
if form.State != nil {
milestone.IsClosed = *form.State == string(api.StateClosed)
}
if err := models.UpdateMilestone(milestone, oldIsClosed); err != nil {
ctx.ServerError("UpdateMilestone", err)
return
}