Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-10-31 05:11:41 +01:00
Code Issues Activity

fix: do not return archive download URLs in API if downloads are disabled (#34324)

Browse Source 
If archive downloads are are disabled using
_DISABLE_DOWNLOAD_SOURCE_ARCHIVES_, archive links are still returned by
the API.

This PR changes the data returned, so the fields _zipball_url_ and
_tarball_url_ are omitted if archive downloads have been disabled.

Resolve #32159
This commit is contained in:
Tobias Balle-Petersen 2025-04-30 19:06:37 +02:00 committed by GitHub
parent ba5c3f8087
commit e67f74efc8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/structs/repo_tag.go
View File

@ -11,8 +11,8 @@ type Tag struct {
Message string `json:"message"` Message string `json:"message"`
ID string `json:"id"` ID string `json:"id"`
Commit *CommitMeta `json:"commit"` Commit *CommitMeta `json:"commit"`
ZipballURL string `json:"zipball_url"` ZipballURL string `json:"zipball_url,omitempty"`
TarballURL string `json:"tarball_url"` TarballURL string `json:"tarball_url,omitempty"`
} }
// AnnotatedTag represents an annotated tag // AnnotatedTag represents an annotated tag

13
services/convert/convert.go
View File

@ -197,13 +197,22 @@ func ToBranchProtection(ctx context.Context, bp *git_model.ProtectedBranch, repo
// ToTag convert a git.Tag to an api.Tag // ToTag convert a git.Tag to an api.Tag
func ToTag(repo *repo_model.Repository, t *git.Tag) *api.Tag { func ToTag(repo *repo_model.Repository, t *git.Tag) *api.Tag {
tarballURL := util.URLJoin(repo.HTMLURL(), "archive", t.Name+".tar.gz")
zipballURL := util.URLJoin(repo.HTMLURL(), "archive", t.Name+".zip")
// Archive URLs are "" if the download feature is disabled
if setting.Repository.DisableDownloadSourceArchives {
tarballURL = ""
zipballURL = ""
}
return &api.Tag{ return &api.Tag{
Name: t.Name, Name: t.Name,
Message: strings.TrimSpace(t.Message), Message: strings.TrimSpace(t.Message),
ID: t.ID.String(), ID: t.ID.String(),
Commit: ToCommitMeta(repo, t), Commit: ToCommitMeta(repo, t),
ZipballURL: util.URLJoin(repo.HTMLURL(), "archive", t.Name+".zip"), ZipballURL: zipballURL,
TarballURL: util.URLJoin(repo.HTMLURL(), "archive", t.Name+".tar.gz"), TarballURL: tarballURL,
} }
} }