Mirrors/gitea
0
0 Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-10-08 07:49:50 +02:00
Code Issues Activity

Fix bug preventing transfer to private organization (#12497) (#12501)

Browse Source 
* Fix bug preventing transfer to private organization

The code assessing whether a private organization was visible to a user before
allowing transfer was incorrect due to testing membership the wrong way round

This PR fixes this issue and renames the function performing the test to be
clearer.

Further looking at the API for transfer repository - no testing was
performed to ensure that the acting user could actually see the new
owning organization.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* change IsUserPartOfOrg everywhere

Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
techknowlogickandzeripath authored and GitHub committed 2020-08-17 09:32:33 +03:00
1 parent f0dd07129a
commit ec48618d40
5 files changed
+17 -8
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

models/org.go
+1 -1
View File
@@ -435,7 +435,7 @@ func hasOrgVisible(e Engine, org *User, user *User) bool {
return true
}
if (org.Visibility == structs.VisibleTypePrivate || user.IsRestricted) && !org.isUserPartOfOrg(e, user.ID) {
if (org.Visibility == structs.VisibleTypePrivate || user.IsRestricted) && !org.hasMemberWithUserID(e, user.ID) {
return false
}
return true