Lunny Xiao
a3b7b98336
Fix broken image when editing comment with non-image attachments ( #32319 ) ( #32345 )
...
Backport #32319
Fix #32316
---------
Co-authored-by: yp05327 <576951401@qq.com>
2024-11-02 13:34:09 +08:00
Zettat123
0d11ba93dd
Fix the permission check for user search API and limit the number of returned users for /user/search ( #32310 )
...
Partially backport #32288
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-23 04:56:13 +00:00
a1012112796
2a99607add
make show stats work when only one file changed ( #32244 ) ( #32268 )
...
Backport #32244
fix https://github.com/go-gitea/gitea/issues/32226
in https://github.com/go-gitea/gitea/pull/27775 , it do some changes to
only show diff file tree when more than one file changed. But looks it
also break the `diff-file-list` logic, which looks not expected change.
so try fix it.
/cc @silverwind
example view:
Signed-off-by: a1012112796 <1012112796@qq.com>
2024-10-17 08:03:21 +00:00
cloudchamb3r
c1023b97aa
[v1.22 backport] Fix null errors on conversation holder ( #32258 ) ( #32266 ) ( #32282 )
...
Backport #32266
fix #32258
Errors in the issue was due to unhandled null check. so i fixed it.
### Detailed description for Issue & Fix
To reproduce that issue, the comment must be deleted on Conversation
tab.
#### Before Delete
<img width="1032" alt="image"
src="https://github.com/user-attachments/assets/72df61ba-7db6-44c9-bebc-ca1178dd27f1 ">
#### After Delete (AS-IS)
<img width="1010" alt="image"
src="https://github.com/user-attachments/assets/36fa537e-4f8e-4535-8d02-e538c50f0dd8 ">
gitea already have remove logic for `timeline-item-group`, but because
of null ref exception the later logic that removes `timeline-item-group`
could be not be called correctly.
2024-10-17 13:34:39 +08:00
wxiaoguang
7e0fd4c208
Warn users when they try to use a non-root-url to sign in/up ( #32272 ) ( #32273 )
2024-10-17 09:01:44 +08:00
Giteabot
bcfe1f91d2
Fix dropdown content overflow ( #31610 ) ( #32250 )
...
Backport #31610 by charles7668
close #31602
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-13 03:46:55 +00:00
Giteabot
f15d5f0c4a
Fix checkbox bug on private/archive filter ( #32236 ) ( #32240 )
...
Backport #32236 by cloudchamb3r
fix #32235
Co-authored-by: cloudchamb3r <jizon0123@protonmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-11 21:13:09 +08:00
Giteabot
4815c4aeae
Add null check for responseData.invalidTopics ( #32212 ) ( #32217 )
...
Backport #32212 by @cloudchamb3r
<img width="553" alt="Screenshot 2024-10-08 at 10 49 10 AM"
src="https://github.com/user-attachments/assets/faeef64d-684a-4aba-b7fc-c7c6a0301abe ">
`responseData.invalidTopics` can be null but it wasn't handled.
Co-authored-by: cloudchamb3r <jizon0123@protonmail.com>
2024-10-09 09:18:29 +08:00
Lunny Xiao
2e3a191097
Fix javascript error when an anonymous user visiting migration page ( #32144 ) ( #32179 )
...
backport #32144
This PR fixes javascript errors when an anonymous user visits the
migration page.
It also makes task view checking more restrictive.
The router moved from `/user/task/{id}/status` to
`/username/reponame/-/migrate/status` because it's a migrate status.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-10-04 17:58:04 +00:00
Giteabot
5c73da7c54
Include collaboration repositories on dashboard source/forks/mirrors list ( #31946 ) ( #32122 )
...
Backport #31946 by @lunny
Fix #13489
In the original implementation, only `All` will display your owned and
collaborated repositories. For other filters like `Source`, `Mirrors`
and etc. will only display your owned repositories.
This PR removed the limitations. Now except `collbrations`, other
filters will always display your owned and collaborated repositories.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2024-09-24 15:17:30 +08:00
Lunny Xiao
244fb11c6b
Replace v-html with v-text in search inputbox ( #31966 ) ( #31973 ) ( #31975 )
...
Backport #31966 , #31973
Cherry-pick 30da734f3774b1c589c6#31972
---------
Co-authored-by: techknowlogick <techknowlogick@noreply.gitea.com>
2024-09-05 01:59:57 +00:00
sillyguodong
5d2afc6e4f
fix the component of access token list not mounted ( #31824 ) ( #31868 )
2024-08-19 12:56:17 -04:00
Giteabot
fe9a631939
Fix overflowing content in action run log ( #31842 ) ( #31853 )
...
Backport #31842 by @Adrian-Hirt
When a long line with characters such as dots is returned by a step in
an action (e.g. by the output of the Ruby on Rails test runner), it
overflows the log container, causing the page to scroll sideways (see
first screenshot):
This PR adds the CSS `overflow-wrap: anywhere;` to the
`.job-step-section .job-step-logs .job-log-line .log-msg` selector,
which causes such lines to wrap as well (see second screenshot in which
the line wraps nicely):
Co-authored-by: Adrian Hirt <13788379+Adrian-Hirt@users.noreply.github.com>
2024-08-18 08:34:05 +08:00
Giteabot
a3633b53d4
Scroll images in project issues separately from the remaining issue ( #31683 ) ( #31823 )
...
Backport #31683 by @SimonPistache
As discussed in #31667 & #26561 , when a card on a Project contains
images, they can overflow the card on its containing column. This aims
to fix this issue via snapping scrollbars.
---
Issue #31667 is open to discussion as there should be room for
improvement.
Co-authored-by: Simon Priet <105607989+SimonPistache@users.noreply.github.com>
2024-08-13 10:43:48 +08:00
Giteabot
f6f2349f8c
Add :focus-visible style to buttons ( #31799 ) ( #31819 )
...
Backport #31799 by @silverwind
Buttons now show a focus style via
[`:focus-visible`](https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible )
when the browser deems the focus to be important, like for example when
the button is focused via keyboard navigation.
<img width="492" alt="Screenshot 2024-08-07 at 22 12 51"
src="https://github.com/user-attachments/assets/060568b1-1599-4c56-bafb-b36ebb1bec35 ">
<img width="479" alt="image"
src="https://github.com/user-attachments/assets/885f4e10-f496-47f0-8ae5-45827ded09f8 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-08-12 12:41:13 +08:00
techknowlogick
edf96fcf6a
bump vue-bar-graph ( #31705 ) ( #31753 )
...
backport vue-bar-graph bump to remove gsap dep
2024-08-01 21:34:32 +03:00
wxiaoguang
0fb1c1fbfd
Fix "Filter by commit" Dropdown ( #31695 ) ( #31696 )
...
A separate backport of #31695 for 1.22
Fix #31673
2024-07-25 09:44:34 +08:00
Giteabot
c2b1b94c5a
Remove unneccessary uses of word-break: break-all ( #31637 ) ( #31652 )
...
Backport #31637 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/31636
1. Issue sidebar topic is disussed in
https://github.com/go-gitea/gitea/issues/31636
2. Org description already has `overflow-wrap: anywhere` to ensure no
overflow.
Co-authored-by: silverwind <me@silverwind.io>
2024-07-18 12:58:11 +02:00
Giteabot
dceadd2ebe
Fix avatar radius problem on the new issue page ( #31506 ) ( #31508 )
...
Backport #31506 by charles7668
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
2024-06-27 23:34:40 +08:00
wxiaoguang
151b786837
Fix dropzone JS error when attachment is disabled ( #31486 )
...
Fix #31485
2024-06-26 18:09:25 +08:00
Giteabot
58b1ee5ebd
Fix overflow menu flickering on mobile ( #31484 ) ( #31488 )
...
Backport #31484 by brechtvl
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
2024-06-26 01:13:04 +08:00
Giteabot
1825c316a6
Fix poor table column width due to breaking words ( #31473 ) ( #31477 )
...
Backport #31473 by brechtvl
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
Co-authored-by: silverwind <me@silverwind.io>
2024-06-25 08:00:17 +08:00
Giteabot
8d60c7d568
Switch to "Write" tab when edit comment again ( #31445 ) ( #31461 )
...
Backport #31445 by wxiaoguang
Fix #19031
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-06-22 23:47:36 +08:00
Giteabot
b83482b4ba
Fix labels and projects menu overflow on issue page ( #31435 ) ( #31439 )
...
Backport #31435 by brechtvl
It was correct only on the new issue page.
Resolves #31415
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
2024-06-20 16:59:49 +00:00
Giteabot
5c79c2b431
Fix new issue/pr avatar ( #31419 ) ( #31424 )
...
Backport #31419 by @silverwind
The avatar on "New Issue" and "New Pull Request" pages was inconsistent.
Removed the extra margin and the new CSS rules now use common parent
`<form id="#new-issue">` because `.repository.new.issue` is not present
on pull request page.
Before:
<img width="181" alt="Screenshot 2024-06-19 at 13 56 17"
src="https://github.com/go-gitea/gitea/assets/115237/5270d352-db5b-45b3-9d06-4790c17ae9b4 ">
<img width="213" alt="Screenshot 2024-06-19 at 13 54 02"
src="https://github.com/go-gitea/gitea/assets/115237/012f5607-aef0-4f48-90e3-8d4022480203 ">
After:
<img width="195" alt="Screenshot 2024-06-19 at 13 54 16"
src="https://github.com/go-gitea/gitea/assets/115237/e7590c66-3b28-4790-9970-33bd567eeb31 ">
<img width="212" alt="Screenshot 2024-06-19 at 13 54 22"
src="https://github.com/go-gitea/gitea/assets/115237/8e1cfede-614c-4cea-9af2-ada6da7a7361 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-06-19 21:18:10 +00:00
wxiaoguang
188e515efc
Fix repo graph JS ( #31377 )
...
Fix #31376
Regression of #30395
2024-06-14 18:21:40 +02:00
Giteabot
95dfd945bc
Fix line number widths ( #31341 ) ( #31343 )
...
Backport #31341 by silverwind
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-06-13 00:13:35 +00:00
Giteabot
4b6ef9265b
Fix navbar + menu flashing on page load ( #31281 ) ( #31342 )
...
Backport #31281 by silverwind
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-06-12 15:26:04 +00:00
Giteabot
c1c11aaf60
Fix line number width in code preview ( #31307 ) ( #31316 )
...
Backport #31307 by silverwind
Line numbers were using some hacky CSS `width: 1%` that did nothing to
the code rendering as far as I can tell but broken the inline preview in
markup when line numbers are greater than 2 digits. Also I removed one
duplicate `font-family` rule (it is set below in the `.lines-num,
.lines-code` selector.
Co-authored-by: silverwind <me@silverwind.io>
2024-06-11 13:30:02 +08:00
Giteabot
5ca4c6d066
Fix and clean up ConfirmModal ( #31283 ) ( #31291 )
...
Backport #31283 by @silverwind
Bug: orange button color was removed in
https://github.com/go-gitea/gitea/pull/30475 , replaced with red
Bug: translation text was not html-escaped
Refactor: Replaced as much jQuery as possible, added useful
`createElementFromHTML`
Refactor: Remove colors checks that don't exist on `.link-action`
<img width="381" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/5900bf6a-8a86-4a86-b368-0559cbfea66e ">
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
2024-06-07 15:51:54 +02:00
Giteabot
75e0bdcec5
Optimize repo-list layout to enhance visual experience ( #31272 ) ( #31276 )
...
Backport #31272 by @kerwin612
before:
***The problem was that the icon and text were not on a horizontal line,
and the horizontal was not centered;***
after:
Co-authored-by: Kerwin Bryant <kerwin612@qq.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-06-07 04:37:47 +00:00
Giteabot
c07416b3d0
Fix Activity Page Contributors dropdown ( #31264 ) ( #31269 )
...
Backport #31264 by wxiaoguang
Fix #31261
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-06-06 08:14:00 +00:00
Giteabot
082600a50e
Fix admin oauth2 custom URL settings ( #31246 ) ( #31247 )
...
Backport #31246 by wxiaoguang
Fix #31244
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-06-04 15:11:07 +00:00
Giteabot
5136c879c2
Make pasted "img" tag has the same behavior as markdown image ( #31235 ) ( #31243 )
...
Backport #31235 by wxiaoguang
Fix #31230
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2024-06-04 13:26:55 +00:00
Giteabot
298d05df3b
Remove .segment from .project-column ( #31204 ) ( #31239 )
...
Backport #31204 by @silverwind
Using `.segment` on the project columns is a major abuse of that class,
so remove it and instead set the border-radius directly on it.
Fixes: https://github.com/go-gitea/gitea/issues/31129
Co-authored-by: silverwind <me@silverwind.io>
2024-06-04 09:45:50 +00:00
Giteabot
a672f066f7
Use vertical layout for multiple code expander buttons ( #31122 ) ( #31152 )
...
Backport #31122 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/31068
- Now it only does a single call to `GetExpandDirection` per line
instead of multiples.
- Exposed `data-expand-direction` to frontend so it can correctly size
the buttons (it's a pain to do in tables).
<img width="142" alt="Screenshot 2024-05-27 at 20 44 56"
src="https://github.com/go-gitea/gitea/assets/115237/8b0b45a6-8e50-4081-8822-5e0775d8d941 ">
<img width="142" alt="Screenshot 2024-05-27 at 20 44 51"
src="https://github.com/go-gitea/gitea/assets/115237/b7ba2c57-8f55-4e9f-9606-c96d16b77892 ">
<img width="132" alt="Screenshot 2024-05-27 at 20 44 46"
src="https://github.com/go-gitea/gitea/assets/115237/0e838fb8-5e8c-4250-9843-a68b88d5418b ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 33"
src="https://github.com/go-gitea/gitea/assets/115237/da6c7f83-c160-4389-8ab2-889d0568cbe8 ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 26"
src="https://github.com/go-gitea/gitea/assets/115237/cdb490b2-5040-484a-92e5-46fc5e37c199 ">
<img width="78" alt="Screenshot 2024-05-27 at 20 44 20"
src="https://github.com/go-gitea/gitea/assets/115237/d2978ab0-764e-41ff-922c-25f8fe749f28 ">
Would backport as trivial enhancement.
Co-authored-by: silverwind <me@silverwind.io>
2024-05-29 09:06:34 +02:00
Giteabot
b615a59db8
Improve mobile review ui ( #31091 ) ( #31136 )
...
Backport #31091 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/31071
Not perfect but much better than before.
Before: Overflows, sticky not working, filename unreadable:
<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f ">
After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c ">
Co-authored-by: silverwind <me@silverwind.io>
2024-05-28 14:10:01 +00:00
Giteabot
447b3e2475
Fix DashboardRepoList margin ( #31121 ) ( #31128 )
...
Backport #31121 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/31115
<img width="476" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/ba508ba9-b02d-47c6-ad9f-495101c81330 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-05-28 17:12:15 +08:00
Giteabot
b903e2b753
Prevent tab shifting, remove extra margin on fluid pages ( #31090 ) ( #31099 )
...
Backport #31090 by @silverwind
1. Extend concept of https://github.com/go-gitea/gitea/pull/29831 to all
tabular menus, there were only three left that weren't already
`<overflow-menu>`.
<img width="634" alt="Screenshot 2024-05-27 at 00 42 16"
src="https://github.com/go-gitea/gitea/assets/115237/d9a7e219-d05e-40a1-9e93-777f9a8a90dd ">
<img width="965" alt="Screenshot 2024-05-27 at 00 29 32"
src="https://github.com/go-gitea/gitea/assets/115237/e6ed71b1-11fb-4a74-9adb-af4524286cff ">
2. Remove extra padding on `fluid padded` container like for example PR
diff view. The page margin is already correctly sized via
`.ui.container`, so this was just extraneous padding that looked ugly.
Before:
<img width="1351" alt="Screenshot 2024-05-27 at 00 45 11"
src="https://github.com/go-gitea/gitea/assets/115237/4b45fd11-b1b2-4fbb-a618-26eb22be9472 ">
After:
<img width="1344" alt="Screenshot 2024-05-27 at 00 45 22"
src="https://github.com/go-gitea/gitea/assets/115237/d09593eb-6c7f-45e7-85b6-f0050047004b ">
3. Replace `gt-word-break` with `tw-break-anywhere` in issue-title,
fixing overflow.
Before:
<img width="1333" alt="Screenshot 2024-05-27 at 00 50 14"
src="https://github.com/go-gitea/gitea/assets/115237/64d15d04-b456-401e-a972-df636965f0eb ">
After:
<img width="1316" alt="Screenshot 2024-05-27 at 00 50 26"
src="https://github.com/go-gitea/gitea/assets/115237/ed1ce830-1408-414b-8263-eeaf773f52c8 ">
Co-authored-by: silverwind <me@silverwind.io>
2024-05-27 07:41:10 +00:00
Giteabot
0e70f73055
Fix border radius on hovered secondary menu ( #31089 ) ( #31097 )
...
Backport #31089 by @silverwind
Presumably a regression from
https://github.com/go-gitea/gitea/pull/30325 , these menus were showing a
border radius on hover, which is fixed with this change.
<img width="154" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/eafdc1c5-3cf5-48d1-86c4-21c58f92cfaf ">
Co-authored-by: silverwind <me@silverwind.io>
2024-05-27 07:07:16 +00:00
Giteabot
7b7318255e
Change --border-radius-circle to --border-radius-full ( #30936 ) ( #31078 )
2024-05-26 13:16:13 +00:00
Giteabot
a798a1eb17
Fix project column title overflow ( #31011 ) ( #31025 )
...
Backport #31011 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-20 06:17:21 +00:00
Giteabot
bd3787c774
Fix JS error when editing a merged PR's title ( #30990 ) ( #31001 )
...
Backport #30990 by @wxiaoguang
Regression of Fix issue/PR title edit (#30858 )
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-17 01:07:09 +00:00
Giteabot
c1337e7316
Restyle release list, fix branch dropdown ( #30837 ) ( #30968 )
...
Backport #30837 by @silverwind
Fixes https://github.com/go-gitea/gitea/issues/30821 and restyles the
release list.
Desktop:
<img width="1199" alt="Screenshot 2024-05-02 at 20 46 10"
src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd ">
Mobile:
<img width="443" alt="Screenshot 2024-05-02 at 20 46 21"
src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d ">
Co-authored-by: silverwind <me@silverwind.io>
2024-05-13 22:00:52 +00:00
Giteabot
ebe8e63dfd
Fix file path width in repo non-homepage view ( #30951 ) ( #30952 )
...
Backport #30951 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/30940
<img width="1310" alt="Screenshot 2024-05-11 at 20 48 41"
src="https://github.com/go-gitea/gitea/assets/115237/f163dfd4-1299-421f-a99e-cd0c793e0e3d ">
Co-authored-by: silverwind <me@silverwind.io>
2024-05-12 14:07:16 +02:00
Giteabot
94c5a30c8b
Fix some UI regressions for commit list ( #30920 ) ( #30937 )
...
Backport #30920 by wxiaoguang
Close #30919
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-05-10 22:36:06 +08:00
Giteabot
b99473f4ec
Check if reverse proxy is correctly configured ( #30890 ) ( #30935 )
...
Backport #30890 by wxiaoguang
Follow #27011
Follow #30885
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-05-10 12:34:04 +00:00
Giteabot
08d697ae70
Add missing menu active item background back ( #30897 ) ( #30907 )
...
Backport #30897 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-08 23:53:02 +00:00
Giteabot
5f1af1f37d
Fix incorrect issue form ( #30881 ) ( #30904 )
...
Backport #30881 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-08 23:26:53 +00:00
Giteabot
084bec89ed
Fix various problems around projects board view ( #30696 ) ( #30902 )
...
Backport #30696 by @lunny
# The problem
The previous implementation will start multiple POST requests from the
frontend when moving a column and another bug is moving the default
column will never be remembered in fact.
# What's changed
- [x] This PR will allow the default column to move to a non-first
position
- [x] And it also uses one request instead of multiple requests when
moving the columns
- [x] Use a star instead of a pin as the icon for setting the default
column action
- [x] Inserted new column will be append to the end
- [x] Fix #30701 the newly added issue will be append to the end of the
default column
- [x] Fix when deleting a column, all issues in it will be displayed
from UI but database records exist.
- [x] Add a limitation for columns in a project to 20. So the sorting
will not be overflow because it's int8.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-08 15:46:21 +00:00
