william-allspice 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e9c64f41a6 
							
						 
					 
					
						
						
							
							Distinguish official vs non-official reviews, add tool tips, and upgr… ( #31924 )  
						
						... 
						
						
						
						This Pull Request is a follow up to
https://github.com/go-gitea/gitea/pull/31886 :
1. Adds a UI indicator between official (green) and unofficial (grey)
approved pull requests on the Pull Request page (as suggested by
@kdumontnu )
2. Adds tooltips adding clarity to the type and status of a review on
the Pull Request page (as suggested by @kdumontnu)
3. Updates text adding more clarity to required approvals (as suggested
by @kdumontnu)
4. Updates text on the branch settings page explaining what branch
approval limitations (as suggested by @yp05327)
Official approval:
<img width="376" alt="Screenshot 2024-08-26 at 1 03 52 PM"
src="https://github.com/user-attachments/assets/500f083d-bfc0-45c5-82b7-b98e20495696 ">
Unofficial approval:
<img width="442" alt="Screenshot 2024-08-26 at 12 53 15 PM"
src="https://github.com/user-attachments/assets/e8c565ff-5886-4ce1-8b79-a0fa26c282f7 ">
Rejected approval:
<img width="452" alt="Screenshot 2024-08-26 at 12 53 06 PM"
src="https://github.com/user-attachments/assets/aebc0e2f-7052-4dea-8098-7caa0db86617 ">
Stale approval:
<img width="546" alt="Screenshot 2024-08-26 at 1 07 59 PM"
src="https://github.com/user-attachments/assets/da599ff3-e35c-4fa3-8141-ed80b738dd77 ">
Requested review tooltip:
<img width="434" alt="Screenshot 2024-08-26 at 12 53 22 PM"
src="https://github.com/user-attachments/assets/460d163e-8724-43b6-8760-34b285da8fe2 ">
Updated text for approvals:
<img width="991" alt="Screenshot 2024-08-26 at 12 54 00 PM"
src="https://github.com/user-attachments/assets/ab3ff012-9742-4c1b-933d-21addcb89f2c ">
Updated text for allowlisted/whitelisted approvals:
<img width="990" alt="Screenshot 2024-08-26 at 1 01 40 PM"
src="https://github.com/user-attachments/assets/1a5bae61-d9e0-4d96-b86f-92610b0940d1 ">
Protected branch settings text:
<img width="1022" alt="Screenshot 2024-08-26 at 1 01 14 PM"
src="https://github.com/user-attachments/assets/892ce208-e1c2-41f7-8fec-46d5a0e7e776 ">
Comments list:
<img width="1048" alt="Screenshot 2024-08-28 at 9 25 31 AM"
src="https://github.com/user-attachments/assets/9c5c00c5-06cf-43b3-b413-4f7f673609b2 ">
---------
Co-authored-by: Kyle D. <kdumontnu@gmail.com> 
						
						
					 
					
						2024-09-06 06:40:02 +00:00 
						 
				 
			
				
					
						
							
							
								Zettat123 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8883d99184 
							
						 
					 
					
						
						
							
							Support issue template assignees ( #31083 )  
						
						... 
						
						
						
						Resolve  #13955  
					
						2024-08-12 16:00:40 +08:00 
						 
				 
			
				
					
						
							
							
								a1012112796 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							9633f336c8 
							
						 
					 
					
						
						
							
							Add warning message in merge instructions when AutodetectManualMerge was not enabled ( #31805 )  
						
						... 
						
						
						
						not enabled
quick-f-i-x https://github.com/go-gitea/gitea/issues/31433  ? , maybe
need more disscusion about better solutions.
example view:

adtion notes about how to enable `AutodetectManualMerge`

Signed-off-by: a1012112796 <1012112796@qq.com> 
						
						
					 
					
						2024-08-10 01:09:34 +00:00 
						 
				 
			
				
					
						
							
							
								Lunny Xiao 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							791d7fc76a 
							
						 
					 
					
						
						
							
							Add issue comment when moving issues from one column to another of the project ( #29311 )  
						
						... 
						
						
						
						Fix  #27278 
Replace #27816 
This PR adds a meta-comment for an issue when dragging an issue from one
column to another of a project.
<img width="600" alt="image"
src="https://github.com/go-gitea/gitea/assets/81045/5fc1d954-430e-4db0-aaee-a00006fa91f5 ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: yp05327 <576951401@qq.com> 
					
						2024-08-09 01:29:02 +00:00 
						 
				 
			
				
					
						
							
							
								yp05327 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							75d0b61546 
							
						 
					 
					
						
						
							
							Fix the display of project type for deleted projects ( #31732 )  
						
						... 
						
						
						
						Fix : #31727 
After:
 
					
						2024-07-30 04:37:43 +00:00 
						 
				 
			
				
					
						
							
							
								Bartlomiej Komendarczuk 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e8d4b7a8b1 
							
						 
					 
					
						
						
							
							Added default sorting milestones by name ( #27084 )  
						
						... 
						
						
						
						#26996  
Added default sorting for milestones by name.
Additional, name for sorting closestduedate and furthestduedate was
broken, so I fixed it.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> 
					
						2024-07-16 10:08:54 +02:00 
						 
				 
			
				
					
						
							
							
								6543 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d7c7a78994 
							
						 
					 
					
						
						
							
							Don't show hidden labels when filling out an issue template ( #31576 )  
						
						... 
						
						
						
						Related to #31574 
---
*Sponsored by Kithara Software GmbH* 
						
						
					 
					
						2024-07-08 04:31:12 +00:00 
						 
				 
			
				
					
						
							
							
								Kemal Zebari 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0c4ff01109 
							
						 
					 
					
						
						
							
							Disable issue/PR comment button given empty input ( #31463 )  
						
						... 
						
						
						
						Given an empty issue/PR comment, the comment history would not be
updated if the user were to submit it. Therefore, it would make since to
just disable the comment button when the text editor is empty.
This is inline with what GitHub does when given empty text editor input.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
						
						
					 
					
						2024-06-23 18:41:01 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							37a4b233a0 
							
						 
					 
					
						
						
							
							Refactor repo unit "disabled" check ( #31389 )  
						
						... 
						
						
						
						1. There are already global "unit consts", no need to use context data, which is fragile
2. Remove the "String()" method from "unit", it would only cause rendering problems in templates
---------
Co-authored-by: silverwind <me@silverwind.io> 
						
						
					 
					
						2024-06-18 00:51:13 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							21ba5ca03b 
							
						 
					 
					
						
						
							
							Fix navbar + menu flashing on page load ( #31281 )  
						
						... 
						
						
						
						Fixes
https://github.com/go-gitea/gitea/pull/31273#issuecomment-2153771331 .
Same method as used in https://github.com/go-gitea/gitea/pull/30215 . All
left-opening dropdowns need to use it method.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2024-06-12 14:58:03 +00:00 
						 
				 
			
				
					
						
							
							
								Kerwin Bryant 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e6ab6e637f 
							
						 
					 
					
						
						
							
							code optimization ( #31315 )  
						
						... 
						
						
						
						Simplifying complex if-else to existing Iif operations 
						
						
					 
					
						2024-06-11 21:07:10 +08:00 
						 
				 
			
				
					
						
							
							
								Max Wipfli 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							da4bbc4247 
							
						 
					 
					
						
						
							
							Allow including Reviewed-on/Reviewed-by lines for custom merge messages ( #31211 )  
						
						... 
						
						
						
						This PR introduces the `ReviewedOn` and `ReviewedBy` variables for the
default merge message templates (e.g.,
`.gitea/default_merge_message/MERGE_TEMPLATE.md`).
This allows customizing the default merge messages while retaining these
trailers.
This also moves the associated logic out of `pull.tmpl` into the
relevant Go function.
This is a first contribution towards #11077 .
---
For illustration, this allows to recreate the "default default" merge
message with the following template:
```
.gitea/default_merge_message/MERGE_TEMPLATE.md
Merge pull request '${PullRequestTitle}' (${PullRequestReference}) from ${HeadBranch} into ${BaseBranch}
${ReviewedOn}
${ReviewedBy}
``` 
						
						
					 
					
						2024-06-06 08:35:04 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							138e946c3d 
							
						 
					 
					
						
						
							
							Replace gt-word-break with tw-break-anywhere ( #31183 )  
						
						... 
						
						
						
						`overflow-wrap: anywhere` is a superior alternative to `word-wrap:
break-word` and we were already setting it in the class. I tested a few
cases, all look good. 
						
						
					 
					
						2024-06-04 13:57:11 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							9b05bfb173 
							
						 
					 
					
						
						
							
							Fix overflow in issue card ( #31203 )  
						
						... 
						
						
						
						Before:
<img width="373" alt="Screenshot 2024-06-01 at 01 31 26"
src="https://github.com/go-gitea/gitea/assets/115237/82a210f2-c82e-4b7e-ac43-e70e46fa1186 ">
After:
<img width="376" alt="Screenshot 2024-06-01 at 01 31 32"
src="https://github.com/go-gitea/gitea/assets/115237/82d1b9f7-4fad-47bd-948a-04e1e7e006e6 "> 
						
						
					 
					
						2024-06-03 00:09:51 +00:00 
						 
				 
			
				
					
						
							
							
								Lunny Xiao 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2788a7ca27 
							
						 
					 
					
						
						
							
							Fix agit checkout command line hint & fix ShowMergeInstructions checking ( #31219 )  
						
						
						
						
					 
					
						2024-06-03 06:45:21 +08:00 
						 
				 
			
				
					
						
							
							
								metiftikci 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							aa92b13164 
							
						 
					 
					
						
						
							
							Prevent simultaneous editing of comments and issues ( #31053 )  
						
						... 
						
						
						
						fixes  #22907  
Tested:
- [x] issue content edit
- [x] issue content change tasklist
- [x] pull request content edit
- [x] pull request change tasklist
 
					
						2024-05-27 15:34:18 +00:00 
						 
				 
			
				
					
						
							
							
								Lunny Xiao 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							98751108b1 
							
						 
					 
					
						
						
							
							Rename project board -> column to make the UI less confusing ( #30170 )  
						
						... 
						
						
						
						This PR split the `Board` into two parts. One is the struct has been
renamed to `Column` and the second we have a `Template Type`.
But to make it easier to review, this PR will not change the database
schemas, they are just renames. The database schema changes could be in
future PRs.
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: yp05327 <576951401@qq.com> 
						
						
					 
					
						2024-05-27 08:59:54 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6e140b58dd 
							
						 
					 
					
						
						
							
							Prevent tab shifting, remove extra margin on fluid pages ( #31090 )  
						
						... 
						
						
						
						1. Extend concept of https://github.com/go-gitea/gitea/pull/29831  to all
tabular menus, there were only three left that weren't already
`<overflow-menu>`.
<img width="634" alt="Screenshot 2024-05-27 at 00 42 16"
src="https://github.com/go-gitea/gitea/assets/115237/d9a7e219-d05e-40a1-9e93-777f9a8a90dd ">
<img width="965" alt="Screenshot 2024-05-27 at 00 29 32"
src="https://github.com/go-gitea/gitea/assets/115237/e6ed71b1-11fb-4a74-9adb-af4524286cff ">
2. Remove extra padding on `fluid padded` container like for example PR
diff view. The page margin is already correctly sized via
`.ui.container`, so this was just extraneous padding that looked ugly.
Before:
<img width="1351" alt="Screenshot 2024-05-27 at 00 45 11"
src="https://github.com/go-gitea/gitea/assets/115237/4b45fd11-b1b2-4fbb-a618-26eb22be9472 ">
After:
<img width="1344" alt="Screenshot 2024-05-27 at 00 45 22"
src="https://github.com/go-gitea/gitea/assets/115237/d09593eb-6c7f-45e7-85b6-f0050047004b ">
3. Replace `gt-word-break` with `tw-break-anywhere` in issue-title,
fixing overflow.
Before:
<img width="1333" alt="Screenshot 2024-05-27 at 00 50 14"
src="https://github.com/go-gitea/gitea/assets/115237/64d15d04-b456-401e-a972-df636965f0eb ">
After:
<img width="1316" alt="Screenshot 2024-05-27 at 00 50 26"
src="https://github.com/go-gitea/gitea/assets/115237/ed1ce830-1408-414b-8263-eeaf773f52c8 "> 
						
						
					 
					
						2024-05-27 06:45:16 +00:00 
						 
				 
			
				
					
						
							
							
								Zettat123 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7ab0988af1 
							
						 
					 
					
						
						
							
							Support setting the default attribute of the issue template dropdown field ( #31045 )  
						
						... 
						
						
						
						Fix  #31044 
According to [GitHub issue template
documentation](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#attributes-for-dropdown ),
the `default` attribute can be used to specify the preselected option
for a dropdown field. 
					
						2024-05-23 13:01:02 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							740b6e1389 
							
						 
					 
					
						
						
							
							Fix JS error when editing a merged PR's title ( #30990 )  
						
						
						
						
					 
					
						2024-05-16 13:04:25 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3fdb2d4ad8 
							
						 
					 
					
						
						
							
							Fix incorrect issue form ( #30881 )  
						
						... 
						
						
						
						Fix  #30864  
					
						2024-05-08 15:39:13 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							eda10cc2bb 
							
						 
					 
					
						
						
							
							Fix some UI problems (dropdown/container) ( #30849 )  
						
						... 
						
						
						
						Follow #30345 
Follow #30547 
`ellipsis` / `white-space` shouldn't be put on the general dropdown components. 
						
						
					 
					
						2024-05-06 07:17:22 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							5c236bd4c0 
							
						 
					 
					
						
						
							
							Fix issue/PR title edit ( #30858 )  
						
						... 
						
						
						
						1. "enter" doesn't work (I think it is the last enter support for #14843 )
2. if a branch name contains something like `&`, then the branch selector doesn't update 
						
						
					 
					
						2024-05-05 13:09:41 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6ff2acc52c 
							
						 
					 
					
						
						
							
							Fix issue card layout ( #30800 )  
						
						... 
						
						
						
						Fix  #30788  
					
						2024-05-02 11:19:44 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							ebe6f4cad7 
							
						 
					 
					
						
						
							
							Fix branch selector UI ( #30803 )  
						
						... 
						
						
						
						Fix  #30802  
						
						
					 
					
						2024-05-02 10:45:23 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a3d9f0d915 
							
						 
					 
					
						
						
							
							Fix all rounded borders, change affected tab menus to pills ( #30707 )  
						
						... 
						
						
						
						Fixes https://github.com/go-gitea/gitea/issues/30673 , all 23 issues.
Notes:
- Tab bar menus had to change to pills because of unsolvable issue with
the border-radius as tab bar renders a overlapping border onto the box
below. And I think pills look better.
- Added padding to code editor empty preview message
- Hide monaco's built-in blue focus border, we don't need it and it
never showed before either.
- Label add menu is simplified, removing the nested segment.
<img width="1322" alt="Screenshot 2024-04-25 at 22 26 19"
src="https://github.com/go-gitea/gitea/assets/115237/7e394e0c-b7ad-417d-8e9f-12f1dea93ed1 ">
<img width="1326" alt="Screenshot 2024-04-25 at 22 28 00"
src="https://github.com/go-gitea/gitea/assets/115237/66c8499f-aa9f-4d95-8cca-ef13dfa82c65 ">
<img width="997" alt="Screenshot 2024-04-25 at 22 36 53"
src="https://github.com/go-gitea/gitea/assets/115237/07896102-c71d-4246-8173-c2bc2e1d3cae ">
<img width="832" alt="Screenshot 2024-04-25 at 22 56 09"
src="https://github.com/go-gitea/gitea/assets/115237/d83afc96-08ca-4adc-baf4-3d02804be57c ">
<img width="361" alt="Screenshot 2024-04-25 at 22 57 12"
src="https://github.com/go-gitea/gitea/assets/115237/c7371a68-00b5-47d8-84d0-ddc5268b2b2c ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2024-04-29 20:53:15 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8de2992ffb 
							
						 
					 
					
						
						
							
							Make Ctrl+Enter work for issue/comment edit ( #30720 )  
						
						... 
						
						
						
						Fix  #30710  
					
						2024-04-27 14:32:00 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b93c87b6fe 
							
						 
					 
					
						
						
							
							Issue card improvements ( #30687 )  
						
						... 
						
						
						
						Fixes https://github.com/go-gitea/gitea/issues/30682  and does a few
improvements:
- Use gap instead of margin/padding
- Don't render empty image div
- Remove `right floated` class that did nothing
<img width="406" alt="Screenshot 2024-04-24 at 20 21 20"
src="https://github.com/go-gitea/gitea/assets/115237/2fa88707-c2c4-40df-aee7-a684c3097ed0 ">
---------
Co-authored-by: KN4CK3R <admin@oldschoolhack.me> 
						
						
					 
					
						2024-04-27 13:35:26 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2ee93ea178 
							
						 
					 
					
						
						
							
							Avoid doubled border for the PR info segment ( #30663 )  
						
						
						
						
					 
					
						2024-04-23 19:24:10 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1e4867730b 
							
						 
					 
					
						
						
							
							Fix dropdown text ellipsis ( #30628 )  
						
						... 
						
						
						
						Follow
https://github.com/go-gitea/gitea/pull/30547#discussion_r1573866519 
Fix  #30624 
The Fomantic UI Dropdown wasn't designed to work that way, its "text"
element might contain images. So the "overflow" shouldn't be added to
any general dropdown text.
 
						
						
					 
					
						2024-04-21 23:14:33 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							f95622cddc 
							
						 
					 
					
						
						
							
							Fix issue comment form and quick-submit ( #30623 )  
						
						... 
						
						
						
						1. Rewrite initGlobalEnterQuickSubmit (by the way, remove jQuery)
2. Fix issue comment form layout 
						
						
					 
					
						2024-04-22 01:00:04 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							dd8e6ae270 
							
						 
					 
					
						
						
							
							Improve "Reference in new issue" modal ( #30547 )  
						
						... 
						
						
						
						Fixes: https://github.com/go-gitea/gitea/issues/29994 
Also some misc enhancements done to the form in the modal.
<img width="840" alt="Screenshot 2024-04-17 at 23 02 55"
src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43 "> 
						
						
					 
					
						2024-04-18 19:31:53 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3e2e76e248 
							
						 
					 
					
						
						
							
							Refactor web routes ( #30519 )  
						
						... 
						
						
						
						Re-organize the routes in web.go and use ctx constants instead of `context.UnitTypes()`
---------
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2024-04-17 08:31:37 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a658e2f277 
							
						 
					 
					
						
						
							
							Fix long branch name overflows ( #30345 )  
						
						... 
						
						
						
						Fixes: https://github.com/go-gitea/gitea/issues/27971 
Fixes: https://github.com/go-gitea/gitea/pull/28010 
<img width="689" alt="Screenshot 2024-04-09 at 00 19 57"
src="https://github.com/go-gitea/gitea/assets/115237/7c895a47-274f-40a6-a126-290658f1982d ">
Also fixes a similar issue in issue list where CSS was there but not
active because of missing `display: block`.
<img width="372" alt="Screenshot 2024-04-09 at 00 18 25"
src="https://github.com/go-gitea/gitea/assets/115237/cfbee7cd-2e15-4ac7-96ce-020816f48798 "> 
						
						
					 
					
						2024-04-16 08:52:45 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							9946353282 
							
						 
					 
					
						
						
							
							Remove fomantic button module ( #30475 )  
						
						... 
						
						
						
						CSS-only module. Button colors are reduced to this:
<img width="639" alt="Screenshot 2024-04-14 at 15 36 07"
src="https://github.com/go-gitea/gitea/assets/115237/882d6c02-d1de-44f2-b707-db02a9f5070d ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
						
						
					 
					
						2024-04-14 17:53:52 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							4b1063f3db 
							
						 
					 
					
						
						
							
							Rewrite and restyle reaction selector and enable no-sizzle eslint rule ( #30453 )  
						
						... 
						
						
						
						Enable `no-sizzle` lint rule, there was only one use in `initCompReactionSelector` and:
- Remove all jQuery except the necessary fomantic dropdown init
- Remove the recursion, instead bind event listeners to common parent container nodes
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2024-04-14 18:44:11 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							18dd9f9a3f 
							
						 
					 
					
						
						
							
							Fix label rendering ( #30456 )  
						
						... 
						
						
						
						1. Check whether the label is for an issue or a pull request.
2. Don't use space to layout
3. Make sure the test strings have trailing spaces explicitly, to avoid
some IDE removing the trailing spaces automatically. 
						
						
					 
					
						2024-04-13 10:05:33 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							944c76e784 
							
						 
					 
					
						
						
							
							Fix spacing in issue navbar ( #30238 )  
						
						... 
						
						
						
						Create a new `issue-navbar` class specifically for this bar, previous
class used in many places and I thought I had them all removed, but not
this one.
Fixes: https://github.com/go-gitea/gitea/issues/30226  
						
						
					 
					
						2024-04-02 11:48:07 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							ff334749f5 
							
						 
					 
					
						
						
							
							Remove fomantic input module ( #30194 )  
						
						... 
						
						
						
						Another pure CSS module. Some styling is part of the `form` module which
will likely follow next. 
						
						
					 
					
						2024-03-31 16:06:06 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8da9130c1f 
							
						 
					 
					
						
						
							
							Prevent flash of dropdown menu on labels list ( #30215 )  
						
						... 
						
						
						
						On the labels list, This `left` class caused the dropdown content to
flash on page load until JS had hidden it. Remove it as I see no purpose
to it.
<img width="215" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/9e1de97f-dd89-41e0-9229-5c4a786ba762 ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
						
						
					 
					
						2024-03-31 16:58:55 +02:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8fd15990c5 
							
						 
					 
					
						
						
							
							Remove fomantic checkbox module ( #30162 )  
						
						... 
						
						
						
						CSS is pretty slim already and the `.ui.toggle.checkbox` sliders on
admin page also still work. The only necessary JS is the one that links
`input` and `label` so that it can be toggled via label. All checkboxes
except the markdown ones render at `--checkbox-size: 16px` now.
<img width="174" alt="Screenshot 2024-03-28 at 22 15 10"
src="https://github.com/go-gitea/gitea/assets/115237/3455c1bb-166b-47e4-9847-2d20dd1f04db ">
<img width="499" alt="Screenshot 2024-03-28 at 21 00 07"
src="https://github.com/go-gitea/gitea/assets/115237/412be2b3-d5a0-478a-b17b-43e6bc12e8ce ">
<img width="83" alt="Screenshot 2024-03-28 at 22 14 34"
src="https://github.com/go-gitea/gitea/assets/115237/d8c89838-a420-4723-8c49-89405bb39474 ">
---------
Co-authored-by: delvh <dev.lh@web.de> 
						
						
					 
					
						2024-03-29 04:56:01 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							dd8dde2be8 
							
						 
					 
					
						
						
							
							replace jquery-minicolors with coloris ( #30055 )  
						
						... 
						
						
						
						Get rid of one more jQuery dependant and have a nicer color picker as
well.
Now there is only a single global color picker init because that is all
that's necessary because the elements are present on the page when the
init code runs. The init is slightly weird because the module only takes
a selector instead of DOM elements directly.
The label modals now also perform form validation because previously it
was possible to trigger a 500 error `Color cannot be empty.` by clearing
out the color value on labels.
<img width="867" alt="Screenshot 2024-03-25 at 00 21 05"
src="https://github.com/go-gitea/gitea/assets/115237/71215c39-abb1-4881-b5c1-9954b4a89adb ">
<img width="860" alt="Screenshot 2024-03-25 at 00 20 48"
src="https://github.com/go-gitea/gitea/assets/115237/a12cb68f-c38b-4433-ba05-53bbb4b1023e "> 
						
						
					 
					
						2024-03-29 04:00:07 +01:00 
						 
				 
			
				
					
						
							
							
								Kemal Zebari 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							242b331260 
							
						 
					 
					
						
						
							
							Prevent re-review and dismiss review actions on closed and merged PRs ( #30065 )  
						
						... 
						
						
						
						Resolves  #29965 .
---
Manually tested this by:
- Following the
[installation](https://docs.gitea.com/next/installation/install-with-docker#basics )
guide (but built a local Docker image instead)
- Creating 2 users, one who is the `Owner` of a newly-created repository
and the other a `Collaborator`
- Had the `Collaborator` create a PR that the `Owner` reviews
- `Collaborator` resolves conversation and `Owner` merges PR
And with this change we see that we can no longer see re-request review
button for the `Owner`:
<img width="1351" alt="Screenshot 2024-03-25 at 12 39 18 AM"
src="https://github.com/go-gitea/gitea/assets/60799661/bcd9c579-3cf7-474f-a51e-b436fe1a39a4 "> 
					
						2024-03-28 15:19:24 +00:00 
						 
				 
			
				
					
						
							
							
								HEREYUA 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1261dd6742 
							
						 
					 
					
						
						
							
							When the title in the issue has a value, set the text cursor at the end of the text. ( #30090 )  
						
						... 
						
						
						
						Fix:  [#25055 ](https://github.com/go-gitea/gitea/issues/25055 )
Before

After

ps: I've noticed that we are gradually replacing jQuery, so I didn't use jQuery here. 
						
						
					 
					
						2024-03-27 15:20:10 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8717c1c2be 
							
						 
					 
					
						
						
							
							Fix menu buttons in issues and release ( #30056 )  
						
						... 
						
						
						
						Fix regression from https://github.com/go-gitea/gitea/pull/30033 
These buttons had lost their border because `.ui.header` sets `none` but
`.ui.menu` has it, after the migration, the order of styles changed and
header won. I see no reason why those have the `header` class in first
place, besides for semantic meaning.
Before:
<img width="491" alt="Screenshot 2024-03-25 at 00 39 27"
src="https://github.com/go-gitea/gitea/assets/115237/fa1b7505-75cf-4854-a97f-db3c46f31e93 ">
After:
<img width="496" alt="Screenshot 2024-03-25 at 00 39 14"
src="https://github.com/go-gitea/gitea/assets/115237/8f6bdc07-9596-436b-8c82-9af283300004 "> 
						
						
					 
					
						2024-03-25 13:52:54 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							ec3d467f15 
							
						 
					 
					
						
						
							
							Migrate gt-hidden to tw-hidden ( #30046 )  
						
						... 
						
						
						
						We have to define this one in helpers.css because tailwind only
generates a single class but certain things rely on this being
double-class. Command ran:
```sh
perl -p -i -e 's#gt-hidden#tw-hidden#g' web_src/js/**/* templates/**/* models/**/* web_src/css/**/*
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
						
						
					 
					
						2024-03-24 18:23:38 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							68ec9b4859 
							
						 
					 
					
						
						
							
							Migrate margin and padding helpers to tailwind ( #30043 )  
						
						... 
						
						
						
						This will conclude the refactor of 1:1 class replacements to tailwind,
except `gt-hidden`. Commands ran:
```bash
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-0#tw-$1$2-0#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-1#tw-$1$2-0.5#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-2#tw-$1$2-1#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-3#tw-$1$2-2#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-4#tw-$1$2-4#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-5#tw-$1$2-8#g'   {web_src/js,templates,routers,services}/**/*
``` 
						
						
					 
					
						2024-03-24 17:42:49 +01:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							90a4f9a49e 
							
						 
					 
					
						
						
							
							Migrate gap helpers to tailwind ( #30034 )  
						
						... 
						
						
						
						Commands ran:
```sh
perl -p -i -e 's#gt-gap-0#tw-gap-0#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-1#tw-gap-0.5#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-2#tw-gap-1#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-3#tw-gap-2#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-4#tw-gap-4#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-5#tw-gap-8#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-0#tw-gap-x-0#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-1#tw-gap-x-0.5#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-2#tw-gap-x-1#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-3#tw-gap-x-2#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-4#tw-gap-x-4#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-5#tw-gap-x-8#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-0#tw-gap-y-0#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-1#tw-gap-y-0.5#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-2#tw-gap-y-1#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-3#tw-gap-y-2#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-4#tw-gap-y-4#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-5#tw-gap-y-8#g'   web_src/js/**/* templates/**/* 
						
						
					 
					
						2024-03-24 14:31:35 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0bef9a2775 
							
						 
					 
					
						
						
							
							Replace all simple inline styles with tailwind ( #30032 )  
						
						... 
						
						
						
						These should be all simple inline styles that were left in the
templates.
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2024-03-23 20:11:15 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							fabe01478a 
							
						 
					 
					
						
						
							
							Migrate font-weight helpers to tailwind ( #30027 )  
						
						... 
						
						
						
						Commands ran:
```sh
perl -p -i -e 's#gt-font-light#tw-font-light#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-normal#tw-font-normal#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-medium#tw-font-medium#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-semibold#tw-font-semibold#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-bold#tw-font-bold#g' web_src/js/**/* templates/**/*
``` 
						
						
					 
					
						2024-03-23 18:45:11 +00:00