HesterG 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							457946d595 
							
						 
					 
					
						
						
							
							Allow change line of admin-dl-horizontal dt ( #25508 )  
						
						... 
						
						
						
						Close  #25389 
After:
<img width="915" alt="Screen Shot 2023-06-26 at 11 00 12"
src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20 ">
admin/dashboard:
<img width="957" alt="Screen Shot 2023-06-26 at 10 59 51"
src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7 "> 
					
						2023-06-26 11:49:14 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							323c6cba20 
							
						 
					 
					
						
						
							
							Fine tune "dropdown button" icon ( #25442 )  
						
						... 
						
						
						
						
----
 
						
						
					 
					
						2023-06-25 02:40:41 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b8253607fe 
							
						 
					 
					
						
						
							
							Revert "Make buttons in a modal form have proper type. ( #25446 )" ( #25485 )  
						
						... 
						
						
						
						There is a side effect because some modal doesn't have a proper "ok"
button.
This reverts commit a954c93a68072042aa7dad717b6fa002c83a58fb. 
						
						
					 
					
						2023-06-25 10:03:09 +08:00 
						 
				 
			
				
					
						
							
							
								sebastian-sauer 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							77e449f0be 
							
						 
					 
					
						
						
							
							Highlight viewed files differently in the PR filetree ( #24956 )  
						
						... 
						
						
						
						
fixes  #24566 
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
						
						
					 
					
						2023-06-25 08:46:30 +08:00 
						 
				 
			
				
					
						
							
							
								hiifong 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8e6a114317 
							
						 
					 
					
						
						
							
							fix tags line no margin see  #25255  ( #25280 )  
						
						... 
						
						
						
						This is my first pr, there are many things I don't understand very well,
I am very sorry, I rearranged the code and opened this new pr.
Now:
 
						
						
					 
					
						2023-06-24 20:30:46 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							be47015229 
							
						 
					 
					
						
						
							
							Navbar fixes ( #25402 )  
						
						... 
						
						
						
						Fixes: https://github.com/go-gitea/gitea/issues/25444 
Followup for some regressions from
https://github.com/go-gitea/gitea/pull/25343 . Before and after:
<img width="219" alt="Screenshot 2023-06-21 at 00 25 20"
src="https://github.com/go-gitea/gitea/assets/115237/08fe8e01-0a16-4cdf-ad4d-0a9048408e9e ">
<img width="220" alt="Screenshot 2023-06-21 at 00 25 32"
src="https://github.com/go-gitea/gitea/assets/115237/be25ae69-6ed0-4af5-8eeb-d7b210e7c124 ">
Fixes mobile button background and margins:
<img width="836" alt="Screenshot 2023-06-21 at 00 39 58"
src="https://github.com/go-gitea/gitea/assets/115237/d76ac1e9-747f-477c-9a42-b73e129b72ee "> 
						
						
					 
					
						2023-06-24 04:31:39 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							62ab55bacc 
							
						 
					 
					
						
						
							
							Improve wiki sidebar and TOC ( #25460 )  
						
						... 
						
						
						
						Close  #20976 
Close  #20975 
1. Fix the bug: the TOC in footer was incorrectly rendered as main
content's TOC
2. Fix the layout: on mobile, the TOC is put above the main content,
while the sidebar is put below the main content
3. Auto collapse the TOC on mobile
ps: many styles of "wiki.css" are moved from old css files, so leave
nits to following PRs. 
					
						2023-06-23 15:51:43 -04:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a954c93a68 
							
						 
					 
					
						
						
							
							Make buttons in a modal form have proper type. ( #25446 )  
						
						... 
						
						
						
						Fix  #25438 
All non-"ok" buttons which do not have "type" should not submit the
form, should not be triggered by "Enter".
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-23 12:57:01 +02:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d2142ba3c3 
							
						 
					 
					
						
						
							
							Update octicons and use octicon-file-directory-symlink ( #25453 )  
						
						... 
						
						
						
						Make use of the [new
octicon](https://github.com/primer/octicons/issues/945 ) that indicates a
symlink to a directory:
<img width="189" alt="Screenshot 2023-06-22 at 22 50 57"
src="https://github.com/go-gitea/gitea/assets/115237/a70690ea-ebfc-48fe-af23-cdc33bcb2098 "> 
						
						
					 
					
						2023-06-22 22:05:52 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7fb539677b 
							
						 
					 
					
						
						
							
							Diff page enhancements ( #25398 )  
						
						... 
						
						
						
						Two small tweaks:
1. Vertically center arrow here when editing a PR:
<img width="405" alt="Screenshot 2023-06-20 at 19 48 49"
src="https://github.com/go-gitea/gitea/assets/115237/1d63764d-9fd9-467e-8a8e-9258c06475eb ">
2. Use 2-row layout on diff viewed status and show it again on mobile:
<img width="142" alt="Screenshot 2023-06-20 at 19 51 21"
src="https://github.com/go-gitea/gitea/assets/115237/3046e782-163c-4f87-910c-a22066de8f1b ">
Mobile view:
<img width="370" alt="Screenshot 2023-06-20 at 19 44 40"
src="https://github.com/go-gitea/gitea/assets/115237/9cf56347-7323-4d05-99a5-17ad215ee44d "> 
						
						
					 
					
						2023-06-22 11:05:22 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							af094fbb6c 
							
						 
					 
					
						
						
							
							Introduce shared template for search inputs ( #25338 )  
						
						... 
						
						
						
						- Set
[type=search](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search )
- Disable spellcheck
- Set maxLength 255 that I found in `templates/repo/issue/search.tmpl`
- Remove unnecessary `max-width`, it does nothing
---------
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-22 10:27:35 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							93cd579269 
							
						 
					 
					
						
						
							
							Switch to ansi_up for ansi rendering in actions ( #25401 )  
						
						... 
						
						
						
						Fixes: https://github.com/go-gitea/gitea/issues/24777  
						
						
					 
					
						2023-06-22 02:15:19 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							656d3cc719 
							
						 
					 
					
						
						
							
							Various UI fixes ( #25264 )  
						
						... 
						
						
						
						Numerous small UI fixes:
- Fix double border in collaborator list
- Fix system notice table background
- Mute links in repo and org lists
- Downsize projects edit buttons
- Improve milestones and project list rendering
- Condense milestone list entry to a single line of "metas"
- Mute ".." button in repo files list 
						
						
					 
					
						2023-06-21 21:59:49 -04:00 
						 
				 
			
				
					
						
							
							
								sebastian-sauer 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							25455bc670 
							
						 
					 
					
						
						
							
							Show outdated comments in files changed tab ( #24936 )  
						
						... 
						
						
						
						If enabled show a clickable label in the comment. A click on the label
opens the Conversation tab with the comment focussed - there you're able
to view the old diff (or original diff the comment was created on).
**Screenshots**


When resolved and outdated:

Option to enable/disable this (stored in user settings - default is
disabled):


fixes  #24913 
---------
Co-authored-by: silverwind <me@silverwind.io> 
						
						
					 
					
						2023-06-21 16:08:12 +00:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							dfd19fa38c 
							
						 
					 
					
						
						
							
							Fine tune project board label colors and modal content background ( #25419 )  
						
						... 
						
						
						
						- The label text color on project board is not contrasting enough,
changed to colors that are same as places that also used
`useLightTextOnBackground` function
([util_render.go](2cdf260f42/modules/templates/util_render.go (L136-L141)2cdf260f42/web_src/js/components/ContextPopup.vue (L81-L84)https://github.com/go-gitea/gitea/assets/17645053/1527ca28-c884-4ca9-a4be-7a72ad1a093a ">
<img width="900" alt="Screen Shot 2023-06-21 at 14 25 52"
src="https://github.com/go-gitea/gitea/assets/17645053/fab82116-7376-4027-a0a4-9eedf9fb0a30 ">
After:
<img width="1383" alt="Screen Shot 2023-06-21 at 14 19 33"
src="https://github.com/go-gitea/gitea/assets/17645053/fe0997e7-fee6-4522-bc4e-545088ec1cc8 ">
<img width="797" alt="Screen Shot 2023-06-21 at 14 32 42"
src="https://github.com/go-gitea/gitea/assets/17645053/b0591af0-950c-4448-9430-34d6c7215971 "> 
						
						
					 
					
						2023-06-21 18:15:51 +08:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1454f9dafc 
							
						 
					 
					
						
						
							
							Add actor and status dropdowns to run list ( #25118 )  
						
						... 
						
						
						
						Part of #25042 
1. Added actor and status dropdowns first in case something is offtrack
and PR is too large.
2. Also added "No results matched." and "The workflow has no runs yet.",
and "No results matched." will show if there is no filter results and
there is no workflows (with [reference to github
action](https://github.com/go-gitea/gitea/actions/workflows/files-changed.yml?query=actor%3AGiteaBot ))
Demo:
https://github.com/go-gitea/gitea/assets/17645053/6e76292c-4c1f-450d-8b48-99944cfc920c 
TODOs:
- [x] Get available status (same as those in `aggregateJobStatus`)
instead of getting from database
- [x] Use `JOIN` to get actors, actors order by name
- [x] Make self on top 
						
						
					 
					
						2023-06-21 04:25:14 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							831db53c21 
							
						 
					 
					
						
						
							
							Fix dropdown icon layout on diff page ( #25397 )  
						
						... 
						
						
						
						Address
https://github.com/go-gitea/gitea/pull/25163#issuecomment-1599207916 
Remove the unused  "icon-button".
And fix the layout:
Without the dropdown icon:
```
	{{svg "gitea-whitespace"}}
```

With the dropdown icon:
```
	{{svg "gitea-whitespace" 16 "gt-mr-3"}}
	{{svg "octicon-triangle-down" 14 "dropdown icon"}}
```
 
						
						
					 
					
						2023-06-20 23:22:48 +00:00 
						 
				 
			
				
					
						
							
							
								sillyguodong 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							35a653d7ed 
							
						 
					 
					
						
						
							
							Support configuration variables on Gitea Actions ( #24724 )  
						
						... 
						
						
						
						Co-Author: @silverwind @wxiaoguang 
Replace: #24404 
See:
- [defining configuration variables for multiple
workflows](https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows )
- [vars
context](https://docs.github.com/en/actions/learn-github-actions/contexts#vars-context )
Related to:
- [x] protocol: https://gitea.com/gitea/actions-proto-def/pulls/7 
- [x] act_runner: https://gitea.com/gitea/act_runner/pulls/157 
- [x] act: https://gitea.com/gitea/act/pulls/43 
#### Screenshoot
Create Variable:


Workflow:
```yaml
  test_vars:
    runs-on: ubuntu-latest
    steps:
      - name: Print Custom Variables
        run: echo "${{ vars.test_key }}"
      - name: Try to print a non-exist var
        run: echo "${{ vars.NON_EXIST_VAR }}"
```
Actions Log:

---
This PR just implement the org / user (depends on the owner of the
current repository) and repo level variables, The Environment level
variables have not been implemented.
Because
[Environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#about-environments )
is a module separate from `Actions`. Maybe it would be better to create
a new PR to do it.
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-20 22:54:15 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e50c3e8431 
							
						 
					 
					
						
						
							
							Navbar styling rework ( #25343 )  
						
						... 
						
						
						
						- Extract navbar CSS to own file
- Reduce height from 52px to 50px
- Give every item a hover effect of of 36px, including the logo and on
mobile
- Consistent horizontal padding of 10px left and right
<img width="549" alt="Screenshot 2023-06-18 at 13 41 16"
src="https://github.com/go-gitea/gitea/assets/115237/0b00d101-253e-4b1f-9ee2-322d60fb2e26 ">
<img width="98" alt="Screenshot 2023-06-18 at 14 03 43"
src="https://github.com/go-gitea/gitea/assets/115237/4ef5d98b-4d1e-45de-822e-c2c844e19876 ">
<img width="234" alt="Screenshot 2023-06-18 at 14 03 18"
src="https://github.com/go-gitea/gitea/assets/115237/a4d9b04b-83de-42aa-a9ce-f010a9690688 ">
<img width="873" alt="Screenshot 2023-06-18 at 13 58 28"
src="https://github.com/go-gitea/gitea/assets/115237/8cb8e31e-2adf-40c8-ae3f-d00d011b4d1b ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-20 20:35:25 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							ef6f5f0124 
							
						 
					 
					
						
						
							
							rename tributeValues to mentionValues ( #25375 )  
						
						... 
						
						
						
						Very simple change, just rename this variable so it does not feature the
name of the module. 
						
						
					 
					
						2023-06-20 03:32:49 +00:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							49a77e37ba 
							
						 
					 
					
						
						
							
							Fix sidebar label dropdown divider ( #25359 )  
						
						... 
						
						
						
						Follow #25312  
Also fix the label dropdown on sidebar
Before:
<img width="1345" alt="Screen Shot 2023-06-19 at 08 55 05"
src="https://github.com/go-gitea/gitea/assets/17645053/3a98e871-b482-4ecb-8ce2-74df67fb65a7 ">
After:
<img width="1408" alt="Screen Shot 2023-06-19 at 08 57 17"
src="https://github.com/go-gitea/gitea/assets/17645053/09af15cc-1250-49b3-98b6-5b1a2b9021cb "> 
						
						
					 
					
						2023-06-19 17:49:50 +00:00 
						 
				 
			
				
					
						
							
							
								Denys Konovalov 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7f38cf71fe 
							
						 
					 
					
						
						
							
							Fix issue filters on mobile view ( #25368 )  
						
						... 
						
						
						
						Fix  #24846  applying the solution proposed by @silverwind 
<details>
<summary>Screenshots</summary>






</details>
Replaces #25335  
					
						2023-06-19 17:12:15 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							c09d0b4952 
							
						 
					 
					
						
						
							
							Fix loading state regression in markup content ( #25349 )  
						
						... 
						
						
						
						Fix regressions from https://github.com/go-gitea/gitea/pull/25219 :
Math before and after:
<img width="630" alt="Screenshot 2023-06-18 at 16 00 52"
src="https://github.com/go-gitea/gitea/assets/115237/f2a01e4b-31ca-407c-8fc3-f0aec569b48e ">
<img width="680" alt="Screenshot 2023-06-18 at 16 03 44"
src="https://github.com/go-gitea/gitea/assets/115237/faab8e39-f088-45ab-b460-15fc3654c99d ">
Mermain before and after:
<img width="810" alt="Screenshot 2023-06-18 at 15 58 56"
src="https://github.com/go-gitea/gitea/assets/115237/d8c24e81-4702-4e17-b791-7dffe090c068 ">
<img width="786" alt="Screenshot 2023-06-18 at 15 58 37"
src="https://github.com/go-gitea/gitea/assets/115237/3a268e10-c071-410d-a66e-8c4427d1d61c "> 
						
						
					 
					
						2023-06-19 08:00:18 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a1c5057fe8 
							
						 
					 
					
						
						
							
							Batch delete issue and improve tippy opts ( #25253 )  
						
						... 
						
						
						
						1. Add "batch delete" button for selected issues, close  #22273 
2. Address the review in
https://github.com/go-gitea/gitea/pull/25219#discussion_r1229266083  
						
						
					 
					
						2023-06-19 15:46:50 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							bfab129fb9 
							
						 
					 
					
						
						
							
							Fix label list divider ( #25312 )  
						
						... 
						
						
						
						We only needs 2 lines to hide the dividers.
```
  $dropdownLabelFilter.dropdown('setting', {'hideDividers': 'empty'});
  $dropdownLabelFilter.dropdown('refreshItems');
```
Other code blocks are refactored by the way.

 
						
						
					 
					
						2023-06-18 17:33:12 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							695f5d170b 
							
						 
					 
					
						
						
							
							Fix incorrect link-action event target ( #25306 )  
						
						... 
						
						
						
						A regression of #25210 
The `e.target` is not "this", eg: `<button link-action><svg></button>`,
then `this` should be `button` but `e.target` is `svg`.
I will propose a clearer and complete solution for these "link-action"
"show-modal" elements after #24724 
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-18 17:23:18 +02:00 
						 
				 
			
				
					
						
							
							
								Denys Konovalov 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							9e74063498 
							
						 
					 
					
						
						
							
							Fix UI on mobile view ( #25315 )  
						
						... 
						
						
						
						Various fixes to pages or elements which were looking ugly on mobile.
<details>
<summary>Screenshots</summary>









</details>
Co-authored by @silverwind
---------
Co-authored-by: silverwind <me@silverwind.io> 
						
						
					 
					
						2023-06-18 10:31:42 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							f47744c3f1 
							
						 
					 
					
						
						
							
							Update JS dependencies, remove space after emoji completion ( #25266 )  
						
						... 
						
						
						
						- Update all JS dependencies
- Enable stylint
[`media-feature-name-value-no-unknown`](https://stylelint.io/user-guide/rules/media-feature-name-value-no-unknown )
- Make use of new features in webpack and text-expander-element
- Tested Swagger and Mermaid
To explain the `text-expander-element` change: Before this version, the
element added a unavoidable space after emoji completion. Now that
https://github.com/github/text-expander-element/pull/36  is in, we gain
control over this space and I opted to remove it for emoji completion
and retain it for `@` mentions.
---------
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-18 08:38:47 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							61e0827f42 
							
						 
					 
					
						
						
							
							Add stylelint-declaration-block-no-ignored-properties ( #25284 )  
						
						... 
						
						
						
						Add
[stylelint-declaration-block-no-ignored-properties](https://github.com/kristerkari/stylelint-declaration-block-no-ignored-properties )
and fix discovered issue. There is no visual difference in these markup
code blocks. 
						
						
					 
					
						2023-06-18 04:22:09 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							95ab485490 
							
						 
					 
					
						
						
							
							Remove EasyMDE focus outline on text ( #25328 )  
						
						... 
						
						
						
						EasyMDE in Firefox currently shows an ugly outline in the fake textarea
the CodeMirror uses. Hide it. 
						
						
					 
					
						2023-06-18 04:10:07 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3ee8970419 
							
						 
					 
					
						
						
							
							add stylelint-stylistic ( #25285 )  
						
						... 
						
						
						
						Add
[stylelint-stylistic](https://github.com/elirasza/stylelint-stylistic ),
autofix all issues with two manual tweaks. This restores all the
stylistic rules removed in Stylelint 15. 
						
						
					 
					
						2023-06-17 13:20:32 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							69b1e2f103 
							
						 
					 
					
						
						
							
							Remove more unused Fomantic variants ( #25292 )  
						
						... 
						
						
						
						Save another 50KB of CSS by removing unused and useless Fomantic
variants.
Removed the last instance if a `tertiary` button and fixed a TODO:
<img width="509" alt="Screenshot 2023-06-15 at 22 34 36"
src="https://github.com/go-gitea/gitea/assets/115237/8a16ae7b-2b17-439b-a096-60a52724e3d6 "> 
						
						
					 
					
						2023-06-17 08:15:33 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b71cb7acdc 
							
						 
					 
					
						
						
							
							Use fetch to send requests to create issues/comments ( #25258 )  
						
						... 
						
						
						
						Follow #23290 
Network error won't make content lost. And this is a much better
approach than "loading-button".
The UI is not perfect and there are still some TODOs, they can be done
in following PRs, not a must in this PR's scope.
<details>

</details> 
						
						
					 
					
						2023-06-16 06:32:43 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6db66d8ca4 
							
						 
					 
					
						
						
							
							Fix some UI alignments ( #25277 )  
						
						... 
						
						
						
						Fixes: https://github.com/go-gitea/gitea/issues/25282 
Fix the problems:
1. The `repo-button-row` had various patches before, this PR makes it
consistent
2. The "Add File" has wrong CSS class "icon", remove it
3. The "Add File" padding was overridden by "!important", fix it by
`.repo-button-row .button.dropdown` with comment
4. The selector `.ui.segments ~ .ui.top.attached.header` is incorrect,
it should use `+` 
						
						
					 
					
						2023-06-15 15:12:08 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							14b802e7ad 
							
						 
					 
					
						
						
							
							Remove fomantic inverted variations ( #25286 )  
						
						... 
						
						
						
						Remove all Fomantic `inverted` variations, we are no using any of them.
This reduces the index CSS bundle by 98kB. 
						
						
					 
					
						2023-06-15 10:40:34 -04:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8e0316c321 
							
						 
					 
					
						
						
							
							Fix issue and commit status popup padding ( #25254 )  
						
						... 
						
						
						
						Close  #25249 
Use "dialog" for the role

---------
Co-authored-by: silverwind <me@silverwind.io> 
					
						2023-06-15 10:09:16 +02:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							73ae71824d 
							
						 
					 
					
						
						
							
							Show OAuth2 errors to end users ( #25261 )  
						
						... 
						
						
						
						Partially fix  #23936 


 
						
						
					 
					
						2023-06-15 01:12:50 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							46c17c8029 
							
						 
					 
					
						
						
							
							Use flex to align SVG and text ( #25163 )  
						
						... 
						
						
						
						The code can be as simple as:
```html
<div class="flex-text-block">{{svg "octicon-alert"}} {{svg "octicon-x"}} text (block)</div>
<div><div class="flex-text-inline">{{svg "octicon-alert"}} {{svg "octicon-x"}} text</div> (inline)</div>
<div><button class="ui red button">{{svg "octicon-alert" 24}} {{svg "octicon-x" 24}} text</button></div>
```

---------
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-14 16:40:15 +00:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a43ea22479 
							
						 
					 
					
						
						
							
							Change form actions to fetch for submit review box ( #25219 )  
						
						... 
						
						
						
						Co-author: @wxiaoguang 
Close  #25096  
The way to fix it in this PR is to change form submit to fetch using
formData, and add flags to avoid post repeatedly.
Should be able to apply to more forms that have the same issue after
this PR.
In the demo below, 'approve' is clicked several times, and then
'comment' is clicked several time after 'request changes' clicked.
After:
https://github.com/go-gitea/gitea/assets/17645053/beabeb1d-fe66-4b76-b048-4f022b4e83a0 
Update: screenshots from /devtest
>

> 
>

> 
>

---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
						
						
					 
					
						2023-06-14 16:01:37 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							4f3253feb9 
							
						 
					 
					
						
						
							
							Revert overflow: overlay (revert  #21850 ) ( #25231 )  
						
						... 
						
						
						
						It causes not only one issue like #25221  (the footer width was also
affected by that change and was fixed some time ago)
The problem of "overflow: overlay" (#21850 ) is:
* It's not widely supported and is non-standard
https://caniuse.com/css-overflow-overlay 
* It's not widely tested in Gitea (some standard layout like `ui
container + ui grid` may break it).
* The benefit seems smaller than the problems it brings.
So, I think it is good to revert it.
----
Let's leave enough time for testing and reviewing.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: silverwind <me@silverwind.io> 
						
						
					 
					
						2023-06-13 21:17:14 +02:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6bbccdd177 
							
						 
					 
					
						
						
							
							Improve AJAX link and modal confirm dialog ( #25210 )  
						
						... 
						
						
						
						Clarify the "link-action" behavior:
>  // A "link-action" can post AJAX request to its "data-url"
> // Then the browser is redirect to: the "redirect" in response, or
"data-redirect" attribute, or current URL by reloading.
And enhance the "link-action" to support showing a modal dialog for
confirm. A similar general approach could also help PRs like
https://github.com/go-gitea/gitea/pull/22344#discussion_r1062883436 
> // If the "link-action" has "data-modal-confirm(-html)" attribute, a
confirm modal dialog will be shown before taking action.
And a lot of duplicate code can be removed now. A good framework design
can help to avoid code copying&pasting.
---------
Co-authored-by: silverwind <me@silverwind.io> 
						
						
					 
					
						2023-06-13 12:10:10 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a51b115b0a 
							
						 
					 
					
						
						
							
							Use inline SVG for built-in OAuth providers ( #25171 )  
						
						... 
						
						
						
						The plan is that all built-in auth providers use inline SVG for more
flexibility in styling and to get the GitHub icon to follow
`currentcolor`. This only removes the `public/img/auth` directory and
adds the missing svgs to our svg build.
It should map the built-in providers to these SVGs and render them. If
the user has set a Icon URL, it should render that as an `img` tag
instead.
```
gitea-azure-ad
gitea-bitbucket
gitea-discord
gitea-dropbox
gitea-facebook
gitea-gitea
gitea-gitlab
gitea-google
gitea-mastodon
gitea-microsoftonline
gitea-nextcloud
gitea-twitter
gitea-yandex
octicon-mark-github
```
GitHub logo is now white again on dark theme:
<img width="431" alt="Screenshot 2023-06-12 at 21 45 34"
src="https://github.com/go-gitea/gitea/assets/115237/27a43504-d60a-4132-a502-336b25883e4d ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> 
						
						
					 
					
						2023-06-13 10:51:02 +00:00 
						 
				 
			
				
					
						
							
							
								Punit Inani 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2ad2d5a6ce 
							
						 
					 
					
						
						
							
							Disable Create column button while the column name is empty  ( #25192 )  
						
						... 
						
						
						
						
Fixes  #25116  
						
						
					 
					
						2023-06-13 09:57:03 +00:00 
						 
				 
			
				
					
						
							
							
								Jonathan Tran 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a583c56306 
							
						 
					 
					
						
						
							
							Change access token UI to select dropdowns ( #25109 )  
						
						... 
						
						
						
						The current UI to create API access tokens uses checkboxes that have a
complicated relationship where some need to be checked and/or disabled
in certain states. It also requires that a user interact with it to
understand what their options really are.
This branch changes to use `<select>`s. It better fits the available
options, and it's closer to [GitHub's
UI](https://github.com/settings/personal-access-tokens/new ), which is
good, in my opinion. It's more mobile friendly since the tap-areas are
larger. If we ever add more permissions, like Maintainer, there's a
natural place that doesn't take up more screen real-estate.
This branch also fixes a few minor issues:
- Hide the error about selecting at least one permission after second
submission
- Fix help description to call it "authorization" since that's what
permissions are about (not authentication)
Related: #24767 .
<img width="883" alt="Screenshot 2023-06-07 at 5 07 34 PM"
src="https://github.com/go-gitea/gitea/assets/10803/6b63d807-c9be-4a4b-8e53-ecab6cbb8f76 ">
---
When it's open:
<img width="881" alt="Screenshot 2023-06-07 at 5 07 59 PM"
src="https://github.com/go-gitea/gitea/assets/10803/2432c6d0-39c2-4ca4-820e-c878ffdbfb69 "> 
						
						
					 
					
						2023-06-13 15:55:48 +08:00 
						 
				 
			
				
					
						
							
							
								Jonathan Tran 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							f62cd2f473 
							
						 
					 
					
						
						
							
							Fix task list checkbox toggle to work with YAML front matter ( #25184 )  
						
						... 
						
						
						
						Fixes  #25160 .
`data-source-position` of checkboxes in a task list was incorrect
whenever there was YAML front matter. This would result in issue content
or PR descriptions getting corrupted with random `x` or space characters
when a user checked or unchecked a task. 
					
						2023-06-13 14:44:47 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d8e45608d6 
							
						 
					 
					
						
						
							
							Remove hacky patch for "safari emoji glitch fix"  ( #25208 )  
						
						... 
						
						
						
						According to my test, the UI (emoji) is fine in Safari
And actually the code is just dead code, because the "resize" event is
never fired on page loading. So for most cases users just view the pages
without this hacky patch, nobody ever complains. 
						
						
					 
					
						2023-06-12 15:44:53 +00:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3318001880 
							
						 
					 
					
						
						
							
							Fix fullscreen for action  ( #25200 )  
						
						... 
						
						
						
						An error occurs when clicking on `show full screen` on action page.
<img width="1440" alt="Screen Shot 2023-06-12 at 13 06 52"
src="https://github.com/go-gitea/gitea/assets/17645053/1d4ded3c-fb77-4dd8-9201-24d0696f96eb ">
class name has changed in #25134 , so the selector is not working. 
Enhance the selectors to fix this. 
						
						
					 
					
						2023-06-12 10:18:01 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							96f9c11821 
							
						 
					 
					
						
						
							
							Minor arc-green color tweaks ( #25175 )  
						
						... 
						
						
						
						Some minor color tweaks
<img width="1271" alt="Screenshot 2023-06-09 at 13 29 25"
src="https://github.com/go-gitea/gitea/assets/115237/b7b34995-5d34-461f-8d19-4f5755a98109 ">
<img width="1272" alt="Screenshot 2023-06-09 at 13 31 20"
src="https://github.com/go-gitea/gitea/assets/115237/63c866b4-797e-46ed-ba28-b1162ccd3e15 ">
<img width="1276" alt="Screenshot 2023-06-09 at 13 32 21"
src="https://github.com/go-gitea/gitea/assets/115237/de7ee02e-d0c7-4979-a8aa-0fd03e8db491 ">
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-09 15:17:30 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6a075589bf 
							
						 
					 
					
						
						
							
							Fix mobile navbar and misc cleanups ( #25134 )  
						
						... 
						
						
						
						- Fix and improve mobile navbar layout
- Apply all cleanups suggested in
https://github.com/go-gitea/gitea/pull/25111 
- Make media query breakpoints match Fomantic's exactly
- Clean up whitespace in class on navbar items
Mobile navbar before and after:
<img width="745" alt="Screenshot 2023-06-08 at 08 40 56"
src="https://github.com/go-gitea/gitea/assets/115237/ca84b239-b10f-41db-8c06-dcf2b6dd9d28 ">
<img width="739" alt="Screenshot 2023-06-08 at 08 41 23"
src="https://github.com/go-gitea/gitea/assets/115237/09133c54-eb7e-4110-858c-ead23c3b7521 ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-09 09:10:51 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							623b3b590e 
							
						 
					 
					
						
						
							
							Button and color enhancements ( #24989 )  
						
						... 
						
						
						
						- Various corrections to button styles, especially secondary
- Remove focus highlight, it's annoying when it stays on button after
press
- Clearly define ghost and link buttons with demos in devtest
- Remove black, grey and tertiary buttons, they should not be used
- Make `arc-green` slightly darker
<img width="1226" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/8d89786a-01ab-40f8-ae5a-e17f40e35084 ">
<img width="1249" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/83651e6d-3c27-46ff-b8bd-ff344d70e949 ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io> 
						
						
					 
					
						2023-06-09 08:37:47 +00:00