12 Commits

Author	SHA1	Message	Date
Lunny Xiao	cc3910d8c3	Fix index generation parallelly failure (#25235) ... Fix #22109 --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-15 02:14:43 +02:00
Lunny Xiao	315124b469	Fix parallelly generating index failure with Mysql (#24567)	2023-06-05 10:33:47 +00:00
Jason Song	c84238800b	Refactor setting.Database.UseXXX to methods (#23354) ... Replace #23350. Refactor `setting.Database.UseMySQL` to `setting.Database.Type.IsMySQL()`. To avoid mismatching between `Type` and `UseXXX`. This refactor can fix the bug mentioned in #23350, so it should be backported.	2023-03-07 18:51:06 +08:00
Lunny Xiao	f7ade6de7c	Fix generate index failure possibility on postgres (#21998) ... @wxiaoguang Please review Co-authored-by: silverwind <me@silverwind.io>	2022-12-02 11:15:36 +08:00
Lunny Xiao	b2c4870481	Fix parallel creating commit status bug with tests (#21911) ... This PR is a follow up of #21469 Co-authored-by: Lauris BH <lauris@nix.lv>	2022-12-01 00:41:49 +08:00
flynnnnnnnnnn	e81ccc406b	Implement FSFE REUSE for golang files (#21840) ... Change all license headers to comply with REUSE specification. Fix #16132 Co-authored-by: flynnnnnnnnnn <flynnnnnnnnnn@github> Co-authored-by: John Olheiser <john.olheiser@gmail.com>	2022-11-27 18:20:29 +00:00
wxiaoguang	6f48a36227	Refactor GetNextResourceIndex to make it work properly with transaction (#21469) ... Related: * #21362 This PR uses a general and stable method to generate resource index (eg: Issue Index, PR Index) If the code looks good, I can add more tests ps: please skip the diff, only have a look at the new code. It's entirely re-written. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-16 18:44:16 +08:00
Wim	cb50375e2b	Add more linters to improve code readability (#19989) ... Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability - nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length. - unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions - wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements. - notlintlint - Reports ill-formed or insufficient nolint directives - stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent - excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)	2022-06-20 12:02:49 +02:00
Lunny Xiao	1a9821f57a	Move issues related files into models/issues (#19931) ... * Move access and repo permission to models/perm/access * fix test * fix git test * Move functions sequence * Some improvements per @KN4CK3R and @delvh * Move issues related code to models/issues * Move some issues related sub package * Merge * Fix test * Fix test * Fix test * Fix test * Rename some files	2022-06-13 17:37:59 +08:00
Lunny Xiao	fd7d83ace6	Move almost all functions' parameter db.Engine to context.Context (#19748) ... * Move almost all functions' parameter db.Engine to context.Context * remove some unnecessary wrap functions	2022-05-20 22:08:52 +08:00
Lunny Xiao	d9c69596ff	Fix commit status index problem (#17061) ... * Fix commit status index problem * remove unused functions * Add fixture and test for migration * Fix lint * Fix fixture * Fix lint * Fix test * Fix bug * Fix bug	2021-09-23 18:50:06 +08:00
Lunny Xiao	a4bfef265d	Move db related basic functions to models/db (#17075) ... * Move db related basic functions to models/db * Fix lint * Fix lint * Fix test * Fix lint * Fix lint * revert unnecessary change * Fix test * Fix wrong replace string * Use *Context * Correct committer spelling and fix wrong replaced words Co-authored-by: zeripath <art27@cantab.net>	2021-09-19 19:49:59 +08:00