0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-19 12:54:34 +01:00
gitea/models/repo
yp05327 daf2a4c047
Fix wrong display of recently pushed notification (#25812)
There's a bug in #25715: 
If user pushed a commit into another repo with same branch name, the
no-related repo will display the recently pushed notification
incorrectly.
It is simple to fix this, we should match the repo id in the sql query.


![image](https://github.com/go-gitea/gitea/assets/18380374/9411a926-16f1-419e-a1b5-e953af38bab1)
The latest commit is 2 weeks ago.

![image](https://github.com/go-gitea/gitea/assets/18380374/52f9ab22-4999-43ac-a86f-6d36fb1e0411)

The notification comes from another repo with same branch name:

![image](https://github.com/go-gitea/gitea/assets/18380374/a26bc335-8e5b-4b9c-a965-c3dc3fa6f252)


After:
In forked repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/ce6ffc35-deb7-4be7-8b09-184207392f32)
New PR Link will redirect to the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/7b98e76f-0c75-494c-9462-80cf9f98e786)
In the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f6a821b-e51a-4bbd-9980-d9eb94a3c847)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/1ce8c879-9f11-4312-8c32-695d7d9af0df)

In the same repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/64b56073-4d0e-40c4-b8a0-80be7a775f69)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/96e1b6a3-fb98-40ee-b2ee-648039fb0dcf)

08/15 Update:
Follow #26257, added permission check and logic fix mentioned in
https://github.com/go-gitea/gitea/pull/26257#discussion_r1294085203


2024/04/25 Update:
Fix #30611

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-21 17:00:35 +00:00
..
archiver.go
attachment_test.go
attachment.go
avatar.go Refactor AppURL usage (#30885) 2024-05-07 08:26:13 +00:00
collaboration_test.go
collaboration.go
fork_test.go
fork.go
git.go
issue.go Clean up log messages (#30313) 2024-04-07 19:17:06 +08:00
language_stats.go
main_test.go
mirror.go
pushmirror_test.go
pushmirror.go
redirect_test.go
redirect.go
release_test.go
release.go
repo_indexer.go
repo_list_test.go
repo_list.go Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
repo_test.go
repo_unit_test.go
repo_unit.go Allow everyone to read or write a wiki by a repo unit setting (#30495) 2024-04-17 15:58:37 +00:00
repo.go
search.go Get repo list with OrderBy alpha should respect owner too (#30784) 2024-05-06 16:36:02 +02:00
star_test.go
star.go
topic_test.go Refactor topic Find functions and add more tests for pagination (#30127) 2024-03-29 11:38:16 +08:00
topic.go Refactor topic Find functions and add more tests for pagination (#30127) 2024-03-29 11:38:16 +08:00
update.go
upload.go
user_repo_test.go Get repo assignees and reviewers should ignore deactivated users (#30770) 2024-04-30 08:43:08 +00:00
user_repo.go Get repo assignees and reviewers should ignore deactivated users (#30770) 2024-04-30 08:43:08 +00:00
watch_test.go
watch.go
wiki_test.go
wiki.go