mirror of
https://github.com/go-gitea/gitea.git
synced 2025-11-04 06:24:11 +01:00
da5ce5c8e7
Instance signing rule `pubkey` is described as "Only sign if the user has a public key", however if the user only has SSH public keys, this check will fail, as it only checks for GPG keys. Changed the `pubkey` checks to call a helper `userHasPubkeys` which sequentially checks for GPG, then SSH keys. Related #34341 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
40 lines
1.1 KiB
Go
40 lines
1.1 KiB
Go
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package asymkey
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestUserHasPubkeys(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
test := func(t *testing.T, userID int64, expectedHasGPG, expectedHasSSH bool) {
|
|
ctx := t.Context()
|
|
hasGPG, err := userHasPubkeysGPG(ctx, userID)
|
|
require.NoError(t, err)
|
|
hasSSH, err := userHasPubkeysSSH(ctx, userID)
|
|
require.NoError(t, err)
|
|
hasPubkeys, err := userHasPubkeys(ctx, userID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expectedHasGPG, hasGPG)
|
|
assert.Equal(t, expectedHasSSH, hasSSH)
|
|
assert.Equal(t, expectedHasGPG || expectedHasSSH, hasPubkeys)
|
|
}
|
|
|
|
t.Run("AllowUserWithGPGKey", func(t *testing.T) {
|
|
test(t, 36, true, false) // has gpg
|
|
})
|
|
t.Run("AllowUserWithSSHKey", func(t *testing.T) {
|
|
test(t, 2, false, true) // has ssh
|
|
})
|
|
t.Run("DenyUserWithNoKeys", func(t *testing.T) {
|
|
test(t, 1, false, false) // no pubkey
|
|
})
|
|
}
|