0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-30 14:24:27 +01:00
gitea/services/pull
zeripath 3cab3bee57
Replies to outdated code comments should also be outdated (#13217)
* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2020-11-04 17:55:15 -05:00
..
check_test.go Only check for conflicts/merging if the PR has not been merged in the interim (#10132) 2020-02-10 01:09:31 +02:00
check.go [Enhancement] Allow admin to merge pr with protected file changes (#12078) 2020-10-13 14:50:57 -04:00
commit_status.go Fix bug on pull view when required status check no ci result (#10648) 2020-03-07 07:33:20 +00:00
lfs.go
main_test.go
merge.go go-version constraints ignore pre-releases (#13234) 2020-10-21 11:42:08 -04:00
patch.go [Enhancement] Allow admin to merge pr with protected file changes (#12078) 2020-10-13 14:50:57 -04:00
pull_test.go Move PushToBaseRepo from models to services/pull (#9352) 2019-12-15 04:28:51 +01:00
pull.go [Enhancement] Allow admin to merge pr with protected file changes (#12078) 2020-10-13 14:50:57 -04:00
review.go Replies to outdated code comments should also be outdated (#13217) 2020-11-04 17:55:15 -05:00
temp_repo.go Handle more pathological branch and tag names (#11843) 2020-06-11 19:49:47 -04:00
update.go Check Push permissions on IsUserAllowedToUpdate (#11448) 2020-05-16 20:48:30 -04:00