0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-11 19:14:42 +01:00
gitea/routers/api/v1
Otto Richter (fnetX) 3362620ee3
Fix api error message if fork exists (#24487)
On the @Forgejo instance of Codeberg, we discovered that forking a repo
which is already forked now returns a 500 Internal Server Error, which
is unexpected. This is an attempt at fixing this.

The error message in the log:
~~~
2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E]
[6450cb8e-113] ForkRepository: repository is already forked by user
[uname: ...., repo path: .../..., fork path: .../...]
~~~

The service that is used for forking returns a custom error message
which is not checked against.

About the order of options:
The case that the fork already exists should be more common, followed by
the case that a repo with the same name already exists for other
reasons. The case that the global repo limit is hit is probably not the
likeliest.

Co-authored-by: Otto Richter <otto@codeberg.org>
Co-authored-by: Giteabot <teabot@gitea.io>
2023-05-02 20:26:38 -04:00
..
activitypub Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) 2023-04-04 10:08:23 +08:00
admin Fix unclear IsRepositoryExist logic (#24374) 2023-04-28 14:14:26 -04:00
misc Use globally shared HTMLRender (#24436) 2023-04-30 08:22:23 -04:00
notify Move convert package to services (#22264) 2022-12-29 10:57:15 +08:00
org Fix admin team access mode value in team_unit table (#24012) 2023-04-13 21:06:10 +02:00
packages Add Debian package registry (#24426) 2023-05-02 12:31:35 -04:00
repo Fix api error message if fork exists (#24487) 2023-05-02 20:26:38 -04:00
settings Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
swagger Add API for gitignore templates (#22783) 2023-04-27 11:51:20 +08:00
user Add activity feeds API (#23494) 2023-04-04 21:35:31 +08:00
utils Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
api.go Add API for gitignore templates (#22783) 2023-04-27 11:51:20 +08:00
auth_windows.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
auth.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00