mirror of
https://github.com/go-gitea/gitea.git
synced 2026-03-23 12:15:34 +01:00
## Overview This PR introduces granular permission controls for Gitea Actions tokens (`GITEA_TOKEN`), aligning Gitea's security model with GitHub Actions standards while maintaining compatibility with Gitea's unique repository unit system. It addresses the need for finer access control by allowing administrators and repository owners to define default token permissions, set maximum permission ceilings, and control cross-repository access within organizations. ## Key Features ### 1. Granular Token Permissions - **Standard Keyword Support**: Implements support for the `permissions:` keyword in workflow and job YAML files (e.g., `contents: read`, `issues: write`). - **Permission Modes**: - **Permissive**: Default write access for most units (backwards compatible). - **Restricted**: Default read-only access for `contents` and `packages`, with no access to other units. - ~~**Custom**: Allows defining specific default levels for each unit type (Code, Issues, PRs, Packages, etc.).~~**EDIT removed UI was confusing** - **Clamping Logic**: Workflow-defined permissions are automatically "clamped" by repository or organization-level maximum settings. Workflows cannot escalate their own permissions beyond these limits. ### 2. Organization & Repository Settings - **Settings UI**: Added new settings pages at both Organization and Repository levels to manage Actions token defaults and maximums. - **Inheritance**: Repositories can be configured to "Follow organization-level configuration," simplifying management across large organizations. - **Cross-Repository Access**: Added a policy to control whether Actions workflows can access other repositories or packages within the same organization. This can be set to "None," "All," or restricted to a "Selected" list of repositories. ### 3. Security Hardening - **Fork Pull Request Protection**: Tokens for workflows triggered by pull requests from forks are strictly enforced as read-only, regardless of repository settings. - ~~**Package Access**: Actions tokens can now only access packages explicitly linked to a repository, with cross-repo access governed by the organization's security policy.~~ **EDIT removed https://github.com/go-gitea/gitea/pull/36173#issuecomment-3873675346** - **Git Hook Integration**: Propagates Actions Task IDs to git hooks to ensure that pushes performed by Actions tokens respect the specific permissions granted at runtime. ### 4. Technical Implementation - **Permission Persistence**: Parsed permissions are calculated at job creation and stored in the `action_run_job` table. This ensures the token's authority is deterministic throughout the job's lifecycle. - **Parsing Priority**: Implemented a priority system in the YAML parser where the broad `contents` scope is applied first, allowing granular scopes like `code` or `releases` to override it for precise control. - **Re-runs**: Permissions are re-evaluated during a job re-run to incorporate any changes made to repository settings in the interim. ### How to Test 1. **Unit Tests**: Run `go test ./services/actions/...` and `go test ./models/repo/...` to verify parsing logic and permission clamping. 2. **Integration Tests**: Comprehensive tests have been added to `tests/integration/actions_job_token_test.go` covering: - Permissive vs. Restricted mode behavior. - YAML `permissions:` keyword evaluation. - Organization cross-repo access policies. - Resource access (Git, API, and Packages) under various permission configs. 3. **Manual Verification**: - Navigate to **Site/Org/Repo Settings -> Actions -> General**. - Change "Default Token Permissions" and verify that newly triggered workflows reflect these changes in their `GITEA_TOKEN` capabilities. - Attempt a cross-repo API call from an Action and verify the Org policy is enforced. ## Documentation Added a PR in gitea's docs for this : https://gitea.com/gitea/docs/pulls/318 ## UI: <img width="1366" height="619" alt="Screenshot 2026-01-24 174112" src="https://github.com/user-attachments/assets/bfa29c9a-4ea5-4346-9410-16d491ef3d44" /> <img width="1360" height="621" alt="Screenshot 2026-01-24 174048" src="https://github.com/user-attachments/assets/d5ec46c8-9a13-4874-a6a4-fb379936cef5" /> /fixes #24635 /claim #24635 --------- Signed-off-by: Excellencedev <ademiluyisuccessandexcellence@gmail.com> Signed-off-by: ChristopherHX <christopher.homberger@web.de> Signed-off-by: silverwind <me@silverwind.io> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: ChristopherHX <christopher.homberger@web.de> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
257 lines
7.1 KiB
Go
257 lines
7.1 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package user
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/modules/cache"
|
|
"code.gitea.io/gitea/modules/json"
|
|
setting_module "code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"xorm.io/builder"
|
|
"xorm.io/xorm/convert"
|
|
)
|
|
|
|
// Setting is a key value store of user settings
|
|
type Setting struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
UserID int64 `xorm:"index unique(key_userid)"` // to load all of someone's settings
|
|
SettingKey string `xorm:"varchar(255) index unique(key_userid)"` // ensure key is always lowercase
|
|
SettingValue string `xorm:"text"`
|
|
}
|
|
|
|
// TableName sets the table name for the settings struct
|
|
func (s *Setting) TableName() string {
|
|
return "user_setting"
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(Setting))
|
|
}
|
|
|
|
// ErrUserSettingIsNotExist represents an error that a setting is not exist with special key
|
|
type ErrUserSettingIsNotExist struct {
|
|
Key string
|
|
}
|
|
|
|
// Error implements error
|
|
func (err ErrUserSettingIsNotExist) Error() string {
|
|
return fmt.Sprintf("Setting[%s] is not exist", err.Key)
|
|
}
|
|
|
|
func (err ErrUserSettingIsNotExist) Unwrap() error {
|
|
return util.ErrNotExist
|
|
}
|
|
|
|
// IsErrUserSettingIsNotExist return true if err is ErrSettingIsNotExist
|
|
func IsErrUserSettingIsNotExist(err error) bool {
|
|
_, ok := err.(ErrUserSettingIsNotExist)
|
|
return ok
|
|
}
|
|
|
|
// genSettingCacheKey returns the cache key for some configuration
|
|
func genSettingCacheKey(userID int64, key string) string {
|
|
return fmt.Sprintf("user_%d.setting.%s", userID, key)
|
|
}
|
|
|
|
// GetSetting returns the setting value via the key
|
|
func GetSetting(ctx context.Context, uid int64, key string) (string, error) {
|
|
return cache.GetString(genSettingCacheKey(uid, key), func() (string, error) {
|
|
res, err := GetSettingNoCache(ctx, uid, key)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return res.SettingValue, nil
|
|
})
|
|
}
|
|
|
|
// GetSettingNoCache returns specific setting without using the cache
|
|
func GetSettingNoCache(ctx context.Context, uid int64, key string) (*Setting, error) {
|
|
v, err := GetSettings(ctx, uid, []string{key})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if len(v) == 0 {
|
|
return nil, ErrUserSettingIsNotExist{key}
|
|
}
|
|
return v[key], nil
|
|
}
|
|
|
|
// GetSettings returns specific settings from user
|
|
func GetSettings(ctx context.Context, uid int64, keys []string) (map[string]*Setting, error) {
|
|
settings := make([]*Setting, 0, len(keys))
|
|
if err := db.GetEngine(ctx).
|
|
Where("user_id=?", uid).
|
|
And(builder.In("setting_key", keys)).
|
|
Find(&settings); err != nil {
|
|
return nil, err
|
|
}
|
|
settingsMap := make(map[string]*Setting)
|
|
for _, s := range settings {
|
|
settingsMap[s.SettingKey] = s
|
|
}
|
|
return settingsMap, nil
|
|
}
|
|
|
|
// GetUserAllSettings returns all settings from user
|
|
func GetUserAllSettings(ctx context.Context, uid int64) (map[string]*Setting, error) {
|
|
settings := make([]*Setting, 0, 5)
|
|
if err := db.GetEngine(ctx).
|
|
Where("user_id=?", uid).
|
|
Find(&settings); err != nil {
|
|
return nil, err
|
|
}
|
|
settingsMap := make(map[string]*Setting)
|
|
for _, s := range settings {
|
|
settingsMap[s.SettingKey] = s
|
|
}
|
|
return settingsMap, nil
|
|
}
|
|
|
|
func validateUserSettingKey(key string) error {
|
|
if len(key) == 0 {
|
|
return errors.New("setting key must be set")
|
|
}
|
|
if strings.ToLower(key) != key {
|
|
return errors.New("setting key should be lowercase")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetUserSetting gets a specific setting for a user
|
|
func GetUserSetting(ctx context.Context, userID int64, key string, def ...string) (string, error) {
|
|
if err := validateUserSettingKey(key); err != nil {
|
|
return "", err
|
|
}
|
|
|
|
setting := &Setting{UserID: userID, SettingKey: key}
|
|
has, err := db.GetEngine(ctx).Get(setting)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if !has {
|
|
if len(def) == 1 {
|
|
return def[0], nil
|
|
}
|
|
return "", nil
|
|
}
|
|
return setting.SettingValue, nil
|
|
}
|
|
|
|
// DeleteUserSetting deletes a specific setting for a user
|
|
func DeleteUserSetting(ctx context.Context, userID int64, key string) error {
|
|
if err := validateUserSettingKey(key); err != nil {
|
|
return err
|
|
}
|
|
|
|
cache.Remove(genSettingCacheKey(userID, key))
|
|
_, err := db.GetEngine(ctx).Delete(&Setting{UserID: userID, SettingKey: key})
|
|
|
|
return err
|
|
}
|
|
|
|
// SetUserSetting updates a users' setting for a specific key
|
|
func SetUserSetting(ctx context.Context, userID int64, key, value string) error {
|
|
if err := validateUserSettingKey(key); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := upsertUserSettingValue(ctx, userID, key, value); err != nil {
|
|
return err
|
|
}
|
|
|
|
cc := cache.GetCache()
|
|
if cc != nil {
|
|
return cc.Put(genSettingCacheKey(userID, key), value, setting_module.CacheService.TTLSeconds())
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func upsertUserSettingValue(ctx context.Context, userID int64, key, value string) error {
|
|
return db.WithTx(ctx, func(ctx context.Context) error {
|
|
e := db.GetEngine(ctx)
|
|
|
|
// here we use a general method to do a safe upsert for different databases (and most transaction levels)
|
|
// 1. try to UPDATE the record and acquire the transaction write lock
|
|
// if UPDATE returns non-zero rows are changed, OK, the setting is saved correctly
|
|
// if UPDATE returns "0 rows changed", two possibilities: (a) record doesn't exist (b) value is not changed
|
|
// 2. do a SELECT to check if the row exists or not (we already have the transaction lock)
|
|
// 3. if the row doesn't exist, do an INSERT (we are still protected by the transaction lock, so it's safe)
|
|
//
|
|
// to optimize the SELECT in step 2, we can use an extra column like `revision=revision+1`
|
|
// to make sure the UPDATE always returns a non-zero value for existing (unchanged) records.
|
|
|
|
res, err := e.Exec("UPDATE user_setting SET setting_value=? WHERE setting_key=? AND user_id=?", value, key, userID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
rows, _ := res.RowsAffected()
|
|
if rows > 0 {
|
|
// the existing row is updated, so we can return
|
|
return nil
|
|
}
|
|
|
|
// in case the value isn't changed, update would return 0 rows changed, so we need this check
|
|
has, err := e.Exist(&Setting{UserID: userID, SettingKey: key})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if has {
|
|
return nil
|
|
}
|
|
|
|
// if no existing row, insert a new row
|
|
_, err = e.Insert(&Setting{UserID: userID, SettingKey: key, SettingValue: value})
|
|
return err
|
|
})
|
|
}
|
|
|
|
func GetUserSettingJSON[T any](ctx context.Context, userID int64, key string, def T) (ret T, _ error) {
|
|
ret = def
|
|
str, err := GetUserSetting(ctx, userID, key)
|
|
if err != nil {
|
|
return ret, err
|
|
}
|
|
|
|
conv, ok := any(&ret).(convert.ConversionFrom)
|
|
if !ok {
|
|
conv, ok = any(ret).(convert.ConversionFrom)
|
|
}
|
|
if ok {
|
|
if err := conv.FromDB(util.UnsafeStringToBytes(str)); err != nil {
|
|
return ret, err
|
|
}
|
|
} else {
|
|
if str == "" {
|
|
return ret, nil
|
|
}
|
|
err = json.Unmarshal(util.UnsafeStringToBytes(str), &ret)
|
|
}
|
|
return ret, err
|
|
}
|
|
|
|
func SetUserSettingJSON[T any](ctx context.Context, userID int64, key string, val T) (err error) {
|
|
conv, ok := any(&val).(convert.ConversionTo)
|
|
if !ok {
|
|
conv, ok = any(val).(convert.ConversionTo)
|
|
}
|
|
var bs []byte
|
|
if ok {
|
|
bs, err = conv.ToDB()
|
|
} else {
|
|
bs, err = json.Marshal(val)
|
|
}
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return SetUserSetting(ctx, userID, key, util.UnsafeBytesToString(bs))
|
|
}
|