0
0
mirror of https://github.com/go-gitea/gitea.git synced 2026-06-15 04:03:23 +02:00
silverwind 4cab370652
ci: address review feedback on shard scripts
- partition-by-shard.sh: fix off-by-one. `NR % t == r` placed item 1
  in shard `total`, item 2 in shard 1 — shifted by one. Switch to
  `(NR-1) % t == r` so shard 1 owns items 1, 1+t, 1+2t, ... as
  documented.
- test-integration-shard.sh: the `[A-Z]` after `Test` rejected
  `Test_Foo`-style names (28 such tests in tests/integration). Drop
  the [A-Z] and broaden the comment to match the actual regex.
- test-integration-shard.sh: drop `*testing.TB` alternative — there
  are zero matching tests in this codebase, so the simpler regex is
  exact.
- find-gogit-test-pkgs.sh: merge the `grep -vE` exclusion into the
  awk filter. Avoids a pipefail edge case where empty grep output
  would abort the pipeline before the friendly empty-list message
  fires; also one fewer process per invocation.
- Makefile test-integration: fail fast at Make level if TEST_SHARD
  is set without TEST_TOTAL_SHARDS, instead of letting the script's
  ${X:?...} surface a less obvious error.

All locals in the new bash scripts use UPPER_CASE to match the
existing tools/test-e2e.sh convention.

Co-Authored-By: Claude (Opus 4.7) <noreply@anthropic.com>
2026-05-09 06:52:20 +02:00
..