0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-29 03:54:25 +01:00
gitea/modules/migrations
zeripath c58bc4bf80
Prevent timer leaks in Workerpool and others (#11333)
There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-05-08 16:46:05 +01:00
..
base When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
error.go
git.go
gitea_test.go
gitea.go
github_test.go
github.go Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
gitlab_test.go When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
gitlab.go When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
main_test.go
migrate.go When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
update.go