mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-24 20:18:26 +02:00
ef927f9fa3
Compare API requests with a `^` or `~N` revision suffix (for example `compare/main...feature^`) were rejected with `400 Unsupported comparison syntax: ref with suffix`. The fix resolves the suffix to a commit before comparing, so `base...head^` and `~N` work on either side, the same as git. Only `^`/`~N` navigation is resolved. Pull request creation still requires plain branch refs, and the web compare page keeps rejecting suffixes since its branch selectors need separate UI work. Closes #33943
59 lines
1.8 KiB
Go
59 lines
1.8 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRefName(t *testing.T) {
|
|
// Test branch names (with and without slash).
|
|
assert.Equal(t, "foo", RefName("refs/heads/foo").BranchName())
|
|
assert.Equal(t, "feature/foo", RefName("refs/heads/feature/foo").BranchName())
|
|
|
|
// Test tag names (with and without slash).
|
|
assert.Equal(t, "foo", RefName("refs/tags/foo").TagName())
|
|
assert.Equal(t, "release/foo", RefName("refs/tags/release/foo").TagName())
|
|
|
|
// Test pull names
|
|
assert.Equal(t, "1", RefName("refs/pull/1/head").PullName())
|
|
assert.True(t, RefName("refs/pull/1/head").IsPull())
|
|
assert.True(t, RefName("refs/pull/1/merge").IsPull())
|
|
assert.Equal(t, "my/pull", RefName("refs/pull/my/pull/head").PullName())
|
|
|
|
// Test for branch names
|
|
assert.Equal(t, "main", RefName("refs/for/main").ForBranchName())
|
|
assert.Equal(t, "my/branch", RefName("refs/for/my/branch").ForBranchName())
|
|
|
|
// Test commit hashes.
|
|
assert.Equal(t, "c0ffee", RefName("c0ffee").ShortName())
|
|
}
|
|
|
|
func TestRefWebLinkPath(t *testing.T) {
|
|
assert.Equal(t, "branch/foo", RefName("refs/heads/foo").RefWebLinkPath())
|
|
assert.Equal(t, "tag/foo", RefName("refs/tags/foo").RefWebLinkPath())
|
|
assert.Equal(t, "commit/c0ffee", RefName("c0ffee").RefWebLinkPath())
|
|
}
|
|
|
|
func TestParseRefSuffix(t *testing.T) {
|
|
cases := []struct {
|
|
ref, name, suffix string
|
|
}{
|
|
{"main", "main", ""},
|
|
{"main^", "main", "^"},
|
|
{"main^2", "main", "^2"},
|
|
{"main~3", "main", "~3"},
|
|
{"main@{yesterday}", "main", "@{yesterday}"},
|
|
{"main~2^", "main", "~2^"},
|
|
{"main^~2", "main", "^~2"},
|
|
}
|
|
for _, c := range cases {
|
|
name, suffix := ParseRefSuffix(c.ref)
|
|
assert.Equal(t, c.name, name, "ref: %s", c.ref)
|
|
assert.Equal(t, c.suffix, suffix, "ref: %s", c.ref)
|
|
}
|
|
}
|