mirror of
https://github.com/go-gitea/gitea.git
synced 2026-03-07 14:02:15 +01:00
761b9d439b
The `PATCH /api/v1/repos/{owner}/{repo}` endpoint silently ignores pull
request config fields (like `default_delete_branch_after_merge`,
`allow_squash_merge`, etc.) unless `has_pull_requests: true` is also
included in the request body. This is because the entire PR unit config
block was gated behind `if opts.HasPullRequests != nil`.
This PR restructures the logic so that PR config options are applied
whenever the pull request unit already exists on the repo, without
requiring `has_pull_requests` to be explicitly set. A new unit is only
created when `has_pull_requests: true` is explicitly sent.
Fixes https://github.com/go-gitea/gitea/issues/36466
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
84 lines
1.7 KiB
Go
84 lines
1.7 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package optional
|
|
|
|
import "strconv"
|
|
|
|
// Option is a generic type that can hold a value of type T or be empty (None).
|
|
//
|
|
// It must use the slice type to work with "chi" form values binding:
|
|
// * non-existing value are represented as an empty slice (None)
|
|
// * existing value is represented as a slice with one element (Some)
|
|
// * multiple values are represented as a slice with multiple elements (Some), the Value is the first element (not well-defined in this case)
|
|
type Option[T any] []T
|
|
|
|
func None[T any]() Option[T] {
|
|
return nil
|
|
}
|
|
|
|
func Some[T any](v T) Option[T] {
|
|
return Option[T]{v}
|
|
}
|
|
|
|
func FromPtr[T any](v *T) Option[T] {
|
|
if v == nil {
|
|
return None[T]()
|
|
}
|
|
return Some(*v)
|
|
}
|
|
|
|
func FromMapLookup[K comparable, V any](m map[K]V, k K) Option[V] {
|
|
if v, ok := m[k]; ok {
|
|
return Some(v)
|
|
}
|
|
return None[V]()
|
|
}
|
|
|
|
func FromNonDefault[T comparable](v T) Option[T] {
|
|
var zero T
|
|
if v == zero {
|
|
return None[T]()
|
|
}
|
|
return Some(v)
|
|
}
|
|
|
|
func (o Option[T]) Has() bool {
|
|
return o != nil
|
|
}
|
|
|
|
func (o Option[T]) Value() T {
|
|
var zero T
|
|
return o.ValueOrDefault(zero)
|
|
}
|
|
|
|
func (o Option[T]) ValueOrDefault(v T) T {
|
|
if o.Has() {
|
|
return o[0]
|
|
}
|
|
return v
|
|
}
|
|
|
|
// ParseBool get the corresponding optional.Option[bool] of a string using strconv.ParseBool
|
|
func ParseBool(s string) Option[bool] {
|
|
v, e := strconv.ParseBool(s)
|
|
if e != nil {
|
|
return None[bool]()
|
|
}
|
|
return Some(v)
|
|
}
|
|
|
|
func AssignPtrValue[T comparable](changed *bool, target, src *T) {
|
|
if src != nil && *src != *target {
|
|
*target = *src
|
|
*changed = true
|
|
}
|
|
}
|
|
|
|
func AssignPtrString[TO, FROM ~string](changed *bool, target *TO, src *FROM) {
|
|
if src != nil && string(*src) != string(*target) {
|
|
*target = TO(*src)
|
|
*changed = true
|
|
}
|
|
}
|